[v1] media: mediatek: vcodec: Fix non subdev architecture open power fail

[PATCH] media: mediatek: vcodec: Fix non subdev architecture open power fail

Posted by Yunfei Dong 2 years, 3 months ago

According to subdev_bitmap bit value to open hardware power, need to
set subdev_bitmap value for non subdev architecture.

Signed-off-by: Yunfei Dong <yunfei.dong@mediatek.com>
---
 drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.c b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.c
index 995e6e2fb1ab..4103d7c1b638 100644
--- a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.c
+++ b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.c
@@ -386,6 +386,8 @@ static int mtk_vcodec_probe(struct platform_device *pdev)
 			mtk_v4l2_err("Main device of_platform_populate failed.");
 			goto err_reg_cont;
 		}
+	} else {
+		set_bit(MTK_VDEC_CORE, dev->subdev_bitmap);
 	}
 
 	ret = video_register_device(vfd_dec, VFL_TYPE_VIDEO, -1);
-- 
2.18.0

Re: [PATCH] media: mediatek: vcodec: Fix non subdev architecture open power fail

Posted by Chen-Yu Tsai 2 years, 3 months ago

On Fri, Jun 17, 2022 at 11:21 AM Yunfei Dong <yunfei.dong@mediatek.com> wrote:
>
> According to subdev_bitmap bit value to open hardware power, need to
> set subdev_bitmap value for non subdev architecture.
>
> Signed-off-by: Yunfei Dong <yunfei.dong@mediatek.com>

Fixes: c05bada35f01 ("media: mtk-vcodec: Add to support multi hardware decode")

?

ChenYu

Re: [PATCH] media: mediatek: vcodec: Fix non subdev architecture open power fail

Posted by yunfei.dong@mediatek.com 2 years, 3 months ago

Hi Chen-Yu,

Thanks for your suggestion.
On Fri, 2022-06-17 at 14:56 +0800, Chen-Yu Tsai wrote:
> On Fri, Jun 17, 2022 at 11:21 AM Yunfei Dong <
> yunfei.dong@mediatek.com> wrote:
> > 
> > According to subdev_bitmap bit value to open hardware power, need
> > to
> > set subdev_bitmap value for non subdev architecture.
> > 
> > Signed-off-by: Yunfei Dong <yunfei.dong@mediatek.com>
> 
> Fixes: c05bada35f01 ("media: mtk-vcodec: Add to support multi
> hardware decode")
> 
> ?
> 
> ChenYu
Fix it in patch v2.

Best Regards,
Yunfei Dong