[PATCH mtd-utils] nandflipbits: fix corrupted oob

Christophe Kerello posted 1 patch 3 years, 10 months ago
nand-utils/nandflipbits.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
[PATCH mtd-utils] nandflipbits: fix corrupted oob
Posted by Christophe Kerello 3 years, 10 months ago
If a bit is flipped in block 1 or higher, the OOB is corrupted with the
OOB of block 0. Mtd_read_oob API has to take into account the block number
to be able to calculate the right offset.

Fixes: 9fc8db29cf62 ("mtd-utils: Add nandflipbits tool")
Signed-off-by: Christophe Kerello <christophe.kerello@foss.st.com>
---
 nand-utils/nandflipbits.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/nand-utils/nandflipbits.c b/nand-utils/nandflipbits.c
index aa6850f..cd66d0b 100644
--- a/nand-utils/nandflipbits.c
+++ b/nand-utils/nandflipbits.c
@@ -249,7 +249,9 @@ int main(int argc, char **argv)
 
 			bufoffs += mtd.min_io_size;
 
-			ret = mtd_read_oob(mtd_desc, &mtd, fd, blkoffs,
+			ret = mtd_read_oob(mtd_desc, &mtd, fd,
+					   bit_to_flip->block * mtd.eb_size +
+					   blkoffs,
 					   mtd.oob_size, buffer + bufoffs);
 			if (ret) {
 				fprintf(stderr, "MTD OOB read failure\n");
-- 
2.25.1
Re: [PATCH mtd-utils] nandflipbits: fix corrupted oob
Posted by David Oberhollenzer 3 years, 10 months ago
Applied to mtd-utils.git master

Thanks,

David