mach-versatile: (platsmp-realview) Add missing of_node_put()

[PATCH v2] mach-versatile: (platsmp-realview) Add missing of_node_put()

Posted by Liang He 3 years, 10 months ago

In realview_smp_prepare_cpus(), the second of_find_matching_node()
has no corresponding of_node_put() when the node pointer is not
used anymore.

Signed-off-by: Liang He <windhl@126.com>
---
 changelog:

 v2: use real name for Sob
 v1: fix missing bug

 arch/arm/mach-versatile/platsmp-realview.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/mach-versatile/platsmp-realview.c b/arch/arm/mach-versatile/platsmp-realview.c
index 5d363385c801..059d796b26bc 100644
--- a/arch/arm/mach-versatile/platsmp-realview.c
+++ b/arch/arm/mach-versatile/platsmp-realview.c
@@ -66,6 +66,7 @@ static void __init realview_smp_prepare_cpus(unsigned int max_cpus)
 		return;
 	}
 	map = syscon_node_to_regmap(np);
+	of_node_put(np);
 	if (IS_ERR(map)) {
 		pr_err("PLATSMP: No syscon regmap\n");
 		return;
-- 
2.25.1

Re: [PATCH v2] mach-versatile: (platsmp-realview) Add missing of_node_put()

Posted by Linus Walleij 2 years, 7 months ago

On Thu, Jun 16, 2022 at 5:54 AM Liang He <windhl@126.com> wrote:

> In realview_smp_prepare_cpus(), the second of_find_matching_node()
> has no corresponding of_node_put() when the node pointer is not
> used anymore.
>
> Signed-off-by: Liang He <windhl@126.com>

Patch applied.

Yours,
Linus Walleij