[v2] ata: libata: add qc->flags in ata_qc_complete_template tracepoint

[PATCH v2] ata: libata: add qc->flags in ata_qc_complete_template tracepoint

Posted by Edward Wu 3 years, 11 months ago

Add flags value to check the result of ata completion

Fixes: 255c03d15a29 ("libata: Add tracepoints")
Link: https://lkml.kernel.org/r/20220616001615.11636-1-edwardwu@realtek.com
Signed-off-by: Edward Wu <edwardwu@realtek.com>
---
v2:
- Add Fixes tag

 include/trace/events/libata.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/trace/events/libata.h b/include/trace/events/libata.h
index d4e631aa976f..6025dd8ba4aa 100644
--- a/include/trace/events/libata.h
+++ b/include/trace/events/libata.h
@@ -288,6 +288,7 @@ DECLARE_EVENT_CLASS(ata_qc_complete_template,
 		__entry->hob_feature	= qc->result_tf.hob_feature;
 		__entry->nsect		= qc->result_tf.nsect;
 		__entry->hob_nsect	= qc->result_tf.hob_nsect;
+		__entry->flags		= qc->flags;
 	),
 
 	TP_printk("ata_port=%u ata_dev=%u tag=%d flags=%s status=%s " \
-- 
2.17.1

Re: [PATCH v2] ata: libata: add qc->flags in ata_qc_complete_template tracepoint

Posted by Damien Le Moal 3 years, 11 months ago

On 6/16/22 09:48, Edward Wu wrote:
> Add flags value to check the result of ata completion
> 
> Fixes: 255c03d15a29 ("libata: Add tracepoints")
> Link: https://lkml.kernel.org/r/20220616001615.11636-1-edwardwu@realtek.com

What is this Link tag for ? I do not think it is needed.
And please add:

Cc: stable@vger.kernel.org

> Signed-off-by: Edward Wu <edwardwu@realtek.com>
> ---
> v2:
> - Add Fixes tag
> 
>   include/trace/events/libata.h | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/include/trace/events/libata.h b/include/trace/events/libata.h
> index d4e631aa976f..6025dd8ba4aa 100644
> --- a/include/trace/events/libata.h
> +++ b/include/trace/events/libata.h
> @@ -288,6 +288,7 @@ DECLARE_EVENT_CLASS(ata_qc_complete_template,
>   		__entry->hob_feature	= qc->result_tf.hob_feature;
>   		__entry->nsect		= qc->result_tf.nsect;
>   		__entry->hob_nsect	= qc->result_tf.hob_nsect;
> +		__entry->flags		= qc->flags;
>   	),
>   
>   	TP_printk("ata_port=%u ata_dev=%u tag=%d flags=%s status=%s " \


-- 
Damien Le Moal
Western Digital Research