[v1] arch: arm: mach-versatile: Add missing of_node_put()

[PATCH] arch: arm: mach-versatile: Add missing of_node_put()

heliang posted 1 patch 3 years, 10 months ago

Diff against v1
Download mbox

arch/arm/mach-versatile/platsmp-vexpress.c | 2 ++
1 file changed, 2 insertions(+)

Expand all Fold all

[PATCH] arch: arm: mach-versatile: Add missing of_node_put()

Posted by heliang 3 years, 10 months ago

In vexpress_smp_dt_prepare_cpus(), of_find_matching_node() will
return a node pointer with refcount incremented. We should use
of_node_put() when it is not used anymore.

Signed-off-by: heliang <windhl@126.com>
---
 arch/arm/mach-versatile/platsmp-vexpress.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/mach-versatile/platsmp-vexpress.c b/arch/arm/mach-versatile/platsmp-vexpress.c
index 1ee3c45e71c9..459b5870de59 100644
--- a/arch/arm/mach-versatile/platsmp-vexpress.c
+++ b/arch/arm/mach-versatile/platsmp-vexpress.c
@@ -66,6 +66,8 @@ static void __init vexpress_smp_dt_prepare_cpus(unsigned int max_cpus)
 
 	if (scu)
 		scu_enable(of_iomap(scu, 0));
+	
+	of_node_put(scu);
 
 	/*
 	 * Write the address of secondary startup into the
-- 
2.25.1

Re: [PATCH] arch: arm: mach-versatile: Add missing of_node_put()

Posted by Linus Walleij 2 years, 7 months ago

On Wed, Jun 15, 2022 at 11:31 AM heliang <windhl@126.com> wrote:

> In vexpress_smp_dt_prepare_cpus(), of_find_matching_node() will
> return a node pointer with refcount incremented. We should use
> of_node_put() when it is not used anymore.
>
> Signed-off-by: heliang <windhl@126.com>

Patch applied!

Yours,
Linus Walleij