1. Patchew
  2. linux
  3. View series

[PATCH] crypto: testmgr - fix version number of RSA tests

Lei He posted 1 patch 3 years, 10 months ago
There is a newer version of this series
crypto/testmgr.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
[PATCH] crypto: testmgr - fix version number of RSA tests
Posted by Lei He 3 years, 10 months ago 
From: lei he <helei.sig11@bytedance.com>

According to PKCS#1 standard, the 'otherPrimeInfos' field contains
the information for the additional primes r_3, ..., r_u, in order.
It shall be omitted if the version is 0 and shall contain at least
one instance of OtherPrimeInfo if the version is 1, see:
	https://www.rfc-editor.org/rfc/rfc3447#page-44

Replace the version number '1' with 0, otherwise, some drivers may
not pass the run-time tests.

Signed-off-by: lei he <helei.sig11@bytedance.com>
---
 crypto/testmgr.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/crypto/testmgr.h b/crypto/testmgr.h
index 4d7449fc6a65..d57f24b906f1 100644
--- a/crypto/testmgr.h
+++ b/crypto/testmgr.h
@@ -186,7 +186,7 @@ static const struct akcipher_testvec rsa_tv_template[] = {
 #ifndef CONFIG_CRYPTO_FIPS
 	.key =
 	"\x30\x81\x9A" /* sequence of 154 bytes */
-	"\x02\x01\x01" /* version - integer of 1 byte */
+	"\x02\x01\x00" /* version - integer of 1 byte */
 	"\x02\x41" /* modulus - integer of 65 bytes */
 	"\x00\xAA\x36\xAB\xCE\x88\xAC\xFD\xFF\x55\x52\x3C\x7F\xC4\x52\x3F"
 	"\x90\xEF\xA0\x0D\xF3\x77\x4A\x25\x9F\x2E\x62\xB4\xC5\xD9\x9C\xB5"
@@ -216,7 +216,7 @@ static const struct akcipher_testvec rsa_tv_template[] = {
 	}, {
 	.key =
 	"\x30\x82\x01\x1D" /* sequence of 285 bytes */
-	"\x02\x01\x01" /* version - integer of 1 byte */
+	"\x02\x01\x00" /* version - integer of 1 byte */
 	"\x02\x81\x81" /* modulus - integer of 129 bytes */
 	"\x00\xBB\xF8\x2F\x09\x06\x82\xCE\x9C\x23\x38\xAC\x2B\x9D\xA8\x71"
 	"\xF7\x36\x8D\x07\xEE\xD4\x10\x43\xA4\x40\xD6\xB6\xF0\x74\x54\xF5"
@@ -260,7 +260,7 @@ static const struct akcipher_testvec rsa_tv_template[] = {
 #endif
 	.key =
 	"\x30\x82\x02\x20" /* sequence of 544 bytes */
-	"\x02\x01\x01" /* version - integer of 1 byte */
+	"\x02\x01\x00" /* version - integer of 1 byte */
 	"\x02\x82\x01\x01\x00" /* modulus - integer of 256 bytes */
 	"\xDB\x10\x1A\xC2\xA3\xF1\xDC\xFF\x13\x6B\xED\x44\xDF\xF0\x02\x6D"
 	"\x13\xC7\x88\xDA\x70\x6B\x54\xF1\xE8\x27\xDC\xC3\x0F\x99\x6A\xFA"
-- 
2.20.1
PING: [PATCH] crypto: testmgr - fix version number of RSA tests
Posted by 何磊 3 years, 10 months ago 
PING！

> On Jun 15, 2022, at 5:13 PM, Lei He <helei.sig11@bytedance.com> wrote:
> 
> From: lei he <helei.sig11@bytedance.com>
> 
> According to PKCS#1 standard, the 'otherPrimeInfos' field contains
> the information for the additional primes r_3, ..., r_u, in order.
> It shall be omitted if the version is 0 and shall contain at least
> one instance of OtherPrimeInfo if the version is 1, see:
> 	https://www.rfc-editor.org/rfc/rfc3447#page-44
> 
> Replace the version number '1' with 0, otherwise, some drivers may
> not pass the run-time tests.
> 
> Signed-off-by: lei he <helei.sig11@bytedance.com>
> ---
> crypto/testmgr.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/crypto/testmgr.h b/crypto/testmgr.h
> index 4d7449fc6a65..d57f24b906f1 100644
> --- a/crypto/testmgr.h
> +++ b/crypto/testmgr.h
> @@ -186,7 +186,7 @@ static const struct akcipher_testvec rsa_tv_template[] = {
> #ifndef CONFIG_CRYPTO_FIPS
> 	.key =
> 	"\x30\x81\x9A" /* sequence of 154 bytes */
> -	"\x02\x01\x01" /* version - integer of 1 byte */
> +	"\x02\x01\x00" /* version - integer of 1 byte */
> 	"\x02\x41" /* modulus - integer of 65 bytes */
> 	"\x00\xAA\x36\xAB\xCE\x88\xAC\xFD\xFF\x55\x52\x3C\x7F\xC4\x52\x3F"
> 	"\x90\xEF\xA0\x0D\xF3\x77\x4A\x25\x9F\x2E\x62\xB4\xC5\xD9\x9C\xB5"
> @@ -216,7 +216,7 @@ static const struct akcipher_testvec rsa_tv_template[] = {
> 	}, {
> 	.key =
> 	"\x30\x82\x01\x1D" /* sequence of 285 bytes */
> -	"\x02\x01\x01" /* version - integer of 1 byte */
> +	"\x02\x01\x00" /* version - integer of 1 byte */
> 	"\x02\x81\x81" /* modulus - integer of 129 bytes */
> 	"\x00\xBB\xF8\x2F\x09\x06\x82\xCE\x9C\x23\x38\xAC\x2B\x9D\xA8\x71"
> 	"\xF7\x36\x8D\x07\xEE\xD4\x10\x43\xA4\x40\xD6\xB6\xF0\x74\x54\xF5"
> @@ -260,7 +260,7 @@ static const struct akcipher_testvec rsa_tv_template[] = {
> #endif
> 	.key =
> 	"\x30\x82\x02\x20" /* sequence of 544 bytes */
> -	"\x02\x01\x01" /* version - integer of 1 byte */
> +	"\x02\x01\x00" /* version - integer of 1 byte */
> 	"\x02\x82\x01\x01\x00" /* modulus - integer of 256 bytes */
> 	"\xDB\x10\x1A\xC2\xA3\xF1\xDC\xFF\x13\x6B\xED\x44\xDF\xF0\x02\x6D"
> 	"\x13\xC7\x88\xDA\x70\x6B\x54\xF1\xE8\x27\xDC\xC3\x0F\x99\x6A\xFA"
> -- 
> 2.20.1
>
Re: PING: [PATCH] crypto: testmgr - fix version number of RSA tests
Posted by Herbert Xu 3 years, 10 months ago 
On Fri, Jun 24, 2022 at 09:53:02AM +0800, 何磊 wrote:
> PING！

Please resubmit.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Re: [External] PING: [PATCH] crypto: testmgr - fix version number of RSA tests
Posted by 何磊 3 years, 10 months ago 

> On Jun 24, 2022, at 4:54 PM, Herbert Xu <herbert@gondor.apana.org.au> wrote:
> 
> On Fri, Jun 24, 2022 at 09:53:02AM +0800, 何磊 wrote:
>> PING！
> 
> Please resubmit.
> 

Thanks a lot for your reply, a new patch has been sent.
By the way, why this patch needs to be resubmitted. Please let me know if I have made any mistakes.

> Thanks,
> -- 
> Email: Herbert Xu <herbert@gondor.apana.org.au>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Re: [External] PING: [PATCH] crypto: testmgr - fix version number of RSA tests
Posted by Herbert Xu 3 years, 10 months ago 
On Fri, Jun 24, 2022 at 06:29:29PM +0800, 何磊 wrote:
> 
> 
> > On Jun 24, 2022, at 4:54 PM, Herbert Xu <herbert@gondor.apana.org.au> wrote:
> > 
> > On Fri, Jun 24, 2022 at 09:53:02AM +0800, 何磊 wrote:
> >> PING！
> > 
> > Please resubmit.
> > 
> 
> Thanks a lot for your reply, a new patch has been sent.
> By the way, why this patch needs to be resubmitted. Please let me know if I have made any mistakes.

You first sent a subsequent version that superceded the
original patch.  That subsequent patch was then dismissed because
you replied in the thread saying that it needed changes.

Please be more careful in how you send patches and thread them.

Cheers,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Re: [External] PING: [PATCH] crypto: testmgr - fix version number of RSA tests
Posted by Lei He 3 years, 10 months ago 
> On Jun 25, 2022, at 8:32 AM, Herbert Xu <herbert@gondor.apana.org.au> wrote:
> 
> On Fri, Jun 24, 2022 at 06:29:29PM +0800, 何磊 wrote:
>> 
>> 
>>> On Jun 24, 2022, at 4:54 PM, Herbert Xu <herbert@gondor.apana.org.au> wrote:
>>> 
>>> On Fri, Jun 24, 2022 at 09:53:02AM +0800, 何磊 wrote:
>>>> PING！
>>> 
>>> Please resubmit.
>>> 
>> 
>> Thanks a lot for your reply, a new patch has been sent.
>> By the way, why this patch needs to be resubmitted. Please let me know if I have made any mistakes.
> 
> You first sent a subsequent version that superceded the
> original patch.  That subsequent patch was then dismissed because
> you replied in the thread saying that it needed changes.
> 
> Please be more careful in how you send patches and thread them.

Thanks for the explanation, now all patches have been resubmitted. Sorry 
for the extra trouble, I'll be more careful in the future.

> 
> Cheers,
> -- 
> Email: Herbert Xu <herbert@gondor.apana.org.au>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Re: [External] PING: [PATCH] crypto: testmgr - fix version number of RSA tests
Posted by Lei He 3 years, 10 months ago 
> On Jun 27, 2022, at 2:16 PM, Lei He <helei.sig11@bytedance.com> wrote:
> 
>> 
>> On Jun 25, 2022, at 8:32 AM, Herbert Xu <herbert@gondor.apana.org.au> wrote:
>> 
>> On Fri, Jun 24, 2022 at 06:29:29PM +0800, 何磊 wrote:
>>> 
>>> 
>>>> On Jun 24, 2022, at 4:54 PM, Herbert Xu <herbert@gondor.apana.org.au> wrote:
>>>> 
>>>> On Fri, Jun 24, 2022 at 09:53:02AM +0800, 何磊 wrote:
>>>>> PING！
>>>> 
>>>> Please resubmit.
>>>> 
>>> 
>>> Thanks a lot for your reply, a new patch has been sent.
>>> By the way, why this patch needs to be resubmitted. Please let me know if I have made any mistakes.
>> 
>> You first sent a subsequent version that superceded the
>> original patch.  That subsequent patch was then dismissed because
>> you replied in the thread saying that it needed changes.
>> 
>> Please be more careful in how you send patches and thread them.
> 
> Thanks for the explanation, now all patches have been resubmitted. Sorry 
> for the extra trouble, I'll be more careful in the future.

Here are the links to the latest patches:
https://lkml.org/lkml/2022/6/23/150
https://lkml.org/lkml/2022/6/24/357

> 
>> 
>> Cheers,
>> -- 
>> Email: Herbert Xu <herbert@gondor.apana.org.au>
>> Home Page: http://gondor.apana.org.au/~herbert/
>> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Patchew 2.1-devel-ea86937

© 2016 - 2026 Red Hat, Inc.