On Tue, Jun 14, 2022 at 4:27 PM Jean-Jacques Hiblot
<jjhiblot@traphandler.com> wrote:
>
> This series add the support for the TLC5925 LED controller.
adds
> This LED controller is driven though SPI. There is little internal logic
through
> and it can be thought of as a deserializer + latches.
> The TLC5925 itself drives up to 16 LEDs, but multiple TLC5925s can be
> chained to drive more.
>
> The first patch describes the dt bindings.
> The second patch implements most of the driver and supports only
> synchronous brightness setting (brightness_set_blocking).
> The last patch implements the non-blocking version (brightness_set).
Much better, I have a few comments and I believe next version will be final.
> changes v3->v4:
> * add missing MODULE_DEVICE_TABLE(of, ...)
> * use dev_err_probe() to avoid spaming the log in case of deferred probe
spamming
> * use bitmap ops instead of direct mem access + lock
memory
> * sort headers and a few other cosmetic changes.
>
> changes v2->v3:
> * fixed the yaml description of the bindings (now passes dt_binding_check)
> * renamed shit-register-length into ti,shift-register-length and specify its
> type
>
> changes v1->v2:
> * renamed property shift_register_length into shift-register-length
> * add a SPI MODULE_DEVICE_TABLE structure
> * fixed the yaml description of the bindings (now passes dt_binding_check)
>
> Jean-Jacques Hiblot (3):
> dt-bindings: leds: Add bindings for the TLC5925 controller
> leds: Add driver for the TLC5925 LED controller
> leds: tlc5925: Add support for non blocking operations
>
> .../devicetree/bindings/leds/ti,tlc5925.yaml | 107 ++++++++++
> drivers/leds/Kconfig | 6 +
> drivers/leds/Makefile | 1 +
> drivers/leds/leds-tlc5925.c | 191 ++++++++++++++++++
> 4 files changed, 305 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/leds/ti,tlc5925.yaml
> create mode 100644 drivers/leds/leds-tlc5925.c
>
> --
> 2.25.1
>
--
With Best Regards,
Andy Shevchenko