[PATCH v2] x86: kvm: remove NULL check before kfree

Dongliang Mu posted 1 patch 3 years, 10 months ago
arch/x86/kernel/kvm.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
[PATCH v2] x86: kvm: remove NULL check before kfree
Posted by Dongliang Mu 3 years, 10 months ago
From: mudongliang <mudongliangabcd@gmail.com>

kfree can handle NULL pointer as its argument.
According to coccinelle isnullfree check, remove NULL check
before kfree operation.

Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com>
---
v1->v2: modify my signature name
 arch/x86/kernel/kvm.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c
index 1a3658f7e6d9..d4e48b4a438b 100644
--- a/arch/x86/kernel/kvm.c
+++ b/arch/x86/kernel/kvm.c
@@ -236,8 +236,7 @@ void kvm_async_pf_task_wake(u32 token)
 	raw_spin_unlock(&b->lock);
 
 	/* A dummy token might be allocated and ultimately not used.  */
-	if (dummy)
-		kfree(dummy);
+	kfree(dummy);
 }
 EXPORT_SYMBOL_GPL(kvm_async_pf_task_wake);
 
-- 
2.35.1
Re: [PATCH v2] x86: kvm: remove NULL check before kfree
Posted by Paolo Bonzini 3 years, 10 months ago
Queued, thanks.

Paolo