cpufreq: amd_pstate: fix the highest perf query for new AMD processors

[PATCH] cpufreq: amd_pstate: fix the highest perf query for new AMD processors

Posted by Perry Yuan 3 years, 10 months ago

In order to get the corrent highest perf for some new AMD processors,
the amd_get_highest_perf() call will check the CPU model and
return correct highest perf value.

Signed-off-by: Perry Yuan <Perry.Yuan@amd.com>
---
 arch/x86/kernel/cpu/amd.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/x86/kernel/cpu/amd.c b/arch/x86/kernel/cpu/amd.c
index 0c0b09796ced..ff2075f26ef4 100644
--- a/arch/x86/kernel/cpu/amd.c
+++ b/arch/x86/kernel/cpu/amd.c
@@ -1152,7 +1152,8 @@ u32 amd_get_highest_perf(void)
 	struct cpuinfo_x86 *c = &boot_cpu_data;
 
 	if (c->x86 == 0x17 && ((c->x86_model >= 0x30 && c->x86_model < 0x40) ||
-			       (c->x86_model >= 0x70 && c->x86_model < 0x80)))
+			       (c->x86_model >= 0x70 && c->x86_model < 0x80) ||
+			       (c->x86_model >= 0xa0 && c->x86_model < 0xb0)))
 		return 166;
 
 	if (c->x86 == 0x19 && ((c->x86_model >= 0x20 && c->x86_model < 0x30) ||
-- 
2.25.1

Re: [PATCH] cpufreq: amd_pstate: fix the highest perf query for new AMD processors

Posted by Huang Rui 3 years, 10 months ago

On Tue, Jun 14, 2022 at 11:52:28AM +0800, Yuan, Perry wrote:
> In order to get the corrent highest perf for some new AMD processors,
> the amd_get_highest_perf() call will check the CPU model and
> return correct highest perf value.
> 

You needs to change the prefix of the subject, because it's not the
amd-pstate driver.

x86/amd: Fix the highest perf query for new AMD processors

Thanks,
Ray

> Signed-off-by: Perry Yuan <Perry.Yuan@amd.com>
> ---
>  arch/x86/kernel/cpu/amd.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kernel/cpu/amd.c b/arch/x86/kernel/cpu/amd.c
> index 0c0b09796ced..ff2075f26ef4 100644
> --- a/arch/x86/kernel/cpu/amd.c
> +++ b/arch/x86/kernel/cpu/amd.c
> @@ -1152,7 +1152,8 @@ u32 amd_get_highest_perf(void)
>  	struct cpuinfo_x86 *c = &boot_cpu_data;
>  
>  	if (c->x86 == 0x17 && ((c->x86_model >= 0x30 && c->x86_model < 0x40) ||
> -			       (c->x86_model >= 0x70 && c->x86_model < 0x80)))
> +			       (c->x86_model >= 0x70 && c->x86_model < 0x80) ||
> +			       (c->x86_model >= 0xa0 && c->x86_model < 0xb0)))
>  		return 166;
>  
>  	if (c->x86 == 0x19 && ((c->x86_model >= 0x20 && c->x86_model < 0x30) ||
> -- 
> 2.25.1
>

RE: [PATCH] cpufreq: amd_pstate: fix the highest perf query for new AMD processors

Posted by Yuan, Perry 3 years, 10 months ago

[AMD Official Use Only - General]

Hi Ray.

> -----Original Message-----
> From: Huang, Ray <Ray.Huang@amd.com>
> Sent: Tuesday, June 14, 2022 4:42 PM
> To: Yuan, Perry <Perry.Yuan@amd.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>; Ingo Molnar <mingo@redhat.com>;
> Borislav Petkov <bp@alien8.de>; Dave Hansen <dave.hansen@linux.intel.com>;
> x86@kernel.org; H. Peter Anvin <hpa@zytor.com>; Lendacky, Thomas
> <Thomas.Lendacky@amd.com>; Limonciello, Mario
> <Mario.Limonciello@amd.com>; Jane Malalane <jane.malalane@citrix.com>;
> Phillips, Kim <kim.phillips@amd.com>; Tony Luck <tony.luck@intel.com>; linux-
> kernel@vger.kernel.org; Su, Jinzhou (Joe) <Jinzhou.Su@amd.com>; Meng, Li
> (Jassmine) <Li.Meng@amd.com>; linux-pm@vger.kernel.org
> Subject: Re: [PATCH] cpufreq: amd_pstate: fix the highest perf query for new
> AMD processors
> 
> On Tue, Jun 14, 2022 at 11:52:28AM +0800, Yuan, Perry wrote:
> > In order to get the corrent highest perf for some new AMD processors,
> > the amd_get_highest_perf() call will check the CPU model and return
> > correct highest perf value.
> >
> 
> You needs to change the prefix of the subject, because it's not the amd-pstate
> driver.
> 
> x86/amd: Fix the highest perf query for new AMD processors
> 
> Thanks,
> Ray

Thanks for reminding me that.
Will update the title as below. Sending V2.

x86/cpu/amd: fix the highest perf query for new AMD processors

Perry.

> 
> > Signed-off-by: Perry Yuan <Perry.Yuan@amd.com>
> > ---
> >  arch/x86/kernel/cpu/amd.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/x86/kernel/cpu/amd.c b/arch/x86/kernel/cpu/amd.c
> > index 0c0b09796ced..ff2075f26ef4 100644
> > --- a/arch/x86/kernel/cpu/amd.c
> > +++ b/arch/x86/kernel/cpu/amd.c
> > @@ -1152,7 +1152,8 @@ u32 amd_get_highest_perf(void)
> >  	struct cpuinfo_x86 *c = &boot_cpu_data;
> >
> >  	if (c->x86 == 0x17 && ((c->x86_model >= 0x30 && c->x86_model < 0x40)
> ||
> > -			       (c->x86_model >= 0x70 && c->x86_model < 0x80)))
> > +			       (c->x86_model >= 0x70 && c->x86_model < 0x80)
> ||
> > +			       (c->x86_model >= 0xa0 && c->x86_model < 0xb0)))
> >  		return 166;
> >
> >  	if (c->x86 == 0x19 && ((c->x86_model >= 0x20 && c->x86_model < 0x30)
> > ||
> > --
> > 2.25.1
> >

Re: [PATCH] cpufreq: amd_pstate: fix the highest perf query for new AMD processors

Posted by Mario Limonciello 3 years, 10 months ago

On 6/13/22 22:52, Perry Yuan wrote:
> In order to get the corrent highest perf for some new AMD processors,
> the amd_get_highest_perf() call will check the CPU model and
> return correct highest perf value.
> 
> Signed-off-by: Perry Yuan <Perry.Yuan@amd.com>

Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>

> ---
>   arch/x86/kernel/cpu/amd.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kernel/cpu/amd.c b/arch/x86/kernel/cpu/amd.c
> index 0c0b09796ced..ff2075f26ef4 100644
> --- a/arch/x86/kernel/cpu/amd.c
> +++ b/arch/x86/kernel/cpu/amd.c
> @@ -1152,7 +1152,8 @@ u32 amd_get_highest_perf(void)
>   	struct cpuinfo_x86 *c = &boot_cpu_data;
>   
>   	if (c->x86 == 0x17 && ((c->x86_model >= 0x30 && c->x86_model < 0x40) ||
> -			       (c->x86_model >= 0x70 && c->x86_model < 0x80)))
> +			       (c->x86_model >= 0x70 && c->x86_model < 0x80) ||
> +			       (c->x86_model >= 0xa0 && c->x86_model < 0xb0)))
>   		return 166;
>   
>   	if (c->x86 == 0x19 && ((c->x86_model >= 0x20 && c->x86_model < 0x30) ||