[v2] dt-bindings: input: gpio-keys: rework matching children

[PATCH v2 03/48] dt-bindings: input: gpio-keys: accept also interrupt-extended

Posted by Krzysztof Kozlowski 2 years, 3 months ago

Each key device node might have interrupts-extended instead of
interrupts property:

  fsl-ls1028a-kontron-sl28-var1.dtb: buttons0: power-button: 'anyOf' conditional failed, one must be fixed:
    'interrupts' is a required property
    'gpios' is a required property

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 Documentation/devicetree/bindings/input/gpio-keys.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/input/gpio-keys.yaml b/Documentation/devicetree/bindings/input/gpio-keys.yaml
index e722e681d237..17ac9dff7972 100644
--- a/Documentation/devicetree/bindings/input/gpio-keys.yaml
+++ b/Documentation/devicetree/bindings/input/gpio-keys.yaml
@@ -92,6 +92,8 @@ patternProperties:
     anyOf:
       - required:
           - interrupts
+      - required:
+          - interrupts-extended
       - required:
           - gpios
 
-- 
2.34.1

Re: [PATCH v2 03/48] dt-bindings: input: gpio-keys: accept also interrupt-extended

Posted by Rob Herring 2 years, 3 months ago

On Thu, 09 Jun 2022 13:39:05 +0200, Krzysztof Kozlowski wrote:
> Each key device node might have interrupts-extended instead of
> interrupts property:
> 
>   fsl-ls1028a-kontron-sl28-var1.dtb: buttons0: power-button: 'anyOf' conditional failed, one must be fixed:
>     'interrupts' is a required property
>     'gpios' is a required property
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  Documentation/devicetree/bindings/input/gpio-keys.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 

The tooling is supposed to take care of this, but it's complicated 
enough that we don't find it. So easier to handle in the schema.

Reviewed-by: Rob Herring <robh@kernel.org>