From: Bjorn Helgaas <bhelgaas@google.com>

PCI-specific power management (pci_driver.suspend and pci_driver.resume) is
deprecated.  If drivers implement power management, they should use the
generic power management framework, not the PCI-specific hooks.

No fbdev drivers actually implement PCI power management, but there are a
cirrusfb has some commented-out references to it and skeletonfb has
examples of it.  Remove these.

Bjorn Helgaas (2):
  video: fbdev: cirrusfb: Remove useless reference to PCI power
    management
  video: fbdev: skeletonfb: Convert to generic power management

 drivers/video/fbdev/cirrusfb.c   |  6 ------
 drivers/video/fbdev/skeletonfb.c | 13 +++++++------
 2 files changed, 7 insertions(+), 12 deletions(-)

-- 
2.25.1

On Tue, Jun 07, 2022 at 06:11:10PM -0500, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
> 
> PCI-specific power management (pci_driver.suspend and pci_driver.resume) is
> deprecated.  If drivers implement power management, they should use the
> generic power management framework, not the PCI-specific hooks.
> 
> No fbdev drivers actually implement PCI power management, but there are a
> cirrusfb has some commented-out references to it and skeletonfb has
> examples of it.  Remove these.

Is this holding up some cleanup on your side and so would be easier to
merge these through the pci tree? If so

Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>

for merging through your tree. Otherwise I guess Helge will get around to
pile them up for 5.20 (or 6.0) eventually.

Cheers, Daniel
> 
> Bjorn Helgaas (2):
>   video: fbdev: cirrusfb: Remove useless reference to PCI power
>     management
>   video: fbdev: skeletonfb: Convert to generic power management
> 
>  drivers/video/fbdev/cirrusfb.c   |  6 ------
>  drivers/video/fbdev/skeletonfb.c | 13 +++++++------
>  2 files changed, 7 insertions(+), 12 deletions(-)
> 
> -- 
> 2.25.1
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

On Wed, Jun 08, 2022 at 06:26:34PM +0200, Daniel Vetter wrote:
> On Tue, Jun 07, 2022 at 06:11:10PM -0500, Bjorn Helgaas wrote:
> > From: Bjorn Helgaas <bhelgaas@google.com>
> > 
> > PCI-specific power management (pci_driver.suspend and pci_driver.resume) is
> > deprecated.  If drivers implement power management, they should use the
> > generic power management framework, not the PCI-specific hooks.
> > 
> > No fbdev drivers actually implement PCI power management, but there are a
> > cirrusfb has some commented-out references to it and skeletonfb has
> > examples of it.  Remove these.
> 
> Is this holding up some cleanup on your side and so would be easier to
> merge these through the pci tree? If so
> 
> Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> 
> for merging through your tree. Otherwise I guess Helge will get around to
> pile them up for 5.20 (or 6.0) eventually.

No particular rush and nothing depending on these.

I added your ack to my local branch and if nothing happens for a
while, I'll merge them via my tree.

Bjorn

On 6/8/22 20:09, Bjorn Helgaas wrote:
> On Wed, Jun 08, 2022 at 06:26:34PM +0200, Daniel Vetter wrote:
>> On Tue, Jun 07, 2022 at 06:11:10PM -0500, Bjorn Helgaas wrote:
>>> From: Bjorn Helgaas <bhelgaas@google.com>
>>>
>>> PCI-specific power management (pci_driver.suspend and pci_driver.resume) is
>>> deprecated.  If drivers implement power management, they should use the
>>> generic power management framework, not the PCI-specific hooks.
>>>
>>> No fbdev drivers actually implement PCI power management, but there are a
>>> cirrusfb has some commented-out references to it and skeletonfb has
>>> examples of it.  Remove these.
>>
>> Is this holding up some cleanup on your side and so would be easier to
>> merge these through the pci tree? If so
>>
>> Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>>
>> for merging through your tree. Otherwise I guess Helge will get around to
>> pile them up for 5.20 (or 6.0) eventually.
>
> No particular rush and nothing depending on these.
>
> I added your ack to my local branch and if nothing happens for a
> while, I'll merge them via my tree.

I've been on vacation, but picked them up now.

Thanks!

Helge