[v1] net: ethernet: bgmac: Fix refcount leak in bcma_mdio_mii_register

[PATCH] net: ethernet: bgmac: Fix refcount leak in bcma_mdio_mii_register

Miaoqian Lin posted 1 patch 3 years, 10 months ago

Diff against v2
Download mbox

There is a newer version of this series

drivers/net/ethernet/broadcom/bgmac-bcma-mdio.c | 1 +
1 file changed, 1 insertion(+)

Expand all Fold all

[PATCH] net: ethernet: bgmac: Fix refcount leak in bcma_mdio_mii_register

Posted by Miaoqian Lin 3 years, 10 months ago

of_get_child_by_name() returns a node pointer with refcount
incremented, we should use of_node_put() on it when not need anymore.
Add missing of_node_put() to avoid refcount leak.

Fixes: format:55954f3bfdac ("net: ethernet: bgmac: move BCMA MDIO Phy
code into a separate file")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
 drivers/net/ethernet/broadcom/bgmac-bcma-mdio.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/broadcom/bgmac-bcma-mdio.c b/drivers/net/ethernet/broadcom/bgmac-bcma-mdio.c
index 086739e4f40a..9b83d5361699 100644
--- a/drivers/net/ethernet/broadcom/bgmac-bcma-mdio.c
+++ b/drivers/net/ethernet/broadcom/bgmac-bcma-mdio.c
@@ -234,6 +234,7 @@ struct mii_bus *bcma_mdio_mii_register(struct bgmac *bgmac)
 	np = of_get_child_by_name(core->dev.of_node, "mdio");
 
 	err = of_mdiobus_register(mii_bus, np);
+	of_node_put(np);
 	if (err) {
 		dev_err(&core->dev, "Registration of mii bus failed\n");
 		goto err_free_bus;
-- 
2.25.1