[v1] PCI: brcmstb: Fix refcount leak in brcm_pcie_probe

[PATCH] PCI: brcmstb: Fix refcount leak in brcm_pcie_probe

Miaoqian Lin posted 1 patch 3 years, 11 months ago

Diff against v2
Download mbox

There is a newer version of this series

drivers/pci/controller/pcie-brcmstb.c | 2 ++
1 file changed, 2 insertions(+)

Expand all Fold all

[PATCH] PCI: brcmstb: Fix refcount leak in brcm_pcie_probe

Posted by Miaoqian Lin 3 years, 11 months ago

of_parse_phandle() returns a node pointer with refcount
incremented, we should use of_node_put() on it when not need anymore.
Add missing of_node_put() to avoid refcount leak.

Fixes: format:40ca1bf580ef ("PCI: brcmstb: Add MSI support")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
 drivers/pci/controller/pcie-brcmstb.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/pci/controller/pcie-brcmstb.c b/drivers/pci/controller/pcie-brcmstb.c
index 375c0c40bbf8..e3b673441a11 100644
--- a/drivers/pci/controller/pcie-brcmstb.c
+++ b/drivers/pci/controller/pcie-brcmstb.c
@@ -1597,8 +1597,10 @@ static int brcm_pcie_probe(struct platform_device *pdev)
 		ret = brcm_pcie_enable_msi(pcie);
 		if (ret) {
 			dev_err(pcie->dev, "probe of internal MSI failed");
+			of_node_put(msi_np);
 			goto fail;
 		}
+		of_node_put(msi_np);
 	}
 
 	bridge->ops = pcie->type == BCM7425 ? &brcm_pcie_ops32 : &brcm_pcie_ops;
-- 
2.25.1