[PATCH] clk: qcom: clk-rpmh: Remove redundant if statement

Li Zhengyu posted 1 patch 3 years, 11 months ago
There is a newer version of this series
drivers/clk/qcom/clk-rpmh.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
[PATCH] clk: qcom: clk-rpmh: Remove redundant if statement
Posted by Li Zhengyu 3 years, 11 months ago
(!ret) has been checked, so remove (ret).

Signed-off-by: Li Zhengyu <lizhengyu3@huawei.com>
---
 drivers/clk/qcom/clk-rpmh.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/clk/qcom/clk-rpmh.c b/drivers/clk/qcom/clk-rpmh.c
index aed907982344..6d207f7e943d 100644
--- a/drivers/clk/qcom/clk-rpmh.c
+++ b/drivers/clk/qcom/clk-rpmh.c
@@ -207,10 +207,7 @@ static int clk_rpmh_aggregate_state_send_command(struct clk_rpmh *c,
 	if (!ret)
 		return 0;
 
-	if (ret && enable)
-		c->state = 0;
-	else if (ret)
-		c->state = c->valid_state_mask;
+	c->state = enable ? 0 : c->valid_state_mask;
 
 	WARN(1, "clk: %s failed to %s\n", c->res_name,
 	     enable ? "enable" : "disable");
-- 
2.17.1
Re: [PATCH] clk: qcom: clk-rpmh: Remove redundant if statement
Posted by Stephen Boyd 3 years, 10 months ago
Quoting Li Zhengyu (2022-05-31 01:56:11)
> (!ret) has been checked, so remove (ret).
> 
> Signed-off-by: Li Zhengyu <lizhengyu3@huawei.com>
> ---

Reviewed-by: Stephen Boyd <sboyd@kernel.org>