dt-bindings: watchdog: faraday: Fix typo in example 'timeout-sec' property

[PATCH] dt-bindings: watchdog: faraday: Fix typo in example 'timeout-sec' property

Posted by Rob Herring 3 years, 11 months ago

The 'unevaluatedProperties' schema checks is not fully working and doesn't
catch some cases where there's a $ref to another schema. A fix is pending,
but results in new warnings in examples.

The correct common watchdog property is 'timeout-sec', not 'timeout-secs'.

Signed-off-by: Rob Herring <robh@kernel.org>
---
 .../devicetree/bindings/watchdog/faraday,ftwdt010.yaml          | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/watchdog/faraday,ftwdt010.yaml b/Documentation/devicetree/bindings/watchdog/faraday,ftwdt010.yaml
index ca9e1beff76b..6ecd429f76b5 100644
--- a/Documentation/devicetree/bindings/watchdog/faraday,ftwdt010.yaml
+++ b/Documentation/devicetree/bindings/watchdog/faraday,ftwdt010.yaml
@@ -55,7 +55,7 @@ examples:
       compatible = "faraday,ftwdt010";
       reg = <0x41000000 0x1000>;
       interrupts = <3 IRQ_TYPE_LEVEL_HIGH>;
-      timeout-secs = <5>;
+      timeout-sec = <5>;
     };
   - |
     watchdog: watchdog@98500000 {
-- 
2.34.1

Re: [PATCH] dt-bindings: watchdog: faraday: Fix typo in example 'timeout-sec' property

Posted by Linus Walleij 3 years, 10 months ago

On Thu, May 26, 2022 at 3:41 AM Rob Herring <robh@kernel.org> wrote:

> The 'unevaluatedProperties' schema checks is not fully working and doesn't
> catch some cases where there's a $ref to another schema. A fix is pending,
> but results in new warnings in examples.
>
> The correct common watchdog property is 'timeout-sec', not 'timeout-secs'.
>
> Signed-off-by: Rob Herring <robh@kernel.org>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

This kind of stuff is exactly what we wanted schema to find and fix.
And now it is delivering. Success!

Yours,
Linus Walleij

Re: [PATCH] dt-bindings: watchdog: faraday: Fix typo in example 'timeout-sec' property

Posted by Guenter Roeck 3 years, 11 months ago

On 5/25/22 18:41, Rob Herring wrote:
> The 'unevaluatedProperties' schema checks is not fully working and doesn't
> catch some cases where there's a $ref to another schema. A fix is pending,
> but results in new warnings in examples.
> 
> The correct common watchdog property is 'timeout-sec', not 'timeout-secs'.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>

Good find.

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>   .../devicetree/bindings/watchdog/faraday,ftwdt010.yaml          | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/watchdog/faraday,ftwdt010.yaml b/Documentation/devicetree/bindings/watchdog/faraday,ftwdt010.yaml
> index ca9e1beff76b..6ecd429f76b5 100644
> --- a/Documentation/devicetree/bindings/watchdog/faraday,ftwdt010.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/faraday,ftwdt010.yaml
> @@ -55,7 +55,7 @@ examples:
>         compatible = "faraday,ftwdt010";
>         reg = <0x41000000 0x1000>;
>         interrupts = <3 IRQ_TYPE_LEVEL_HIGH>;
> -      timeout-secs = <5>;
> +      timeout-sec = <5>;
>       };
>     - |
>       watchdog: watchdog@98500000 {