dt-bindings: usb: snps,dwc3: Add missing 'dma-coherent' property

[PATCH] dt-bindings: usb: snps,dwc3: Add missing 'dma-coherent' property

Posted by Rob Herring 3 years, 11 months ago

The 'unevaluatedProperties' schema checks is not fully working and doesn't
catch some cases where there's a $ref to another schema. A fix is pending,
but results in new warnings in examples.

Some DWC3 implementations such as Xilinx are hooked up coherently and need
to set the 'dma-coherent' property.

Signed-off-by: Rob Herring <robh@kernel.org>
---
 Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
index f4471f8bdbef..d41265ba8ce2 100644
--- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
+++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
@@ -68,6 +68,8 @@ properties:
         - enum: [bus_early, ref, suspend]
         - true
 
+  dma-coherent: true
+
   iommus:
     maxItems: 1
 
-- 
2.34.1

Re: [PATCH] dt-bindings: usb: snps,dwc3: Add missing 'dma-coherent' property

Posted by Rob Herring 3 years, 11 months ago

On Wed, May 25, 2022 at 08:41:18PM -0500, Rob Herring wrote:
> The 'unevaluatedProperties' schema checks is not fully working and doesn't
> catch some cases where there's a $ref to another schema. A fix is pending,
> but results in new warnings in examples.
> 
> Some DWC3 implementations such as Xilinx are hooked up coherently and need
> to set the 'dma-coherent' property.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
>  Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 2 ++
>  1 file changed, 2 insertions(+)

Applied, thanks.