arch/arm64/boot/dts/renesas/r8a779f0.dtsi | 56 +++++++++++++++++++++++ 1 file changed, 56 insertions(+)
From: Linh Phung <linh.phung.jy@renesas.com>
Add support for 3 TSC nodes of thermal. The 4th node is for the control
domain and not for Linux.
Signed-off-by: Linh Phung <linh.phung.jy@renesas.com>
[wsa: rebased, fixed resource size, removed unused 4th node breaking probe]
Signed-off-by: Wolfram Sang <wsa@kernel.org>
---
Works fine on my Spider board and allowed me to disconnect the fan :)
arch/arm64/boot/dts/renesas/r8a779f0.dtsi | 56 +++++++++++++++++++++++
1 file changed, 56 insertions(+)
diff --git a/arch/arm64/boot/dts/renesas/r8a779f0.dtsi b/arch/arm64/boot/dts/renesas/r8a779f0.dtsi
index df46fb87cffc..d89064f86d85 100644
--- a/arch/arm64/boot/dts/renesas/r8a779f0.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a779f0.dtsi
@@ -157,6 +157,18 @@ sysc: system-controller@e6180000 {
#power-domain-cells = <1>;
};
+ tsc: thermal@e6198000 {
+ compatible = "renesas,r8a779f0-thermal";
+ /* The 4th sensor is in control domain and not for Linux */
+ reg = <0 0xe6198000 0 0x200>,
+ <0 0xe61a0000 0 0x200>,
+ <0 0xe61a8000 0 0x200>;
+ clocks = <&cpg CPG_MOD 919>;
+ power-domains = <&sysc R8A779F0_PD_ALWAYS_ON>;
+ resets = <&cpg 919>;
+ #thermal-sensor-cells = <1>;
+ };
+
i2c0: i2c@e6500000 {
compatible = "renesas,i2c-r8a779f0",
"renesas,rcar-gen4-i2c";
@@ -360,6 +372,50 @@ prr: chipid@fff00044 {
};
};
+ thermal-zones {
+ sensor_thermal1: sensor-thermal1 {
+ polling-delay-passive = <250>;
+ polling-delay = <1000>;
+ thermal-sensors = <&tsc 0>;
+
+ trips {
+ sensor1_crit: sensor1-crit {
+ temperature = <120000>;
+ hysteresis = <1000>;
+ type = "critical";
+ };
+ };
+ };
+
+ sensor_thermal2: sensor-thermal2 {
+ polling-delay-passive = <250>;
+ polling-delay = <1000>;
+ thermal-sensors = <&tsc 1>;
+
+ trips {
+ sensor2_crit: sensor2-crit {
+ temperature = <120000>;
+ hysteresis = <1000>;
+ type = "critical";
+ };
+ };
+ };
+
+ sensor_thermal3: sensor-thermal3 {
+ polling-delay-passive = <250>;
+ polling-delay = <1000>;
+ thermal-sensors = <&tsc 2>;
+
+ trips {
+ sensor3_crit: sensor3-crit {
+ temperature = <120000>;
+ hysteresis = <1000>;
+ type = "critical";
+ };
+ };
+ };
+ };
+
timer {
compatible = "arm,armv8-timer";
interrupts-extended = <&gic GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(1) | IRQ_TYPE_LEVEL_LOW)>,
--
2.35.1On Wed, May 25, 2022 at 05:13:55PM +0200, Wolfram Sang wrote: > From: Linh Phung <linh.phung.jy@renesas.com> > > Add support for 3 TSC nodes of thermal. The 4th node is for the control > domain and not for Linux. > > Signed-off-by: Linh Phung <linh.phung.jy@renesas.com> > [wsa: rebased, fixed resource size, removed unused 4th node breaking probe] > Signed-off-by: Wolfram Sang <wsa@kernel.org> Eeks, this should have been: Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Shall I resend?
Hi Wolfram,
On Sun, Jun 12, 2022 at 9:48 PM Wolfram Sang <wsa@kernel.org> wrote:
> On Wed, May 25, 2022 at 05:13:55PM +0200, Wolfram Sang wrote:
> > From: Linh Phung <linh.phung.jy@renesas.com>
> >
> > Add support for 3 TSC nodes of thermal. The 4th node is for the control
> > domain and not for Linux.
> >
> > Signed-off-by: Linh Phung <linh.phung.jy@renesas.com>
> > [wsa: rebased, fixed resource size, removed unused 4th node breaking probe]
> > Signed-off-by: Wolfram Sang <wsa@kernel.org>
>
> Eeks, this should have been:
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
>
> Shall I resend?
No need to resend, I can fix that while applying.
Unless you want to make other changes, which I believe is not the case,
as only the DT bindings patch needed a new version?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
> No need to resend, I can fix that while applying. Thanks! > Unless you want to make other changes, which I believe is not the case, > as only the DT bindings patch needed a new version? Nope, no changes needed.
Hi Wolfram,
On Mon, Jun 13, 2022 at 11:25 AM Wolfram Sang <wsa@kernel.org> wrote:
> > No need to resend, I can fix that while applying.
>
> Thanks!
>
> > Unless you want to make other changes, which I believe is not the case,
> > as only the DT bindings patch needed a new version?
>
> Nope, no changes needed.
Actually other changes are needed, as "make dtbs_check" complains,
rightfully:
arm64/boot/dts/renesas/r8a779f0-spider.dtb: thermal-zones:
'sensor-thermal1', 'sensor-thermal2', 'sensor-thermal3' do not match
any of the regexes: '^[a-zA-Z][a-zA-Z0-9\\-]{1,12}-thermal$',
'pinctrl-[0-9]+'
From schema:
Documentation/devicetree/bindings/thermal/thermal-zones.yaml
As I have already queued this patch, I will amend the commit, by
changing the node names to sensor[123]-thermal.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
On Wed, May 25, 2022 at 5:14 PM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> From: Linh Phung <linh.phung.jy@renesas.com>
>
> Add support for 3 TSC nodes of thermal. The 4th node is for the control
> domain and not for Linux.
>
> Signed-off-by: Linh Phung <linh.phung.jy@renesas.com>
> [wsa: rebased, fixed resource size, removed unused 4th node breaking probe]
> Signed-off-by: Wolfram Sang <wsa@kernel.org>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
© 2016 - 2026 Red Hat, Inc.