s390/uv_uapi: depend on CONFIG_S390

[PATCH] s390/uv_uapi: depend on CONFIG_S390

Posted by Paolo Bonzini 1 year, 11 months ago

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 drivers/s390/char/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/s390/char/Kconfig b/drivers/s390/char/Kconfig
index ef8f41833c1a..108e8eb06249 100644
--- a/drivers/s390/char/Kconfig
+++ b/drivers/s390/char/Kconfig
@@ -103,6 +103,7 @@ config SCLP_OFB
 config S390_UV_UAPI
 	def_tristate m
 	prompt "Ultravisor userspace API"
+        depends on S390
 	help
 	  Selecting exposes parts of the UV interface to userspace
 	  by providing a misc character device at /dev/uv.
-- 
2.31.1

Re: [PATCH] s390/uv_uapi: depend on CONFIG_S390

Posted by Christian Borntraeger 1 year, 11 months ago

Am 23.05.22 um 21:24 schrieb Paolo Bonzini:
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>   drivers/s390/char/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/s390/char/Kconfig b/drivers/s390/char/Kconfig
> index ef8f41833c1a..108e8eb06249 100644
> --- a/drivers/s390/char/Kconfig
> +++ b/drivers/s390/char/Kconfig
> @@ -103,6 +103,7 @@ config SCLP_OFB
>   config S390_UV_UAPI
>   	def_tristate m
>   	prompt "Ultravisor userspace API"
> +        depends on S390
>   	help
>   	  Selecting exposes parts of the UV interface to userspace
>   	  by providing a misc character device at /dev/uv.

Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>

with the whitespace as outlined.

Can you pick it yourself?

Re: [PATCH] s390/uv_uapi: depend on CONFIG_S390

Posted by Paolo Bonzini 1 year, 11 months ago

On 5/24/22 09:01, Christian Borntraeger wrote:
> Am 23.05.22 um 21:24 schrieb Paolo Bonzini:
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>> ---
>>   drivers/s390/char/Kconfig | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/s390/char/Kconfig b/drivers/s390/char/Kconfig
>> index ef8f41833c1a..108e8eb06249 100644
>> --- a/drivers/s390/char/Kconfig
>> +++ b/drivers/s390/char/Kconfig
>> @@ -103,6 +103,7 @@ config SCLP_OFB
>>   config S390_UV_UAPI
>>       def_tristate m
>>       prompt "Ultravisor userspace API"
>> +        depends on S390
>>       help
>>         Selecting exposes parts of the UV interface to userspace
>>         by providing a misc character device at /dev/uv.
> 
> Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>
> 
> with the whitespace as outlined.

Yes, that needs to be a tab.

> Can you pick it yourself?

Sure, thanks.

Paolo

Re: [PATCH] s390/uv_uapi: depend on CONFIG_S390

Posted by Randy Dunlap 1 year, 11 months ago


On 5/23/22 12:24, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  drivers/s390/char/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/s390/char/Kconfig b/drivers/s390/char/Kconfig
> index ef8f41833c1a..108e8eb06249 100644
> --- a/drivers/s390/char/Kconfig
> +++ b/drivers/s390/char/Kconfig
> @@ -103,6 +103,7 @@ config SCLP_OFB
>  config S390_UV_UAPI
>  	def_tristate m
>  	prompt "Ultravisor userspace API"
> +        depends on S390

Please use a tab for indentation instead of spaces.

>  	help
>  	  Selecting exposes parts of the UV interface to userspace
>  	  by providing a misc character device at /dev/uv.

-- 
~Randy