soc: integrator: Fix refcount leak in integrator_soc_init

[PATCH] soc: integrator: Fix refcount leak in integrator_soc_init

Posted by Miaoqian Lin 1 year, 11 months ago

of_find_matching_node() returns a node pointer with refcount
incremented, we should use of_node_put() on it when not need anymore.
Add missing of_node_put() to avoid refcount leak.

Fixes: f956a785a282 ("soc: move SoC driver for the ARM Integrator")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
 drivers/soc/versatile/soc-integrator.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/soc/versatile/soc-integrator.c b/drivers/soc/versatile/soc-integrator.c
index bab4ad87aa75..d5099a3386b4 100644
--- a/drivers/soc/versatile/soc-integrator.c
+++ b/drivers/soc/versatile/soc-integrator.c
@@ -113,6 +113,7 @@ static int __init integrator_soc_init(void)
 		return -ENODEV;
 
 	syscon_regmap = syscon_node_to_regmap(np);
+	of_node_put(np);
 	if (IS_ERR(syscon_regmap))
 		return PTR_ERR(syscon_regmap);
 
-- 
2.25.1

Re: [PATCH] soc: integrator: Fix refcount leak in integrator_soc_init

Posted by Linus Walleij 1 year, 10 months ago

On Mon, May 23, 2022 at 4:16 PM Miaoqian Lin <linmq006@gmail.com> wrote:

> of_find_matching_node() returns a node pointer with refcount
> incremented, we should use of_node_put() on it when not need anymore.
> Add missing of_node_put() to avoid refcount leak.
>
> Fixes: f956a785a282 ("soc: move SoC driver for the ARM Integrator")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>

Patch applied!

Yours,
Linus Walleij