[PATCH v2] staging: greybus: Fix indentation in fw-management.c

Uri Arev posted 1 patch 1 year, 11 months ago
There is a newer version of this series
drivers/staging/greybus/fw-management.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
[PATCH v2] staging: greybus: Fix indentation in fw-management.c
Posted by Uri Arev 1 year, 11 months ago
Reported by Checkpatch:
CHECK: Alignment should match open parenthesis

-Uri

Signed-off-by: Uri Arev <me@wantyapps.xyz>
---
v2: More understandable title, add Signed-off-by line

 drivers/staging/greybus/fw-management.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/greybus/fw-management.c b/drivers/staging/greybus/fw-management.c
index 687c6405c65b..3342b84597da 100644
--- a/drivers/staging/greybus/fw-management.c
+++ b/drivers/staging/greybus/fw-management.c
@@ -102,7 +102,7 @@ static struct fw_mgmt *get_fw_mgmt(struct cdev *cdev)
 }
 
 static int fw_mgmt_interface_fw_version_operation(struct fw_mgmt *fw_mgmt,
-		struct fw_mgmt_ioc_get_intf_version *fw_info)
+						  struct fw_mgmt_ioc_get_intf_version *fw_info)
 {
 	struct gb_connection *connection = fw_mgmt->connection;
 	struct gb_fw_mgmt_interface_fw_version_response response;
@@ -240,7 +240,7 @@ static int fw_mgmt_interface_fw_loaded_operation(struct gb_operation *op)
 }
 
 static int fw_mgmt_backend_fw_version_operation(struct fw_mgmt *fw_mgmt,
-		struct fw_mgmt_ioc_get_backend_version *fw_info)
+						struct fw_mgmt_ioc_get_backend_version *fw_info)
 {
 	struct gb_connection *connection = fw_mgmt->connection;
 	struct gb_fw_mgmt_backend_fw_version_request request;
@@ -473,7 +473,7 @@ static int fw_mgmt_ioctl(struct fw_mgmt *fw_mgmt, unsigned int cmd,
 			return -EFAULT;
 
 		ret = fw_mgmt_backend_fw_update_operation(fw_mgmt,
-				backend_update.firmware_tag);
+							  backend_update.firmware_tag);
 		if (ret)
 			return ret;
 
-- 
2.36.1
Re: [PATCH v2] staging: greybus: Fix indentation in fw-management.c
Posted by Dan Carpenter 1 year, 11 months ago
On Mon, May 23, 2022 at 03:08:57PM +0300, Uri Arev wrote:
> Reported by Checkpatch:
> CHECK: Alignment should match open parenthesis
> 
> -Uri
> 

Don't put your name in the commit message like this.

> Signed-off-by: Uri Arev <me@wantyapps.xyz>
> ---
> v2: More understandable title, add Signed-off-by line

Why didn't you fix this one as well?

CHECK: Alignment should match open parenthesis
#452: FILE: drivers/staging/greybus/fw-management.c:452:
+               ret = fw_mgmt_load_and_validate_operation(fw_mgmt,
+                               intf_load.load_method, intf_load.firmware_tag);

regards,
dan carpenter