[PATCH] tracing: disable kcov on trace_preemptirq.c

Congyu Liu posted 1 patch 3 years, 11 months ago
kernel/trace/Makefile | 4 ++++
1 file changed, 4 insertions(+)
[PATCH] tracing: disable kcov on trace_preemptirq.c
Posted by Congyu Liu 3 years, 11 months ago
Functions in trace_preemptirq.c could be invoked from early interrupt
code that bypasses kcov trace function's in_task() check. Disable kcov
on this file to reduce random code coverage.

Signed-off-by: Congyu Liu <liu3101@purdue.edu>
---
 kernel/trace/Makefile | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/kernel/trace/Makefile b/kernel/trace/Makefile
index d77cd8032213..0d261774d6f3 100644
--- a/kernel/trace/Makefile
+++ b/kernel/trace/Makefile
@@ -31,6 +31,10 @@ ifdef CONFIG_GCOV_PROFILE_FTRACE
 GCOV_PROFILE := y
 endif
 
+# Functions in this file could be invoked from early interrupt
+# code and produce random code coverage.
+KCOV_INSTRUMENT_trace_preemptirq.o := n
+
 CFLAGS_bpf_trace.o := -I$(src)
 
 CFLAGS_trace_benchmark.o := -I$(src)
-- 
2.34.1
Re: [PATCH] tracing: disable kcov on trace_preemptirq.c
Posted by Dmitry Vyukov 3 years, 11 months ago
On Mon, 23 May 2022 at 08:30, Congyu Liu <liu3101@purdue.edu> wrote:
>
> Functions in trace_preemptirq.c could be invoked from early interrupt
> code that bypasses kcov trace function's in_task() check. Disable kcov
> on this file to reduce random code coverage.
>
> Signed-off-by: Congyu Liu <liu3101@purdue.edu>

Acked-by: Dmitry Vyukov <dvyukov@google.com>

> ---
>  kernel/trace/Makefile | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/kernel/trace/Makefile b/kernel/trace/Makefile
> index d77cd8032213..0d261774d6f3 100644
> --- a/kernel/trace/Makefile
> +++ b/kernel/trace/Makefile
> @@ -31,6 +31,10 @@ ifdef CONFIG_GCOV_PROFILE_FTRACE
>  GCOV_PROFILE := y
>  endif
>
> +# Functions in this file could be invoked from early interrupt
> +# code and produce random code coverage.
> +KCOV_INSTRUMENT_trace_preemptirq.o := n
> +
>  CFLAGS_bpf_trace.o := -I$(src)
>
>  CFLAGS_trace_benchmark.o := -I$(src)
> --
> 2.34.1
>