[PATCH] net: fddi: skfp: smt: Remove extra parameters to vararg macro

Tom Rix posted 1 patch 3 years, 11 months ago
drivers/net/fddi/skfp/smt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] net: fddi: skfp: smt: Remove extra parameters to vararg macro
Posted by Tom Rix 3 years, 11 months ago
cppcheck reports
[drivers/net/fddi/skfp/smt.c:750]: (warning) printf format string requires 0 parameters but 2 are given.

DB_SBAN is a vararg macro, like DB_ESSN.  Remove the extra args and the nl.

Signed-off-by: Tom Rix <trix@redhat.com>
---
 drivers/net/fddi/skfp/smt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/fddi/skfp/smt.c b/drivers/net/fddi/skfp/smt.c
index 72c31f0013ad..dd15af4e98c2 100644
--- a/drivers/net/fddi/skfp/smt.c
+++ b/drivers/net/fddi/skfp/smt.c
@@ -747,7 +747,7 @@ void smt_received_pack(struct s_smc *smc, SMbuf *mb, int fs)
 #endif
 
 #ifdef	SBA
-		DB_SBAN(2,"SBA: RAF frame received\n",0,0) ;
+		DB_SBAN(2, "SBA: RAF frame received") ;
 		sba_raf_received_pack(smc,sm,fs) ;
 #endif
 		break ;
-- 
2.27.0
Re: [PATCH] net: fddi: skfp: smt: Remove extra parameters to vararg macro
Posted by patchwork-bot+netdevbpf@kernel.org 3 years, 11 months ago
Hello:

This patch was applied to netdev/net-next.git (master)
by David S. Miller <davem@davemloft.net>:

On Sun, 22 May 2022 09:36:27 -0400 you wrote:
> cppcheck reports
> [drivers/net/fddi/skfp/smt.c:750]: (warning) printf format string requires 0 parameters but 2 are given.
> 
> DB_SBAN is a vararg macro, like DB_ESSN.  Remove the extra args and the nl.
> 
> Signed-off-by: Tom Rix <trix@redhat.com>
> 
> [...]

Here is the summary with links:
  - net: fddi: skfp: smt: Remove extra parameters to vararg macro
    https://git.kernel.org/netdev/net-next/c/2a11fb1d1b85

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html