ARM: dts: qcom-msm8974: fix irq type on blsp2_uart1

[PATCH] ARM: dts: qcom-msm8974: fix irq type on blsp2_uart1

Posted by Luca Weiss 3 years, 11 months ago

IRQ_TYPE_NONE is invalid, so use the correct interrupt type.

Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
---
 arch/arm/boot/dts/qcom-msm8974.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi b/arch/arm/boot/dts/qcom-msm8974.dtsi
index 814ad0b46232..f84cdfc4fdcb 100644
--- a/arch/arm/boot/dts/qcom-msm8974.dtsi
+++ b/arch/arm/boot/dts/qcom-msm8974.dtsi
@@ -578,7 +578,7 @@ blsp2_dma: dma-controller@f9944000 {
 		blsp2_uart1: serial@f995d000 {
 			compatible = "qcom,msm-uartdm-v1.4", "qcom,msm-uartdm";
 			reg = <0xf995d000 0x1000>;
-			interrupts = <GIC_SPI 113 IRQ_TYPE_NONE>;
+			interrupts = <GIC_SPI 113 IRQ_TYPE_LEVEL_HIGH>;
 			clocks = <&gcc GCC_BLSP2_UART1_APPS_CLK>, <&gcc GCC_BLSP2_AHB_CLK>;
 			clock-names = "core", "iface";
 			status = "disabled";
-- 
2.36.0

Re: (subset) [PATCH] ARM: dts: qcom-msm8974: fix irq type on blsp2_uart1

Posted by Bjorn Andersson 3 years, 10 months ago

On Sun, 22 May 2022 10:36:18 +0200, Luca Weiss wrote:
> IRQ_TYPE_NONE is invalid, so use the correct interrupt type.
> 
> 

Applied, thanks!

[1/1] ARM: dts: qcom-msm8974: fix irq type on blsp2_uart1
      commit: ab1489017aa7a9f02e24bee73cf9ec8079cd3909

Best regards,
-- 
Bjorn Andersson <bjorn.andersson@linaro.org>

Re: [PATCH] ARM: dts: qcom-msm8974: fix irq type on blsp2_uart1

Posted by Krzysztof Kozlowski 3 years, 11 months ago

On 22/05/2022 10:36, Luca Weiss wrote:
> IRQ_TYPE_NONE is invalid, so use the correct interrupt type.
> 
> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>

This is needed:
Fixes: b05f82b152c9 ("ARM: dts: qcom: msm8974: Add blsp2_uart7 for
bluetooth on sirius")



Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>



Best regards,
Krzysztof