[PATCH] samples: fix compile failure error

Ruijian Li posted 1 patch 3 years, 11 months ago
samples/bpf/test_lru_dist.c | 4 ----
1 file changed, 4 deletions(-)
[PATCH] samples: fix compile failure error
Posted by Ruijian Li 3 years, 11 months ago
Because compile samples/bpf/test_lru_dist failure, I remove the
declaration of the struct list_head.

Signed-off-by: Ruijian Li <ruijian63@gmail.com>
---
 samples/bpf/test_lru_dist.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/samples/bpf/test_lru_dist.c b/samples/bpf/test_lru_dist.c
index 75e877853596..dd7eb470653b 100644
--- a/samples/bpf/test_lru_dist.c
+++ b/samples/bpf/test_lru_dist.c
@@ -33,10 +33,6 @@ static int nr_cpus;
 static unsigned long long *dist_keys;
 static unsigned int dist_key_counts;
 
-struct list_head {
-	struct list_head *next, *prev;
-};
-
 static inline void INIT_LIST_HEAD(struct list_head *list)
 {
 	list->next = list;
-- 
2.32.0
Re: [PATCH] samples: fix compile failure error
Posted by Andrii Nakryiko 3 years, 11 months ago
On Fri, May 20, 2022 at 5:09 PM Ruijian Li <ruijian63@gmail.com> wrote:
>
> Because compile samples/bpf/test_lru_dist failure, I remove the
> declaration of the struct list_head.
>
> Signed-off-by: Ruijian Li <ruijian63@gmail.com>
> ---
>  samples/bpf/test_lru_dist.c | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/samples/bpf/test_lru_dist.c b/samples/bpf/test_lru_dist.c
> index 75e877853596..dd7eb470653b 100644
> --- a/samples/bpf/test_lru_dist.c
> +++ b/samples/bpf/test_lru_dist.c
> @@ -33,10 +33,6 @@ static int nr_cpus;
>  static unsigned long long *dist_keys;
>  static unsigned int dist_key_counts;
>
> -struct list_head {
> -       struct list_head *next, *prev;
> -};
> -

this struct is used right there one line below, how removing it fixes
compilation issues? What was the error in the first place? Did you run
`make headers_install` before building samples/bpf? Please provide a
bit more information.

>  static inline void INIT_LIST_HEAD(struct list_head *list)
>  {
>         list->next = list;
> --
> 2.32.0
>