perf inject: Minor improvements

[PATCH 0/5] perf inject: Minor improvements

Posted by Adrian Hunter 3 years, 11 months ago

Hi

Here are patches for 2 minor improvements for perf inject:
1. Keep some features sections from input file
2. Keep a copy of kcore_dir


Adrian Hunter (5):
      perf header: Add ability to keep feature sections
      libperf: Add preadn()
      perf inject: Keep some features sections from input file
      perf data: Add has_kcore_dir()
      perf inject: Keep a copy of kcore_dir

 tools/lib/perf/include/internal/lib.h |   2 +
 tools/lib/perf/lib.c                  |  20 +++++
 tools/perf/builtin-inject.c           | 162 +++++++++++++++++++++++++++++++++-
 tools/perf/util/data.c                |  14 +++
 tools/perf/util/data.h                |   1 +
 tools/perf/util/header.c              |  62 +++++++++++--
 tools/perf/util/header.h              |  15 ++++
 7 files changed, 264 insertions(+), 12 deletions(-)


Regards
Adrian

Re: [PATCH 0/5] perf inject: Minor improvements

Posted by Jiri Olsa 3 years, 11 months ago

On Fri, May 20, 2022 at 04:23:59PM +0300, Adrian Hunter wrote:
> Hi
> 
> Here are patches for 2 minor improvements for perf inject:
> 1. Keep some features sections from input file
> 2. Keep a copy of kcore_dir
> 
> 
> Adrian Hunter (5):
>       perf header: Add ability to keep feature sections
>       libperf: Add preadn()
>       perf inject: Keep some features sections from input file
>       perf data: Add has_kcore_dir()
>       perf inject: Keep a copy of kcore_dir

LGTM

Acked-by: Jiri Olsa <jolsa@kernel.org>

thanks,
jirka

> 
>  tools/lib/perf/include/internal/lib.h |   2 +
>  tools/lib/perf/lib.c                  |  20 +++++
>  tools/perf/builtin-inject.c           | 162 +++++++++++++++++++++++++++++++++-
>  tools/perf/util/data.c                |  14 +++
>  tools/perf/util/data.h                |   1 +
>  tools/perf/util/header.c              |  62 +++++++++++--
>  tools/perf/util/header.h              |  15 ++++
>  7 files changed, 264 insertions(+), 12 deletions(-)
> 
> 
> Regards
> Adrian

Re: [PATCH 0/5] perf inject: Minor improvements

Posted by Arnaldo Carvalho de Melo 3 years, 11 months ago

Em Mon, May 23, 2022 at 10:16:56AM +0200, Jiri Olsa escreveu:
> On Fri, May 20, 2022 at 04:23:59PM +0300, Adrian Hunter wrote:
> > Hi
> > 
> > Here are patches for 2 minor improvements for perf inject:
> > 1. Keep some features sections from input file
> > 2. Keep a copy of kcore_dir
> > 
> > 
> > Adrian Hunter (5):
> >       perf header: Add ability to keep feature sections
> >       libperf: Add preadn()
> >       perf inject: Keep some features sections from input file
> >       perf data: Add has_kcore_dir()
> >       perf inject: Keep a copy of kcore_dir
> 
> LGTM
> 
> Acked-by: Jiri Olsa <jolsa@kernel.org>

Thanks, applied.

- Arnaldo

 
> thanks,
> jirka
> 
> > 
> >  tools/lib/perf/include/internal/lib.h |   2 +
> >  tools/lib/perf/lib.c                  |  20 +++++
> >  tools/perf/builtin-inject.c           | 162 +++++++++++++++++++++++++++++++++-
> >  tools/perf/util/data.c                |  14 +++
> >  tools/perf/util/data.h                |   1 +
> >  tools/perf/util/header.c              |  62 +++++++++++--
> >  tools/perf/util/header.h              |  15 ++++
> >  7 files changed, 264 insertions(+), 12 deletions(-)
> > 
> > 
> > Regards
> > Adrian

-- 

- Arnaldo