[PATCH 0/2] s390: Kconfig: Style cleanups

Juerg Haefliger posted 2 patches 3 years, 11 months ago
arch/s390/Kconfig       | 20 ++++++++++----------
arch/s390/Kconfig.debug | 12 ++++++------
2 files changed, 16 insertions(+), 16 deletions(-)
[PATCH 0/2] s390: Kconfig: Style cleanups
Posted by Juerg Haefliger 3 years, 11 months ago
The majority of the Kconfig files use a single tab for basic indentation
and a single tab followed by two whitespaces for help text indentation.
Fix the lines that don't follow this convention.

While at it:
  - Add trailing comments to endif/endmenu statements for better
    readability.

Juerg Haefliger (2):
  s390: Kconfig: Fix indentation and add comments
  s390: Kconfig.debug: Fix indentation

 arch/s390/Kconfig       | 20 ++++++++++----------
 arch/s390/Kconfig.debug | 12 ++++++------
 2 files changed, 16 insertions(+), 16 deletions(-)

-- 
2.32.0
Re: [PATCH 0/2] s390: Kconfig: Style cleanups
Posted by Heiko Carstens 3 years, 11 months ago
On Fri, May 20, 2022 at 01:57:06PM +0200, Juerg Haefliger wrote:
> The majority of the Kconfig files use a single tab for basic indentation
> and a single tab followed by two whitespaces for help text indentation.
> Fix the lines that don't follow this convention.
> 
> While at it:
>   - Add trailing comments to endif/endmenu statements for better
>     readability.
> 
> Juerg Haefliger (2):
>   s390: Kconfig: Fix indentation and add comments
>   s390: Kconfig.debug: Fix indentation
> 
>  arch/s390/Kconfig       | 20 ++++++++++----------
>  arch/s390/Kconfig.debug | 12 ++++++------
>  2 files changed, 16 insertions(+), 16 deletions(-)

Both applied (v2 for the first patch). Thanks!
Re: [PATCH 0/2] s390: Kconfig: Style cleanups
Posted by Heiko Carstens 3 years, 11 months ago
On Mon, May 23, 2022 at 11:39:31AM +0200, Heiko Carstens wrote:
> On Fri, May 20, 2022 at 01:57:06PM +0200, Juerg Haefliger wrote:
> > The majority of the Kconfig files use a single tab for basic indentation
> > and a single tab followed by two whitespaces for help text indentation.
> > Fix the lines that don't follow this convention.
> > 
> > While at it:
> >   - Add trailing comments to endif/endmenu statements for better
> >     readability.
> > 
> > Juerg Haefliger (2):
> >   s390: Kconfig: Fix indentation and add comments
> >   s390: Kconfig.debug: Fix indentation
> > 
> >  arch/s390/Kconfig       | 20 ++++++++++----------
> >  arch/s390/Kconfig.debug | 12 ++++++------
> >  2 files changed, 16 insertions(+), 16 deletions(-)
> 
> Both applied (v2 for the first patch). Thanks!

..and removed both patches again. Please make sure that your email
addresses match. That is: the email address you use for signing off
and the one you use for sending. Right now there is a mismatch when I
apply your patches in "From:" and "Signed-off-by:".

Please resend.
[PATCH 1/2 v3] s390: Kconfig: Fix indentation
Posted by Juerg Haefliger 3 years, 11 months ago
The convention for indentation seems to be a single tab. Help text is
further indented by an additional two whitespaces. Fix the lines that
violate these rules.

Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com>
---
v3:
 Change author and sob email addresses to match sender email address.
v2:
  Drop trailing endmenu comments.

---
 arch/s390/Kconfig | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig
index e084c72104f8..543e859905df 100644
--- a/arch/s390/Kconfig
+++ b/arch/s390/Kconfig
@@ -736,11 +736,11 @@ config VFIO_AP
 	depends on S390_AP_IOMMU && VFIO_MDEV && KVM
 	depends on ZCRYPT
 	help
-		This driver grants access to Adjunct Processor (AP) devices
-		via the VFIO mediated device interface.
+	  This driver grants access to Adjunct Processor (AP) devices
+	  via the VFIO mediated device interface.
 
-		To compile this driver as a module, choose M here: the module
-		will be called vfio_ap.
+	  To compile this driver as a module, choose M here: the module
+	  will be called vfio_ap.
 
 endmenu
 
-- 
2.32.0
[PATCH 2/2 v2] s390: Kconfig.debug: Fix indentation
Posted by Juerg Haefliger 3 years, 11 months ago
The convention for indentation seems to be a single tab. Help text is
further indented by an additional two whitespaces. Fix the lines that
violate these rules.

Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com>
---
v2:
 Change author and sob email addresses to match sender email address.

---
 arch/s390/Kconfig.debug | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/arch/s390/Kconfig.debug b/arch/s390/Kconfig.debug
index e94a2a7f6bf4..c4300ea4abf8 100644
--- a/arch/s390/Kconfig.debug
+++ b/arch/s390/Kconfig.debug
@@ -14,9 +14,9 @@ config DEBUG_ENTRY
 	  If unsure, say N.
 
 config CIO_INJECT
-       bool "CIO Inject interfaces"
-       depends on DEBUG_KERNEL && DEBUG_FS
-       help
-	This option provides a debugging facility to inject certain artificial events
-	and instruction responses to the CIO layer of Linux kernel. The newly created
-	debugfs user-interfaces will be at /sys/kernel/debug/s390/cio/*
+	bool "CIO Inject interfaces"
+	depends on DEBUG_KERNEL && DEBUG_FS
+	help
+	  This option provides a debugging facility to inject certain artificial events
+	  and instruction responses to the CIO layer of Linux kernel. The newly created
+	  debugfs user-interfaces will be at /sys/kernel/debug/s390/cio/*
-- 
2.32.0