media/platform-wide: platform: Add moli to the match table

[PATCH] [v2] media/platform-wide: platform: Add moli to the match table

Posted by Scott Chao 3 years, 11 months ago

The Google Moli device uses the same approach as the Google Brask
which enables the HDMI CEC via the cros-ec-cec driver.

Signed-off-by: Scott Chao <scott_chao@wistron.corp-partner.google.com>
---
 drivers/media/cec/platform/cros-ec/cros-ec-cec.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/media/cec/platform/cros-ec/cros-ec-cec.c b/drivers/media/cec/platform/cros-ec/cros-ec-cec.c
index 8c8d8fc5e63e..25dc7309beab 100644
--- a/drivers/media/cec/platform/cros-ec/cros-ec-cec.c
+++ b/drivers/media/cec/platform/cros-ec/cros-ec-cec.c
@@ -217,6 +217,8 @@ static const struct cec_dmi_match cec_dmi_match_table[] = {
 	{ "Google", "Fizz", "0000:00:02.0", "Port B" },
 	/* Google Brask */
 	{ "Google", "Brask", "0000:00:02.0", "Port B" },
+	/* Google Moli */
+	{ "Google", "Moli", "0000:00:02.0", "Port B" },
 };
 
 static struct device *cros_ec_cec_find_hdmi_dev(struct device *dev,
-- 
2.36.1

Re: [PATCH] [v2] media/platform-wide: platform: Add moli to the match table

Posted by Hans Verkuil 3 years, 11 months ago

Huh? The Subject is now *really* bad. I think you misunderstood my comment
on the original patch.

"[PATCH] media: platform: foo" suggests a patch touching on many drivers in
drivers/media/platform. But this patch only touches on a single driver, so:

"[PATCH] media: platform: cros-ec: foo"

That way the maintainer of that driver will see the name of the driver in the
subject as well, and might comment upon it.

Regards,

	Hans

On 5/20/22 12:42, Scott Chao wrote:
> The Google Moli device uses the same approach as the Google Brask
> which enables the HDMI CEC via the cros-ec-cec driver.
> 
> Signed-off-by: Scott Chao <scott_chao@wistron.corp-partner.google.com>
> ---
>  drivers/media/cec/platform/cros-ec/cros-ec-cec.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/media/cec/platform/cros-ec/cros-ec-cec.c b/drivers/media/cec/platform/cros-ec/cros-ec-cec.c
> index 8c8d8fc5e63e..25dc7309beab 100644
> --- a/drivers/media/cec/platform/cros-ec/cros-ec-cec.c
> +++ b/drivers/media/cec/platform/cros-ec/cros-ec-cec.c
> @@ -217,6 +217,8 @@ static const struct cec_dmi_match cec_dmi_match_table[] = {
>  	{ "Google", "Fizz", "0000:00:02.0", "Port B" },
>  	/* Google Brask */
>  	{ "Google", "Brask", "0000:00:02.0", "Port B" },
> +	/* Google Moli */
> +	{ "Google", "Moli", "0000:00:02.0", "Port B" },
>  };
>  
>  static struct device *cros_ec_cec_find_hdmi_dev(struct device *dev,