[v6] RZN1 USB Host support

[PATCH v6 0/6] RZN1 USB Host support

Posted by Herve Codina 3 years, 11 months ago

Hi,

This series add support for the USB Host controllers available on
RZN1 (r9a06g032) SOC.

These USB Host controllers are PCI OHCI/EHCI controllers located
behind a bridge.

Regards,
Herve

Changes v2:
- Convert bindings to json-schema
- Update clocks description
- Remove unneeded '.compatible = "renesas,pci-r9a06g032"'

Changes v3:
- Remove the unneeded patch that calls clk_bulk_prepare_enable()
- Rework the device tree binding (conversion from .txt and RZ/N1 support)
- Use the RZ/N1 SOCs family only in the driver match compatible string.
- Enable PM and PM_GENERIC_DOMAIN for RZ/N1 and add the missing
  '#power-domain-cells' in sysctrl node.

Changes v4:
- Remove patches related to PM enable and #pwower-domain-cells as they
  will be handle out of this series.
- Add Bob's reviewed-by on patch 1
- Add Geert's reviewed by on patch 1 and 6
- Rename clocks and make the 'resets' property optional on RZ/N1 family
- Reword some commit logs and titles
- Fix dst node location (sort by node names or unit addresses)
- Fix the USB PHY node name

Changes v5:
- Rename clocks ("usb_" prefix removed)
- Add Geert's reviewed-by on patch 2, 3, 4 and 5

Changes v6:
- Include schema optionnal part (ie 'if:') in a 'allOf:' block
- Modify commit log on commit 2/6

Herve Codina (6):
  dt-bindings: PCI: pci-rcar-gen2: Convert bindings to json-schema
  dt-bindings: PCI: renesas,pci-rcar-gen2: Add device tree support for
    r9a06g032
  PCI: rcar-gen2: Add RZ/N1 SOCs family compatible string
  ARM: dts: r9a06g032: Add internal PCI bridge node
  ARM: dts: r9a06g032: Add USB PHY DT support
  ARM: dts: r9a06g032: Link the PCI USB devices to the USB PHY

 .../devicetree/bindings/pci/pci-rcar-gen2.txt |  84 --------
 .../bindings/pci/renesas,pci-rcar-gen2.yaml   | 186 ++++++++++++++++++
 arch/arm/boot/dts/r9a06g032.dtsi              |  47 +++++
 drivers/pci/controller/pci-rcar-gen2.c        |   1 +
 4 files changed, 234 insertions(+), 84 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/pci/pci-rcar-gen2.txt
 create mode 100644 Documentation/devicetree/bindings/pci/renesas,pci-rcar-gen2.yaml

-- 
2.35.1

Re: [PATCH v6 0/6] RZN1 USB Host support

Posted by Bjorn Helgaas 3 years, 10 months ago

On Fri, May 20, 2022 at 11:41:49AM +0200, Herve Codina wrote:
> Hi,
> 
> This series add support for the USB Host controllers available on
> RZN1 (r9a06g032) SOC.
> 
> These USB Host controllers are PCI OHCI/EHCI controllers located
> behind a bridge.
> 
> Regards,
> Herve
> 
> Changes v2:
> - Convert bindings to json-schema
> - Update clocks description
> - Remove unneeded '.compatible = "renesas,pci-r9a06g032"'
> 
> Changes v3:
> - Remove the unneeded patch that calls clk_bulk_prepare_enable()
> - Rework the device tree binding (conversion from .txt and RZ/N1 support)
> - Use the RZ/N1 SOCs family only in the driver match compatible string.
> - Enable PM and PM_GENERIC_DOMAIN for RZ/N1 and add the missing
>   '#power-domain-cells' in sysctrl node.
> 
> Changes v4:
> - Remove patches related to PM enable and #pwower-domain-cells as they
>   will be handle out of this series.
> - Add Bob's reviewed-by on patch 1
> - Add Geert's reviewed by on patch 1 and 6
> - Rename clocks and make the 'resets' property optional on RZ/N1 family
> - Reword some commit logs and titles
> - Fix dst node location (sort by node names or unit addresses)
> - Fix the USB PHY node name
> 
> Changes v5:
> - Rename clocks ("usb_" prefix removed)
> - Add Geert's reviewed-by on patch 2, 3, 4 and 5
> 
> Changes v6:
> - Include schema optionnal part (ie 'if:') in a 'allOf:' block
> - Modify commit log on commit 2/6
> 
> Herve Codina (6):
>   dt-bindings: PCI: pci-rcar-gen2: Convert bindings to json-schema
>   dt-bindings: PCI: renesas,pci-rcar-gen2: Add device tree support for
>     r9a06g032
>   PCI: rcar-gen2: Add RZ/N1 SOCs family compatible string

Applied the first three patches (above) to pci/ctrl/rcar-gen2 for
v5.20, thank you!

>   ARM: dts: r9a06g032: Add internal PCI bridge node
>   ARM: dts: r9a06g032: Add USB PHY DT support
>   ARM: dts: r9a06g032: Link the PCI USB devices to the USB PHY
> 
>  .../devicetree/bindings/pci/pci-rcar-gen2.txt |  84 --------
>  .../bindings/pci/renesas,pci-rcar-gen2.yaml   | 186 ++++++++++++++++++
>  arch/arm/boot/dts/r9a06g032.dtsi              |  47 +++++
>  drivers/pci/controller/pci-rcar-gen2.c        |   1 +
>  4 files changed, 234 insertions(+), 84 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/pci/pci-rcar-gen2.txt
>  create mode 100644 Documentation/devicetree/bindings/pci/renesas,pci-rcar-gen2.yaml
> 
> -- 
> 2.35.1
>

Re: [PATCH v6 0/6] RZN1 USB Host support

Posted by Bjorn Helgaas 3 years, 10 months ago

On Thu, Jun 23, 2022 at 05:39:14PM -0500, Bjorn Helgaas wrote:
> On Fri, May 20, 2022 at 11:41:49AM +0200, Herve Codina wrote:
> > Hi,
> > 
> > This series add support for the USB Host controllers available on
> > RZN1 (r9a06g032) SOC.
> > 
> > These USB Host controllers are PCI OHCI/EHCI controllers located
> > behind a bridge.
> > 
> > Regards,
> > Herve
> > 
> > Changes v2:
> > - Convert bindings to json-schema
> > - Update clocks description
> > - Remove unneeded '.compatible = "renesas,pci-r9a06g032"'
> > 
> > Changes v3:
> > - Remove the unneeded patch that calls clk_bulk_prepare_enable()
> > - Rework the device tree binding (conversion from .txt and RZ/N1 support)
> > - Use the RZ/N1 SOCs family only in the driver match compatible string.
> > - Enable PM and PM_GENERIC_DOMAIN for RZ/N1 and add the missing
> >   '#power-domain-cells' in sysctrl node.
> > 
> > Changes v4:
> > - Remove patches related to PM enable and #pwower-domain-cells as they
> >   will be handle out of this series.
> > - Add Bob's reviewed-by on patch 1
> > - Add Geert's reviewed by on patch 1 and 6
> > - Rename clocks and make the 'resets' property optional on RZ/N1 family
> > - Reword some commit logs and titles
> > - Fix dst node location (sort by node names or unit addresses)
> > - Fix the USB PHY node name
> > 
> > Changes v5:
> > - Rename clocks ("usb_" prefix removed)
> > - Add Geert's reviewed-by on patch 2, 3, 4 and 5
> > 
> > Changes v6:
> > - Include schema optionnal part (ie 'if:') in a 'allOf:' block
> > - Modify commit log on commit 2/6
> > 
> > Herve Codina (6):
> >   dt-bindings: PCI: pci-rcar-gen2: Convert bindings to json-schema
> >   dt-bindings: PCI: renesas,pci-rcar-gen2: Add device tree support for
> >     r9a06g032
> >   PCI: rcar-gen2: Add RZ/N1 SOCs family compatible string
> 
> Applied the first three patches (above) to pci/ctrl/rcar-gen2 for
> v5.20, thank you!

Oh, just noticed there's no ack from Marek or Yoshihiro, the
maintainers of drivers/pci/controller/pci-rcar-gen2.c.  Let me know if
you object!  If you can ack it, I will amend the commits to reflect
that.

Bjorn

Re: [PATCH v6 0/6] RZN1 USB Host support

Posted by Geert Uytterhoeven 3 years, 11 months ago

Hi Hervé,

On Fri, May 20, 2022 at 11:42 AM Herve Codina <herve.codina@bootlin.com> wrote:
> This series add support for the USB Host controllers available on
> RZN1 (r9a06g032) SOC.
>
> These USB Host controllers are PCI OHCI/EHCI controllers located
> behind a bridge.

Thanks for your series!

> Herve Codina (6):
>   dt-bindings: PCI: pci-rcar-gen2: Convert bindings to json-schema
>   dt-bindings: PCI: renesas,pci-rcar-gen2: Add device tree support for
>     r9a06g032
>   PCI: rcar-gen2: Add RZ/N1 SOCs family compatible string
>   ARM: dts: r9a06g032: Add internal PCI bridge node
>   ARM: dts: r9a06g032: Add USB PHY DT support
>   ARM: dts: r9a06g032: Link the PCI USB devices to the USB PHY

As I had applied v5 of the last 3 patches to renesas-devel, and they
are already present in soc/for-next, there is no need to resend them.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH v6 0/6] RZN1 USB Host support

Posted by Herve Codina 3 years, 11 months ago

On Fri, 20 May 2022 14:12:10 +0200
Geert Uytterhoeven <geert@linux-m68k.org> wrote:

> Hi Hervé,
> 
> On Fri, May 20, 2022 at 11:42 AM Herve Codina <herve.codina@bootlin.com> wrote:
> > This series add support for the USB Host controllers available on
> > RZN1 (r9a06g032) SOC.
> >
> > These USB Host controllers are PCI OHCI/EHCI controllers located
> > behind a bridge.  
> 
> Thanks for your series!
> 
> > Herve Codina (6):
> >   dt-bindings: PCI: pci-rcar-gen2: Convert bindings to json-schema
> >   dt-bindings: PCI: renesas,pci-rcar-gen2: Add device tree support for
> >     r9a06g032
> >   PCI: rcar-gen2: Add RZ/N1 SOCs family compatible string
> >   ARM: dts: r9a06g032: Add internal PCI bridge node
> >   ARM: dts: r9a06g032: Add USB PHY DT support
> >   ARM: dts: r9a06g032: Link the PCI USB devices to the USB PHY  
> 
> As I had applied v5 of the last 3 patches to renesas-devel, and they
> are already present in soc/for-next, there is no need to resend them.

Thanks. I note that for the next version of this series if needed.

Regards,
Hervé

-- 
Hervé Codina, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com