[PATCH V3 0/4] Several perf metrics topdown related fixes

kan.liang@linux.intel.com posted 4 patches 3 years, 11 months ago
tools/perf/arch/x86/util/evlist.c  |  7 ++++---
tools/perf/arch/x86/util/evsel.c   | 23 +++++++++++++++++++++--
tools/perf/arch/x86/util/topdown.c | 25 +++++++++++++++++++++++++
tools/perf/arch/x86/util/topdown.h |  7 +++++++
tools/perf/builtin-stat.c          |  7 ++-----
tools/perf/util/evlist.c           |  6 +-----
tools/perf/util/evsel.c            | 13 +++++++++++--
tools/perf/util/evsel.h            |  2 +-
8 files changed, 72 insertions(+), 18 deletions(-)
create mode 100644 tools/perf/arch/x86/util/topdown.h
[PATCH V3 0/4] Several perf metrics topdown related fixes
Posted by kan.liang@linux.intel.com 3 years, 11 months ago
From: Kan Liang <kan.liang@linux.intel.com>

The Patch 1 is a follow-up patch for Ian's ("Fix topdown event weak
grouping")[1].

The patch 2 is to fix the perf metrics topdown events in a mixed group.
It reuses the function introduced in [1].
Patch 1 & 2 should be on top of [1].

The patch 3 & 4 are to fix other perf metrics topdown related issues.
They can be merged separately.

[1]: https://lore.kernel.org/all/20220517052724.283874-2-irogers@google.com/

Changes since V2:
- Add more comments for the evsel__sys_has_perf_metrics() and
  topdown_sys_has_perf_metrics()
- Remove the uncessary evsel->core.leader->nr_members = 0; in patch 2.
  The value has been updated in the new evsel__remove_from_group().
- Add Reviewed-by from Ian for patch 4

Changes since V1:
- Add comments for the evsel__sys_has_perf_metrics() and
  topdown_sys_has_perf_metrics()
- Factor out evsel__remove_from_group()
- Add Reviewed-by from Ian for patch 3

Kan Liang (4):
  perf evsel: Fixes topdown events in a weak group for the hybrid
    platform
  perf stat: Always keep perf metrics topdown events in a group
  perf parse-events: Support different format of the topdown event name
  perf parse-events: Move slots event for the hybrid platform too

 tools/perf/arch/x86/util/evlist.c  |  7 ++++---
 tools/perf/arch/x86/util/evsel.c   | 23 +++++++++++++++++++++--
 tools/perf/arch/x86/util/topdown.c | 25 +++++++++++++++++++++++++
 tools/perf/arch/x86/util/topdown.h |  7 +++++++
 tools/perf/builtin-stat.c          |  7 ++-----
 tools/perf/util/evlist.c           |  6 +-----
 tools/perf/util/evsel.c            | 13 +++++++++++--
 tools/perf/util/evsel.h            |  2 +-
 8 files changed, 72 insertions(+), 18 deletions(-)
 create mode 100644 tools/perf/arch/x86/util/topdown.h

-- 
2.35.1
Re: [PATCH V3 0/4] Several perf metrics topdown related fixes
Posted by Arnaldo Carvalho de Melo 3 years, 11 months ago
Em Wed, May 18, 2022 at 07:38:56AM -0700, kan.liang@linux.intel.com escreveu:
> From: Kan Liang <kan.liang@linux.intel.com>
> 
> The Patch 1 is a follow-up patch for Ian's ("Fix topdown event weak
> grouping")[1].
> 
> The patch 2 is to fix the perf metrics topdown events in a mixed group.
> It reuses the function introduced in [1].
> Patch 1 & 2 should be on top of [1].
> 
> The patch 3 & 4 are to fix other perf metrics topdown related issues.
> They can be merged separately.
> 
> [1]: https://lore.kernel.org/all/20220517052724.283874-2-irogers@google.com/

Thanks, applied.

- Arnaldo

 
> Changes since V2:
> - Add more comments for the evsel__sys_has_perf_metrics() and
>   topdown_sys_has_perf_metrics()
> - Remove the uncessary evsel->core.leader->nr_members = 0; in patch 2.
>   The value has been updated in the new evsel__remove_from_group().
> - Add Reviewed-by from Ian for patch 4
> 
> Changes since V1:
> - Add comments for the evsel__sys_has_perf_metrics() and
>   topdown_sys_has_perf_metrics()
> - Factor out evsel__remove_from_group()
> - Add Reviewed-by from Ian for patch 3
> 
> Kan Liang (4):
>   perf evsel: Fixes topdown events in a weak group for the hybrid
>     platform
>   perf stat: Always keep perf metrics topdown events in a group
>   perf parse-events: Support different format of the topdown event name
>   perf parse-events: Move slots event for the hybrid platform too
> 
>  tools/perf/arch/x86/util/evlist.c  |  7 ++++---
>  tools/perf/arch/x86/util/evsel.c   | 23 +++++++++++++++++++++--
>  tools/perf/arch/x86/util/topdown.c | 25 +++++++++++++++++++++++++
>  tools/perf/arch/x86/util/topdown.h |  7 +++++++
>  tools/perf/builtin-stat.c          |  7 ++-----
>  tools/perf/util/evlist.c           |  6 +-----
>  tools/perf/util/evsel.c            | 13 +++++++++++--
>  tools/perf/util/evsel.h            |  2 +-
>  8 files changed, 72 insertions(+), 18 deletions(-)
>  create mode 100644 tools/perf/arch/x86/util/topdown.h
> 
> -- 
> 2.35.1

-- 

- Arnaldo