[PATCH] scsi: qla1280: remove redundant variable toke

Colin Ian King posted 1 patch 3 years, 11 months ago
drivers/scsi/qla1280.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
[PATCH] scsi: qla1280: remove redundant variable toke
Posted by Colin Ian King 3 years, 11 months ago
Variable toke is being assigned a value that is never read. The variable
is redundant, remove it.

Cleans up clang scan build warning:
warning: Although the value stored to 'toke' is used in the enclosing
expression, the value is never actually read from 'toke'
[deadcode.DeadStores]

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
 drivers/scsi/qla1280.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/scsi/qla1280.c b/drivers/scsi/qla1280.c
index 0ab595c0870a..1e7f4d138e06 100644
--- a/drivers/scsi/qla1280.c
+++ b/drivers/scsi/qla1280.c
@@ -4037,7 +4037,6 @@ qla1280_setup(char *s)
 {
 	char *cp, *ptr;
 	unsigned long val;
-	int toke;
 
 	cp = s;
 
@@ -4052,7 +4051,7 @@ qla1280_setup(char *s)
 		} else
 			val = simple_strtoul(ptr, &ptr, 0);
 
-		switch ((toke = qla1280_get_token(cp))) {
+		switch (qla1280_get_token(cp)) {
 		case TOKEN_NVRAM:
 			if (!val)
 				driver_setup.no_nvram = 1;
-- 
2.35.1
Re: [PATCH] scsi: qla1280: remove redundant variable toke
Posted by Martin K. Petersen 3 years, 11 months ago
On Wed, 18 May 2022 11:21:03 +0100, Colin Ian King wrote:

> Variable toke is being assigned a value that is never read. The variable
> is redundant, remove it.
> 
> Cleans up clang scan build warning:
> warning: Although the value stored to 'toke' is used in the enclosing
> expression, the value is never actually read from 'toke'
> [deadcode.DeadStores]
> 
> [...]

Applied to 5.19/scsi-queue, thanks!

[1/1] scsi: qla1280: remove redundant variable toke
      https://git.kernel.org/mkp/scsi/c/c10ba0c961d3

-- 
Martin K. Petersen	Oracle Linux Engineering
Re: [PATCH] scsi: qla1280: remove redundant variable toke
Posted by Martin K. Petersen 3 years, 11 months ago
Colin,

> Variable toke is being assigned a value that is never read. The
> variable is redundant, remove it.

Applied to 5.19/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering