[PATCH] net: fec: Avoid allocating rx buffer using ATOMIC in ndo_open

Michael Trimarchi posted 1 patch 3 years, 11 months ago
drivers/net/ethernet/freescale/fec_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] net: fec: Avoid allocating rx buffer using ATOMIC in ndo_open
Posted by Michael Trimarchi 3 years, 11 months ago
Make ndo_open less sensitive to memory pressure.

Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
---
Change:
	- Adjust the commit message addressing the comments in RFC version
---
 drivers/net/ethernet/freescale/fec_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
index 9f33ec838b52..09eb6ea9a584 100644
--- a/drivers/net/ethernet/freescale/fec_main.c
+++ b/drivers/net/ethernet/freescale/fec_main.c
@@ -3076,7 +3076,7 @@ fec_enet_alloc_rxq_buffers(struct net_device *ndev, unsigned int queue)
 	rxq = fep->rx_queue[queue];
 	bdp = rxq->bd.base;
 	for (i = 0; i < rxq->bd.ring_size; i++) {
-		skb = netdev_alloc_skb(ndev, FEC_ENET_RX_FRSIZE);
+		skb = __netdev_alloc_skb(ndev, FEC_ENET_RX_FRSIZE, GFP_KERNEL);
 		if (!skb)
 			goto err_alloc;
 
-- 
2.25.1
Re: [PATCH] net: fec: Avoid allocating rx buffer using ATOMIC in ndo_open
Posted by patchwork-bot+netdevbpf@kernel.org 3 years, 11 months ago
Hello:

This patch was applied to netdev/net-next.git (master)
by Paolo Abeni <pabeni@redhat.com>:

On Wed, 18 May 2022 08:20:07 +0200 you wrote:
> Make ndo_open less sensitive to memory pressure.
> 
> Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
> ---
> Change:
> 	- Adjust the commit message addressing the comments in RFC version
> 
> [...]

Here is the summary with links:
  - net: fec: Avoid allocating rx buffer using ATOMIC in ndo_open
    https://git.kernel.org/netdev/net-next/c/b885aab3d39d

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH] net: fec: Avoid allocating rx buffer using ATOMIC in ndo_open
Posted by Jakub Kicinski 3 years, 11 months ago
On Wed, 18 May 2022 08:20:07 +0200 Michael Trimarchi wrote:
> Make ndo_open less sensitive to memory pressure.
> 
> Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>

Reviewed-by: Jakub Kicinski <kuba@kernel.org>