[PATCH v2 0/8] Make more tests skip rather than fail

Ian Rogers posted 8 patches 3 years, 11 months ago
tools/perf/tests/builtin-test.c            |   6 +-
tools/perf/tests/mmap-basic.c              |  18 +-
tools/perf/tests/openat-syscall-all-cpus.c |  23 +-
tools/perf/tests/openat-syscall.c          |  20 +-
tools/perf/tests/parse-events.c            | 492 +++++++++++----------
tools/perf/tests/perf-record.c             |  18 +-
tools/perf/tests/vmlinux-kallsyms.c        |  12 +-
7 files changed, 341 insertions(+), 248 deletions(-)
[PATCH v2 0/8] Make more tests skip rather than fail
Posted by Ian Rogers 3 years, 11 months ago
A long standing niggle has been that tests that cannot pass are marked
as failing rather than skip.  John Garry mentioned a similar concern
in [1]. These changes fix this behavior so that as root, or not, at
least the first 10 tests are passing or skipping.

[1] https://lore.kernel.org/lkml/d32376b5-5538-ff00-6620-e74ad4b4abf2@huawei.com/

v2. Updates reviewed-by and acked-by. It addresses review comments
    from Namhyung Kim <namhyung@kernel.org>. An extra fix is now
    included for PERF_RECORD_* which can fail as a user because of
    perf_event_paranoid.

Ian Rogers (8):
  perf test: Skip reason for suites with 1 test
  perf test: Use skip in vmlinux kallsyms
  perf test: Use skip in openat syscall
  perf test: Basic mmap use skip
  perf test: Parse events tidy terms_test
  perf test: Parse events tidy evlist_test
  perf test: Parse events break apart tests
  perf test: Use skip in PERF_RECORD_*

 tools/perf/tests/builtin-test.c            |   6 +-
 tools/perf/tests/mmap-basic.c              |  18 +-
 tools/perf/tests/openat-syscall-all-cpus.c |  23 +-
 tools/perf/tests/openat-syscall.c          |  20 +-
 tools/perf/tests/parse-events.c            | 492 +++++++++++----------
 tools/perf/tests/perf-record.c             |  18 +-
 tools/perf/tests/vmlinux-kallsyms.c        |  12 +-
 7 files changed, 341 insertions(+), 248 deletions(-)

-- 
2.36.0.550.gb090851708-goog
Re: [PATCH v2 0/8] Make more tests skip rather than fail
Posted by Arnaldo Carvalho de Melo 3 years, 11 months ago
Em Tue, May 17, 2022 at 09:20:19PM -0700, Ian Rogers escreveu:
> A long standing niggle has been that tests that cannot pass are marked
> as failing rather than skip.  John Garry mentioned a similar concern
> in [1]. These changes fix this behavior so that as root, or not, at
> least the first 10 tests are passing or skipping.
> 
> [1] https://lore.kernel.org/lkml/d32376b5-5538-ff00-6620-e74ad4b4abf2@huawei.com/
> 
> v2. Updates reviewed-by and acked-by. It addresses review comments
>     from Namhyung Kim <namhyung@kernel.org>. An extra fix is now
>     included for PERF_RECORD_* which can fail as a user because of
>     perf_event_paranoid.

Thanks, applied.

- Arnaldo

 
> Ian Rogers (8):
>   perf test: Skip reason for suites with 1 test
>   perf test: Use skip in vmlinux kallsyms
>   perf test: Use skip in openat syscall
>   perf test: Basic mmap use skip
>   perf test: Parse events tidy terms_test
>   perf test: Parse events tidy evlist_test
>   perf test: Parse events break apart tests
>   perf test: Use skip in PERF_RECORD_*
> 
>  tools/perf/tests/builtin-test.c            |   6 +-
>  tools/perf/tests/mmap-basic.c              |  18 +-
>  tools/perf/tests/openat-syscall-all-cpus.c |  23 +-
>  tools/perf/tests/openat-syscall.c          |  20 +-
>  tools/perf/tests/parse-events.c            | 492 +++++++++++----------
>  tools/perf/tests/perf-record.c             |  18 +-
>  tools/perf/tests/vmlinux-kallsyms.c        |  12 +-
>  7 files changed, 341 insertions(+), 248 deletions(-)
> 
> -- 
> 2.36.0.550.gb090851708-goog

-- 

- Arnaldo