[PATCH -next] powerpc/kaslr_booke: Fix build error

YueHaibing posted 1 patch 3 years, 11 months ago
arch/powerpc/mm/nohash/kaslr_booke.c | 2 ++
1 file changed, 2 insertions(+)
[PATCH -next] powerpc/kaslr_booke: Fix build error
Posted by YueHaibing 3 years, 11 months ago
arch/powerpc/mm/nohash/kaslr_booke.c: In function ‘kaslr_get_cmdline’:
arch/powerpc/mm/nohash/kaslr_booke.c:46:2: error: implicit declaration of function ‘early_init_dt_scan_chosen’; did you mean ‘early_init_mmu_secondary’? [-Werror=implicit-function-declaration]
  early_init_dt_scan_chosen(boot_command_line);
  ^~~~~~~~~~~~~~~~~~~~~~~~~
  early_init_mmu_secondary
arch/powerpc/mm/nohash/kaslr_booke.c: In function ‘get_initrd_range’:
arch/powerpc/mm/nohash/kaslr_booke.c:210:10: error: implicit declaration of function ‘of_read_number’; did you mean ‘seq_read_iter’? [-Werror=implicit-function-declaration]
  start = of_read_number(prop, len / 4);
          ^~~~~~~~~~~~~~
          seq_read_iter

Add missing include files to fix this.

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 arch/powerpc/mm/nohash/kaslr_booke.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/powerpc/mm/nohash/kaslr_booke.c b/arch/powerpc/mm/nohash/kaslr_booke.c
index 5da604cd2be6..1f3f9fedf1bc 100644
--- a/arch/powerpc/mm/nohash/kaslr_booke.c
+++ b/arch/powerpc/mm/nohash/kaslr_booke.c
@@ -14,6 +14,8 @@
 #include <linux/memblock.h>
 #include <linux/libfdt.h>
 #include <linux/crash_core.h>
+#include <linux/of.h>
+#include <linux/of_fdt.h>
 #include <asm/cacheflush.h>
 #include <asm/kdump.h>
 #include <mm/mmu_decl.h>
-- 
2.17.1

Re: [PATCH -next] powerpc/kaslr_booke: Fix build error
Posted by Michael Ellerman 3 years, 11 months ago
On Tue, 17 May 2022 17:49:00 +0800, YueHaibing wrote:
> arch/powerpc/mm/nohash/kaslr_booke.c: In function ‘kaslr_get_cmdline’:
> arch/powerpc/mm/nohash/kaslr_booke.c:46:2: error: implicit declaration of function ‘early_init_dt_scan_chosen’; did you mean ‘early_init_mmu_secondary’? [-Werror=implicit-function-declaration]
>   early_init_dt_scan_chosen(boot_command_line);
>   ^~~~~~~~~~~~~~~~~~~~~~~~~
>   early_init_mmu_secondary
> arch/powerpc/mm/nohash/kaslr_booke.c: In function ‘get_initrd_range’:
> arch/powerpc/mm/nohash/kaslr_booke.c:210:10: error: implicit declaration of function ‘of_read_number’; did you mean ‘seq_read_iter’? [-Werror=implicit-function-declaration]
>   start = of_read_number(prop, len / 4);
>           ^~~~~~~~~~~~~~
>           seq_read_iter
> 
> [...]

Applied to powerpc/next.

[1/1] powerpc/kaslr_booke: Fix build error
      https://git.kernel.org/powerpc/c/cdf87d2bd12cf3ea760a1fa35907a31e5177f425

cheers