[PATCH] st/cw1200: cleanup the code a bit

Bernard Zhao posted 1 patch 3 years, 11 months ago
drivers/net/wireless/st/cw1200/bh.c | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
[PATCH] st/cw1200: cleanup the code a bit
Posted by Bernard Zhao 3 years, 11 months ago
Delete if NULL check before dev_kfree_skb call.
This change is to cleanup the code a bit.

Signed-off-by: Bernard Zhao <bernard@vivo.com>
---
 drivers/net/wireless/st/cw1200/bh.c | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/drivers/net/wireless/st/cw1200/bh.c b/drivers/net/wireless/st/cw1200/bh.c
index 10e019cddcc6..3b4ded2ac801 100644
--- a/drivers/net/wireless/st/cw1200/bh.c
+++ b/drivers/net/wireless/st/cw1200/bh.c
@@ -327,18 +327,12 @@ static int cw1200_bh_rx_helper(struct cw1200_common *priv,
 	if (WARN_ON(wsm_handle_rx(priv, wsm_id, wsm, &skb_rx)))
 		goto err;
 
-	if (skb_rx) {
-		dev_kfree_skb(skb_rx);
-		skb_rx = NULL;
-	}
+	dev_kfree_skb(skb_rx);
 
 	return 0;
 
 err:
-	if (skb_rx) {
-		dev_kfree_skb(skb_rx);
-		skb_rx = NULL;
-	}
+	dev_kfree_skb(skb_rx);
 	return -1;
 }
 
-- 
2.33.1
Re: wifi: cw1200: cleanup the code a bit
Posted by Kalle Valo 3 years, 11 months ago
Bernard Zhao <bernard@vivo.com> wrote:

> Delete if NULL check before dev_kfree_skb call.
> This change is to cleanup the code a bit.
> 
> Signed-off-by: Bernard Zhao <bernard@vivo.com>

Patch applied to wireless-next.git, thanks.

d092de2c28dc wifi: cw1200: cleanup the code a bit

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20220517014136.410450-1-bernard@vivo.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches