[PATCH 0/3] staging: r8188eu: fix checkpatch.pl warnings

Vihas Makwana posted 3 patches 3 years, 11 months ago
drivers/staging/r8188eu/core/rtw_p2p.c       |  8 ++++----
drivers/staging/r8188eu/core/rtw_pwrctrl.c   | 12 ++++++------
drivers/staging/r8188eu/core/rtw_wlan_util.c |  2 +-
3 files changed, 11 insertions(+), 11 deletions(-)
[PATCH 0/3] staging: r8188eu: fix checkpatch.pl warnings
Posted by Vihas Makwana 3 years, 11 months ago
This patchset fixes following checkpatch warning:
    WARNING: Comparisons should place the constant on the right side of the test

Compiled tested only.

Vihas Makwana (3):
  staging: r8188eu: fix checkpatch warnings in rtw_p2p
  staging: r8188eu: fix checkpatch warnings in rtw_pwrctrl
  staging: r8188eu: fix checkpatch warnings in rtw_wlan_util

 drivers/staging/r8188eu/core/rtw_p2p.c       |  8 ++++----
 drivers/staging/r8188eu/core/rtw_pwrctrl.c   | 12 ++++++------
 drivers/staging/r8188eu/core/rtw_wlan_util.c |  2 +-
 3 files changed, 11 insertions(+), 11 deletions(-)

-- 
2.30.2
Re: [PATCH 0/3] staging: r8188eu: fix checkpatch.pl warnings
Posted by Pavel Skripkin 3 years, 11 months ago
Hi Vihas,

On 5/16/22 20:03, Vihas Makwana wrote:
> This patchset fixes following checkpatch warning:
>      WARNING: Comparisons should place the constant on the right side of the test
> 
> Compiled tested only.
> 
> Vihas Makwana (3):
>    staging: r8188eu: fix checkpatch warnings in rtw_p2p
>    staging: r8188eu: fix checkpatch warnings in rtw_pwrctrl
>    staging: r8188eu: fix checkpatch warnings in rtw_wlan_util
> 
>   drivers/staging/r8188eu/core/rtw_p2p.c       |  8 ++++----
>   drivers/staging/r8188eu/core/rtw_pwrctrl.c   | 12 ++++++------
>   drivers/staging/r8188eu/core/rtw_wlan_util.c |  2 +-
>   3 files changed, 11 insertions(+), 11 deletions(-)
> 
checkpatch warns about the subjects. See an example for 1/3, but it's 
related to all 3.

> WARNING: A patch subject line should describe the change not the tool that found it
> #4: 
> Subject: [PATCH 1/3] staging: r8188eu: fix checkpatch.pl warnings in rtw_p2p
> 
> total: 0 errors, 1 warnings, 0 checks, 32 lines checked




With regards,
Pavel Skripkin