Input: Remove unneeded NULL check before clk_disable_unprepare

[PATCH] Input: Remove unneeded NULL check before clk_disable_unprepare

Wan Jiabing posted 1 patch 4 years ago

Download mbox

drivers/input/keyboard/bcm-keypad.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

Expand all Fold all

[PATCH] Input: Remove unneeded NULL check before clk_disable_unprepare

Posted by Wan Jiabing 4 years ago

clk_disable_unprepare() already checks NULL by using IS_ERR_OR_NULL.
Remove unneeded NULL check for kp->clk.

Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
 drivers/input/keyboard/bcm-keypad.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/input/keyboard/bcm-keypad.c b/drivers/input/keyboard/bcm-keypad.c
index 2b771c3a5578..166d6023a538 100644
--- a/drivers/input/keyboard/bcm-keypad.c
+++ b/drivers/input/keyboard/bcm-keypad.c
@@ -183,8 +183,7 @@ static void bcm_kp_stop(const struct bcm_kp *kp)
 	writel(0xFFFFFFFF, kp->base + KPICR0_OFFSET);
 	writel(0xFFFFFFFF, kp->base + KPICR1_OFFSET);
 
-	if (kp->clk)
-		clk_disable_unprepare(kp->clk);
+	clk_disable_unprepare(kp->clk);
 }
 
 static int bcm_kp_open(struct input_dev *dev)
-- 
2.36.1

Re: [PATCH] Input: Remove unneeded NULL check before clk_disable_unprepare

Posted by Dmitry Torokhov 4 years ago

On Mon, May 16, 2022 at 04:55:09PM +0800, Wan Jiabing wrote:
> clk_disable_unprepare() already checks NULL by using IS_ERR_OR_NULL.
> Remove unneeded NULL check for kp->clk.
> 
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>

Applied, thank you.

-- 
Dmitry