[PATCH 0/7] iommu/vt-d: Make intel-iommu.h private

Lu Baolu posted 7 patches 1 week, 3 days ago
include/linux/tboot.h                         |  2 --
drivers/gpu/drm/i915/i915_drv.h               |  1 -
.../iommu/intel/iommu.h                       |  1 -
.../iommu/intel/trace.h                       |  7 +++++-
arch/x86/kernel/tboot.c                       | 15 -------------
arch/x86/kvm/x86.c                            |  1 -
drivers/char/agp/intel-gtt.c                  | 17 ++++++--------
drivers/gpu/drm/i915/display/intel_display.c  |  1 -
.../gpu/drm/i915/gem/i915_gem_execbuffer.c    |  1 -
drivers/iommu/intel/cap_audit.c               |  2 +-
drivers/iommu/intel/debugfs.c                 |  2 +-
drivers/iommu/intel/dmar.c                    |  4 ++--
drivers/iommu/intel/iommu.c                   | 22 +++++++++++++------
drivers/iommu/intel/irq_remapping.c           |  2 +-
drivers/iommu/intel/pasid.c                   |  2 +-
drivers/iommu/intel/perf.c                    |  2 +-
drivers/iommu/intel/svm.c                     |  4 ++--
drivers/iommu/intel/trace.c                   |  2 +-
MAINTAINERS                                   |  1 -
19 files changed, 38 insertions(+), 51 deletions(-)
rename include/linux/intel-iommu.h => drivers/iommu/intel/iommu.h (99%)
rename include/trace/events/intel_iommu.h => drivers/iommu/intel/trace.h (93%)
[PATCH 0/7] iommu/vt-d: Make intel-iommu.h private
Posted by Lu Baolu 1 week, 3 days ago
Hi folks,

The include/linux/intel-iommu.h should be private to the Intel IOMMU
driver. Other drivers or components should interact with the IOMMU
drivers through the kAPIs provided by the iommu core.

This series cleanups all includes of intel-iommu.h outside of the Intel
IOMMU driver and move this header from include/linux to
drivers/iommu/intel/.

No functional changes intended. Please help to review and suggest.

Best regards,
baolu

Lu Baolu (7):
  iommu/vt-d: Move trace/events/intel_iommu.h under iommu
  agp/intel: Use per device iommu check
  iommu/vt-d: Remove unnecessary exported symbol
  drm/i915: Remove unnecessary include
  KVM: x86: Remove unnecessary include
  x86/boot/tboot: Move tboot_force_iommu() to Intel IOMMU
  iommu/vt-d: Move include/linux/intel_iommu.h under iommu

 include/linux/tboot.h                         |  2 --
 drivers/gpu/drm/i915/i915_drv.h               |  1 -
 .../iommu/intel/iommu.h                       |  1 -
 .../iommu/intel/trace.h                       |  7 +++++-
 arch/x86/kernel/tboot.c                       | 15 -------------
 arch/x86/kvm/x86.c                            |  1 -
 drivers/char/agp/intel-gtt.c                  | 17 ++++++--------
 drivers/gpu/drm/i915/display/intel_display.c  |  1 -
 .../gpu/drm/i915/gem/i915_gem_execbuffer.c    |  1 -
 drivers/iommu/intel/cap_audit.c               |  2 +-
 drivers/iommu/intel/debugfs.c                 |  2 +-
 drivers/iommu/intel/dmar.c                    |  4 ++--
 drivers/iommu/intel/iommu.c                   | 22 +++++++++++++------
 drivers/iommu/intel/irq_remapping.c           |  2 +-
 drivers/iommu/intel/pasid.c                   |  2 +-
 drivers/iommu/intel/perf.c                    |  2 +-
 drivers/iommu/intel/svm.c                     |  4 ++--
 drivers/iommu/intel/trace.c                   |  2 +-
 MAINTAINERS                                   |  1 -
 19 files changed, 38 insertions(+), 51 deletions(-)
 rename include/linux/intel-iommu.h => drivers/iommu/intel/iommu.h (99%)
 rename include/trace/events/intel_iommu.h => drivers/iommu/intel/trace.h (93%)

-- 
2.25.1
Re: [PATCH 0/7] iommu/vt-d: Make intel-iommu.h private
Posted by Christoph Hellwig 1 week ago
On Sat, May 14, 2022 at 09:43:15AM +0800, Lu Baolu wrote:
> Hi folks,
> 
> The include/linux/intel-iommu.h should be private to the Intel IOMMU
> driver. Other drivers or components should interact with the IOMMU
> drivers through the kAPIs provided by the iommu core.
> 
> This series cleanups all includes of intel-iommu.h outside of the Intel
> IOMMU driver and move this header from include/linux to
> drivers/iommu/intel/.
> 
> No functional changes intended. Please help to review and suggest.

Thanks, this was long overdue!

The series looks good to me:

Reviewed-by: Christoph Hellwig <hch@lst.de>
Re: [PATCH 0/7] iommu/vt-d: Make intel-iommu.h private
Posted by Steve Wahl 5 days, 10 hours ago
On Sat, May 14, 2022 at 09:43:15AM +0800, Lu Baolu wrote:
> Hi folks,
> 
> The include/linux/intel-iommu.h should be private to the Intel IOMMU
> driver. Other drivers or components should interact with the IOMMU
> drivers through the kAPIs provided by the iommu core.
> 
> This series cleanups all includes of intel-iommu.h outside of the Intel
> IOMMU driver and move this header from include/linux to
> drivers/iommu/intel/.
> 
> No functional changes intended. Please help to review and suggest.

I went through and examined the changes as well.  These changes make the
robots complaint against my patch go away, which is great by me!

Reviewed-by: Steve Wahl <steve.wahl@hpe.com>

-- 
Steve Wahl, Hewlett Packard Enterprise