power: supply: ab8500: add missing destroy_workqueue in ab8500_charger_bind

[PATCH -next] power: supply: ab8500: add missing destroy_workqueue in ab8500_charger_bind

Posted by Zheng Bin 3 years, 12 months ago

ab8500_charger_bind misses destroy_workqueue in error path,
this patch fixes that.

Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
---
 drivers/power/supply/ab8500_charger.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/power/supply/ab8500_charger.c b/drivers/power/supply/ab8500_charger.c
index d04d087caa50..a5d055a628e7 100644
--- a/drivers/power/supply/ab8500_charger.c
+++ b/drivers/power/supply/ab8500_charger.c
@@ -3378,6 +3378,7 @@ static int ab8500_charger_bind(struct device *dev)
 	ret = component_bind_all(dev, di);
 	if (ret) {
 		dev_err(dev, "can't bind component devices\n");
+		destroy_workqueue(di->charger_wq);
 		return ret;
 	}

--
2.31.1

Re: [PATCH -next] power: supply: ab8500: add missing destroy_workqueue in ab8500_charger_bind

Posted by Sebastian Reichel 3 years, 11 months ago

Hi,

On Thu, May 12, 2022 at 05:38:44PM +0800, Zheng Bin wrote:
> ab8500_charger_bind misses destroy_workqueue in error path,
> this patch fixes that.
> 
> Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
> ---

LGTM, but adding Linus to Cc and waiting a bit to give him time to
react.

-- Sebastian

>  drivers/power/supply/ab8500_charger.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/power/supply/ab8500_charger.c b/drivers/power/supply/ab8500_charger.c
> index d04d087caa50..a5d055a628e7 100644
> --- a/drivers/power/supply/ab8500_charger.c
> +++ b/drivers/power/supply/ab8500_charger.c
> @@ -3378,6 +3378,7 @@ static int ab8500_charger_bind(struct device *dev)
>  	ret = component_bind_all(dev, di);
>  	if (ret) {
>  		dev_err(dev, "can't bind component devices\n");
> +		destroy_workqueue(di->charger_wq);
>  		return ret;
>  	}
> 
> --
> 2.31.1
>

Re: [PATCH -next] power: supply: ab8500: add missing destroy_workqueue in ab8500_charger_bind

Posted by Linus Walleij 3 years, 10 months ago

On Fri, Jun 10, 2022 at 12:22 AM Sebastian Reichel
<sebastian.reichel@collabora.com> wrote:
> On Thu, May 12, 2022 at 05:38:44PM +0800, Zheng Bin wrote:
> > ab8500_charger_bind misses destroy_workqueue in error path,
> > this patch fixes that.
> >
> > Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
> > ---
>
> LGTM, but adding Linus to Cc and waiting a bit to give him time to
> react.

Don't have the original patch in my inbox so can't test it, but looks
reasonable so:
Acked-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

Re: [PATCH -next] power: supply: ab8500: add missing destroy_workqueue in ab8500_charger_bind

Posted by Sebastian Reichel 3 years, 9 months ago

Hi,

On Thu, Jun 23, 2022 at 04:20:52PM +0200, Linus Walleij wrote:
> On Fri, Jun 10, 2022 at 12:22 AM Sebastian Reichel
> <sebastian.reichel@collabora.com> wrote:
> > On Thu, May 12, 2022 at 05:38:44PM +0800, Zheng Bin wrote:
> > > ab8500_charger_bind misses destroy_workqueue in error path,
> > > this patch fixes that.
> > >
> > > Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
> > > ---
> >
> > LGTM, but adding Linus to Cc and waiting a bit to give him time to
> > react.
> 
> Don't have the original patch in my inbox so can't test it, but looks
> reasonable so:
> Acked-by: Linus Walleij <linus.walleij@linaro.org>

Thanks, queued.

-- Sebastian

Re: [PATCH -next] power: supply: ab8500: add missing destroy_workqueue in ab8500_charger_bind

Posted by Zhengbin (OSKernel) 3 years, 10 months ago

On 2022/6/10 6:22, Sebastian Reichel wrote:
> Hi,
>
> On Thu, May 12, 2022 at 05:38:44PM +0800, Zheng Bin wrote:
>> ab8500_charger_bind misses destroy_workqueue in error path,
>> this patch fixes that.
>>
>> Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
>> ---
> LGTM, but adding Linus to Cc and waiting a bit to give him time to
> react.
>
> -- Sebastian
ping
>
>>   drivers/power/supply/ab8500_charger.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/power/supply/ab8500_charger.c b/drivers/power/supply/ab8500_charger.c
>> index d04d087caa50..a5d055a628e7 100644
>> --- a/drivers/power/supply/ab8500_charger.c
>> +++ b/drivers/power/supply/ab8500_charger.c
>> @@ -3378,6 +3378,7 @@ static int ab8500_charger_bind(struct device *dev)
>>   	ret = component_bind_all(dev, di);
>>   	if (ret) {
>>   		dev_err(dev, "can't bind component devices\n");
>> +		destroy_workqueue(di->charger_wq);
>>   		return ret;
>>   	}
>>
>> --
>> 2.31.1
>>

Re: [PATCH -next] power: supply: ab8500: add missing destroy_workqueue in ab8500_charger_bind

Posted by Zhengbin (OSKernel) 3 years, 11 months ago

friendly ping

On 2022/5/12 17:38, Zheng Bin wrote:
> ab8500_charger_bind misses destroy_workqueue in error path,
> this patch fixes that.
>
> Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
> ---
>   drivers/power/supply/ab8500_charger.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/power/supply/ab8500_charger.c b/drivers/power/supply/ab8500_charger.c
> index d04d087caa50..a5d055a628e7 100644
> --- a/drivers/power/supply/ab8500_charger.c
> +++ b/drivers/power/supply/ab8500_charger.c
> @@ -3378,6 +3378,7 @@ static int ab8500_charger_bind(struct device *dev)
>   	ret = component_bind_all(dev, di);
>   	if (ret) {
>   		dev_err(dev, "can't bind component devices\n");
> +		destroy_workqueue(di->charger_wq);
>   		return ret;
>   	}
>
> --
> 2.31.1
>
> .
>