[PATCH 0/2] Fix poll bug

Dylan Yudaken posted 2 patches 3 years, 12 months ago
fs/io_uring.c                   | 5 +++--
include/trace/events/io_uring.h | 2 +-
2 files changed, 4 insertions(+), 3 deletions(-)
[PATCH 0/2] Fix poll bug
Posted by Dylan Yudaken 3 years, 12 months ago
Hi,

This fixes a bug in poll wakeups, where it would wake up
unnecessarily. This is most obvious with sockets, where the socket will
wake both readers and writers when new read data is available, even if the
socket is still not writable.

Patch 1 is a simple bug I noticed while debugging the poll problem
Patch 2 is the poll fix

Dylan Yudaken (2):
  io_uring: fix ordering of args in io_uring_queue_async_work
  io_uring: only wake when the correct events are set

 fs/io_uring.c                   | 5 +++--
 include/trace/events/io_uring.h | 2 +-
 2 files changed, 4 insertions(+), 3 deletions(-)


base-commit: f569add47119fa910ed7711b26b8d38e21f7ea77
-- 
2.30.2
Re: [PATCH 0/2] Fix poll bug
Posted by Jens Axboe 3 years, 12 months ago
On Thu, 12 May 2022 02:18:32 -0700, Dylan Yudaken wrote:
> This fixes a bug in poll wakeups, where it would wake up
> unnecessarily. This is most obvious with sockets, where the socket will
> wake both readers and writers when new read data is available, even if the
> socket is still not writable.
> 
> Patch 1 is a simple bug I noticed while debugging the poll problem
> Patch 2 is the poll fix
> 
> [...]

Applied, thanks!

[1/2] io_uring: fix ordering of args in io_uring_queue_async_work
      commit: 2d2d5cb6ca8424fa849ebb4edb8e8022c13860c7
[2/2] io_uring: only wake when the correct events are set
      commit: beed4eed5fc1fe18f2b78b214450e28d786c1e49

Best regards,
-- 
Jens Axboe