Refix the socket leak in xs_setup_local()

[PATCH 0/3] Refix the socket leak in xs_setup_local()

Posted by Wang Hai 4 years, 1 month ago

Patch1 and patch2 roll back the wrong solution to fix socket leaks.

Patch3 adds safe teardown mechanism to re-fix socket leaks.

Wang Hai (3):
  Revert "SUNRPC: Ensure gss-proxy connects on setup"
  Revert "Revert "SUNRPC: attempt AF_LOCAL connect on setup""
  SUNRPC: Fix local socket leak in xs_setup_local()

 include/linux/sunrpc/clnt.h          |  1 -
 net/sunrpc/auth_gss/gss_rpc_upcall.c |  2 +-
 net/sunrpc/clnt.c                    |  3 ---
 net/sunrpc/xprtsock.c                | 19 ++++++++++++++++++-
 4 files changed, 19 insertions(+), 6 deletions(-)

-- 
2.17.1

Re: [PATCH 0/3] Refix the socket leak in xs_setup_local()

Posted by Trond Myklebust 4 years, 1 month ago

On Wed, 2022-05-11 at 21:22 +0800, Wang Hai wrote:
> Patch1 and patch2 roll back the wrong solution to fix socket leaks.
> 
> Patch3 adds safe teardown mechanism to re-fix socket leaks.
> 
> Wang Hai (3):
>   Revert "SUNRPC: Ensure gss-proxy connects on setup"
>   Revert "Revert "SUNRPC: attempt AF_LOCAL connect on setup""
>   SUNRPC: Fix local socket leak in xs_setup_local()
> 
>  include/linux/sunrpc/clnt.h          |  1 -
>  net/sunrpc/auth_gss/gss_rpc_upcall.c |  2 +-
>  net/sunrpc/clnt.c                    |  3 ---
>  net/sunrpc/xprtsock.c                | 19 ++++++++++++++++++-
>  4 files changed, 19 insertions(+), 6 deletions(-)
> 

Thanks, but there is already a fix for this queued up in the linux-next
branch.

-- 
Trond Myklebust
Linux NFS client maintainer, Hammerspace
trond.myklebust@hammerspace.com

Re: [PATCH 0/3] Refix the socket leak in xs_setup_local()

Posted by wanghai (M) 4 years, 1 month ago

在 2022/5/12 0:14, Trond Myklebust 写道:
> On Wed, 2022-05-11 at 21:22 +0800, Wang Hai wrote:
>> Patch1 and patch2 roll back the wrong solution to fix socket leaks.
>>
>> Patch3 adds safe teardown mechanism to re-fix socket leaks.
>>
>> Wang Hai (3):
>>    Revert "SUNRPC: Ensure gss-proxy connects on setup"
>>    Revert "Revert "SUNRPC: attempt AF_LOCAL connect on setup""
>>    SUNRPC: Fix local socket leak in xs_setup_local()
>>
>>   include/linux/sunrpc/clnt.h          |  1 -
>>   net/sunrpc/auth_gss/gss_rpc_upcall.c |  2 +-
>>   net/sunrpc/clnt.c                    |  3 ---
>>   net/sunrpc/xprtsock.c                | 19 ++++++++++++++++++-
>>   4 files changed, 19 insertions(+), 6 deletions(-)
>>
> Thanks, but there is already a fix for this queued up in the linux-next
> branch.
Thanks, sorry to bother you, I found it.

I only subscribed to the linux-kernel@vger.kernel.org mailing list,
not the linux-nfs@vger.kernel.org mailing list separately. So I
didn't notice it was fixed.

-- 
Wang Hai