[PATCH v2] drivers: dio: add missing iounmap() in dio_init()

Yang Yingliang posted 1 patch 4 years, 1 month ago
drivers/dio/dio.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
[PATCH v2] drivers: dio: add missing iounmap() in dio_init()
Posted by Yang Yingliang 4 years, 1 month ago
If kzalloc() fails, iounmap() need be called in error path.

Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
v2:
  make the title and commit message more properly.
---
 drivers/dio/dio.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/dio/dio.c b/drivers/dio/dio.c
index 005a82f671c3..0e5a5662d5a4 100644
--- a/drivers/dio/dio.c
+++ b/drivers/dio/dio.c
@@ -216,8 +216,11 @@ static int __init dio_init(void)
 
 		/* Found a board, allocate it an entry in the list */
 		dev = kzalloc(sizeof(struct dio_dev), GFP_KERNEL);
-		if (!dev)
+		if (!dev) {
+			if (scode >= DIOII_SCBASE)
+				iounmap(va);
 			return -ENOMEM;
+		}
 
 		dev->bus = &dio_bus;
 		dev->dev.parent = &dio_bus.dev;
-- 
2.25.1