[PATCH] hwmon: (lm83) Remove unused include directives

Karl Mehltretter posted 1 patch 3 years, 12 months ago
drivers/hwmon/lm83.c | 2 --
1 file changed, 2 deletions(-)
[PATCH] hwmon: (lm83) Remove unused include directives
Posted by Karl Mehltretter 3 years, 12 months ago
Some include directives are no longer necessary due to previous driver
changes. Remove them now to further improve driver code clarity.

Mutex usage has ceased since commit 719af4f1a40b ("hwmon: (lm83) Use
regmap").

Ever since commit a0ac840d99fa ("hwmon: (lm83) Convert to use
devm_hwmon_device_register_with_groups") functions sysfs_create_group
and sysfs_remove_group are no longer used by the driver.

Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
---
 drivers/hwmon/lm83.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/hwmon/lm83.c b/drivers/hwmon/lm83.c
index 12370dcef..905f5689f 100644
--- a/drivers/hwmon/lm83.c
+++ b/drivers/hwmon/lm83.c
@@ -24,10 +24,8 @@
 #include <linux/init.h>
 #include <linux/hwmon.h>
 #include <linux/module.h>
-#include <linux/mutex.h>
 #include <linux/regmap.h>
 #include <linux/slab.h>
-#include <linux/sysfs.h>
 
 /*
  * Addresses to scan
-- 
2.20.1
Re: [PATCH] hwmon: (lm83) Remove unused include directives
Posted by Guenter Roeck 3 years, 12 months ago
On Sun, May 08, 2022 at 04:46:01PM +0200, Karl Mehltretter wrote:
> Some include directives are no longer necessary due to previous driver
> changes. Remove them now to further improve driver code clarity.
> 
> Mutex usage has ceased since commit 719af4f1a40b ("hwmon: (lm83) Use
> regmap").
> 
> Ever since commit a0ac840d99fa ("hwmon: (lm83) Convert to use
> devm_hwmon_device_register_with_groups") functions sysfs_create_group
> and sysfs_remove_group are no longer used by the driver.
> 
> Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>

Applied. Thanks!

Guenter

> ---
>  drivers/hwmon/lm83.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/hwmon/lm83.c b/drivers/hwmon/lm83.c
> index 12370dcef..905f5689f 100644
> --- a/drivers/hwmon/lm83.c
> +++ b/drivers/hwmon/lm83.c
> @@ -24,10 +24,8 @@
>  #include <linux/init.h>
>  #include <linux/hwmon.h>
>  #include <linux/module.h>
> -#include <linux/mutex.h>
>  #include <linux/regmap.h>
>  #include <linux/slab.h>
> -#include <linux/sysfs.h>
>  
>  /*
>   * Addresses to scan