arch/mips/sibyte/bcm1480/setup.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
Fix the following coccicheck warning:
arch/mips/sibyte/bcm1480/setup.c:37:5-8: Unneeded variable: "ret".
Return "0" on line 67.
Signed-off-by: Guo Zhengkui <guozhengkui@vivo.com>
---
arch/mips/sibyte/bcm1480/setup.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/arch/mips/sibyte/bcm1480/setup.c b/arch/mips/sibyte/bcm1480/setup.c
index 6f34b871b08e..e3e807046a9c 100644
--- a/arch/mips/sibyte/bcm1480/setup.c
+++ b/arch/mips/sibyte/bcm1480/setup.c
@@ -34,8 +34,6 @@ static char *pass_str;
static int __init setup_bcm1x80_bcm1x55(void)
{
- int ret = 0;
-
switch (soc_pass) {
case K_SYS_REVISION_BCM1480_S0:
periph_rev = 1;
@@ -64,7 +62,7 @@ static int __init setup_bcm1x80_bcm1x55(void)
break;
}
- return ret;
+ return 0;
}
/* Setup code likely to be common to all SiByte platforms */
--
2.20.1
On Thu, May 05, 2022 at 11:01:14AM +0800, Guo Zhengkui wrote:
> Fix the following coccicheck warning:
>
> arch/mips/sibyte/bcm1480/setup.c:37:5-8: Unneeded variable: "ret".
> Return "0" on line 67.
>
> Signed-off-by: Guo Zhengkui <guozhengkui@vivo.com>
> ---
> arch/mips/sibyte/bcm1480/setup.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/arch/mips/sibyte/bcm1480/setup.c b/arch/mips/sibyte/bcm1480/setup.c
> index 6f34b871b08e..e3e807046a9c 100644
> --- a/arch/mips/sibyte/bcm1480/setup.c
> +++ b/arch/mips/sibyte/bcm1480/setup.c
> @@ -34,8 +34,6 @@ static char *pass_str;
>
> static int __init setup_bcm1x80_bcm1x55(void)
> {
> - int ret = 0;
> -
> switch (soc_pass) {
> case K_SYS_REVISION_BCM1480_S0:
> periph_rev = 1;
> @@ -64,7 +62,7 @@ static int __init setup_bcm1x80_bcm1x55(void)
> break;
> }
>
> - return ret;
> + return 0;
> }
>
> /* Setup code likely to be common to all SiByte platforms */
> --
> 2.20.1
applied to mips-next.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
© 2016 - 2026 Red Hat, Inc.