[PATCH v4 0/2] sched/core: Avoid obvious double update_rq_clock warning

Hao Jia posted 2 patches 4 years ago
kernel/sched/core.c     |  6 +++---
kernel/sched/deadline.c | 13 ++++---------
kernel/sched/rt.c       |  5 +++--
kernel/sched/sched.h    | 28 ++++++++++++++++++++++++----
4 files changed, 34 insertions(+), 18 deletions(-)
[PATCH v4 0/2] sched/core: Avoid obvious double update_rq_clock warning
Posted by Hao Jia 4 years ago
These two patches are about the kernel scheduler:

patch 1: fixed the issue that kernel may trigger WARN_DOUBLE_CLOCK warning.
patch 2: removed some no longer needed comments in the deadline scheduler
and cleaned up the code.

Thanks for suggestion from Dietmar Eggemann & Peter Zijlstra.

v3->v4:
   - Modify some code formats and commit messages.
   - Add Reviewed-by: Dietmar Eggemann <dietmar.eggemann@arm.com> for
     patch 1.
   - Add Reviewed-by: Daniel Bristot de Oliveira <bristot@redhat.com>
     for patch 2.

v2->v3:
   - Modify some descriptions and errors in the commit information.
   - Fixed a bug that might trigger the WARN_DOUBLE_CLOCK warning in
     migrate_task_rq_dl().
   - Add Reviewed-by: Dietmar Eggemann <dietmar.eggemann@arm.com> for
     patch 2.

v1->v2:
   - Added double_rq_clock_clear_update inline helper to clear RQCF_UPDATED
     of rq->clock_update_flags.
   - split into two separate patches.

[v1] https://lore.kernel.org/lkml/20220418090929.54005-1-jiahao.os@bytedance.com/
[v2] https://lore.kernel.org/lkml/20220422090944.52618-1-jiahao.os@bytedance.com/
[v3] https://lore.kernel.org/all/20220427080014.18483-1-jiahao.os@bytedance.com/

Hao Jia (2):
  sched/core: Avoid obvious double update_rq_clock warning
  sched/deadline: Remove superfluous rq clock update in push_dl_task()

 kernel/sched/core.c     |  6 +++---
 kernel/sched/deadline.c | 13 ++++---------
 kernel/sched/rt.c       |  5 +++--
 kernel/sched/sched.h    | 28 ++++++++++++++++++++++++----
 4 files changed, 34 insertions(+), 18 deletions(-)

-- 
2.32.0
Re: [PATCH v4 0/2] sched/core: Avoid obvious double update_rq_clock warning
Posted by Hao Jia 4 years ago
Friendly ping...

Hi Dietmar Eggemann & Peter Zijlstra,
If you have time, please review these two patches.

On 2022/4/30 Hao Jia wrote:
> These two patches are about the kernel scheduler:
> 
> patch 1: fixed the issue that kernel may trigger WARN_DOUBLE_CLOCK warning.
> patch 2: removed some no longer needed comments in the deadline scheduler
> and cleaned up the code.
> 
> Thanks for suggestion from Dietmar Eggemann & Peter Zijlstra.
> 
> v3->v4:
>     - Modify some code formats and commit messages.
>     - Add Reviewed-by: Dietmar Eggemann <dietmar.eggemann@arm.com> for
>       patch 1.
>     - Add Reviewed-by: Daniel Bristot de Oliveira <bristot@redhat.com>
>       for patch 2.
> 
> v2->v3:
>     - Modify some descriptions and errors in the commit information.
>     - Fixed a bug that might trigger the WARN_DOUBLE_CLOCK warning in
>       migrate_task_rq_dl().
>     - Add Reviewed-by: Dietmar Eggemann <dietmar.eggemann@arm.com> for
>       patch 2.
> 
> v1->v2:
>     - Added double_rq_clock_clear_update inline helper to clear RQCF_UPDATED
>       of rq->clock_update_flags.
>     - split into two separate patches.
> 
> [v1] https://lore.kernel.org/lkml/20220418090929.54005-1-jiahao.os@bytedance.com/
> [v2] https://lore.kernel.org/lkml/20220422090944.52618-1-jiahao.os@bytedance.com/
> [v3] https://lore.kernel.org/all/20220427080014.18483-1-jiahao.os@bytedance.com/
> 
> Hao Jia (2):
>    sched/core: Avoid obvious double update_rq_clock warning
>    sched/deadline: Remove superfluous rq clock update in push_dl_task()
> 
>   kernel/sched/core.c     |  6 +++---
>   kernel/sched/deadline.c | 13 ++++---------
>   kernel/sched/rt.c       |  5 +++--
>   kernel/sched/sched.h    | 28 ++++++++++++++++++++++++----
>   4 files changed, 34 insertions(+), 18 deletions(-)
>
Re: [PATCH v4 0/2] sched/core: Avoid obvious double update_rq_clock warning
Posted by Peter Zijlstra 4 years ago
On Mon, May 09, 2022 at 11:16:39AM +0800, Hao Jia wrote:
> Friendly ping...
> 
> Hi Dietmar Eggemann & Peter Zijlstra,
> If you have time, please review these two patches.

I've picked them up, shall push them to tip soonish.

Thanks!