[PATCH] net: ethernet: mediatek: add missing of_node_put() in mtk_sgmii_init()

Yang Yingliang posted 1 patch 2 years, 4 months ago
drivers/net/ethernet/mediatek/mtk_sgmii.c | 1 +
1 file changed, 1 insertion(+)
[PATCH] net: ethernet: mediatek: add missing of_node_put() in mtk_sgmii_init()
Posted by Yang Yingliang 2 years, 4 months ago
The node pointer returned by of_parse_phandle() with refcount incremented,
so add of_node_put() after using it in mtk_sgmii_init().

Fixes: 9ffee4a8276c ("net: ethernet: mediatek: Extend SGMII related functions")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
 drivers/net/ethernet/mediatek/mtk_sgmii.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/mediatek/mtk_sgmii.c b/drivers/net/ethernet/mediatek/mtk_sgmii.c
index 32d83421226a..5897940a418b 100644
--- a/drivers/net/ethernet/mediatek/mtk_sgmii.c
+++ b/drivers/net/ethernet/mediatek/mtk_sgmii.c
@@ -26,6 +26,7 @@ int mtk_sgmii_init(struct mtk_sgmii *ss, struct device_node *r, u32 ana_rgc3)
 			break;
 
 		ss->regmap[i] = syscon_node_to_regmap(np);
+		of_node_put(np);
 		if (IS_ERR(ss->regmap[i]))
 			return PTR_ERR(ss->regmap[i]);
 	}
-- 
2.25.1
Re: [PATCH] net: ethernet: mediatek: add missing of_node_put() in mtk_sgmii_init()
Posted by patchwork-bot+netdevbpf@kernel.org 2 years, 4 months ago
Hello:

This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Thu, 28 Apr 2022 14:25:43 +0800 you wrote:
> The node pointer returned by of_parse_phandle() with refcount incremented,
> so add of_node_put() after using it in mtk_sgmii_init().
> 
> Fixes: 9ffee4a8276c ("net: ethernet: mediatek: Extend SGMII related functions")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
>  drivers/net/ethernet/mediatek/mtk_sgmii.c | 1 +
>  1 file changed, 1 insertion(+)

Here is the summary with links:
  - net: ethernet: mediatek: add missing of_node_put() in mtk_sgmii_init()
    https://git.kernel.org/netdev/net/c/ff5265d45345

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html