[PATCH 4.19 00/53] 4.19.240-rc1 review

Greg Kroah-Hartman posted 53 patches 4 years ago
Makefile                                           |  4 +-
arch/arc/kernel/entry.S                            |  1 +
arch/arm/mach-vexpress/spc.c                       |  2 +-
arch/powerpc/perf/power9-pmu.c                     |  8 +--
arch/x86/include/asm/compat.h                      |  6 +-
block/compat_ioctl.c                               |  2 +-
drivers/ata/pata_marvell.c                         |  2 +
drivers/dma/at_xdmac.c                             | 12 ++--
drivers/dma/imx-sdma.c                             |  4 +-
drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c         |  3 +
.../gpu/drm/panel/panel-raspberrypi-touchscreen.c  | 13 ++++-
drivers/md/dm-integrity.c                          |  7 ++-
drivers/net/can/usb/usb_8dev.c                     | 30 +++++-----
drivers/net/ethernet/cadence/macb_main.c           |  8 +++
drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c |  8 ++-
drivers/net/ethernet/intel/e1000e/ich8lan.c        |  4 +-
drivers/net/ethernet/micrel/Kconfig                |  1 -
drivers/net/vxlan.c                                |  4 +-
.../wireless/broadcom/brcm80211/brcmfmac/sdio.c    |  2 +-
drivers/net/wireless/mediatek/mt76/mt76x2_pci.c    |  2 +-
drivers/perf/arm_pmu.c                             | 10 ++--
drivers/platform/x86/samsung-laptop.c              |  2 -
drivers/reset/tegra/reset-bpmp.c                   |  9 ++-
drivers/staging/android/ion/ion.c                  |  3 +
fs/cifs/cifsfs.c                                   |  2 +-
fs/ext4/inode.c                                    | 11 +++-
fs/ext4/page-io.c                                  |  4 +-
fs/ext4/super.c                                    | 19 ++++--
fs/gfs2/rgrp.c                                     |  9 +--
fs/stat.c                                          | 19 +++---
include/linux/etherdevice.h                        |  5 +-
include/net/ax25.h                                 | 12 ++++
include/net/inet_hashtables.h                      |  5 +-
kernel/trace/trace_events_trigger.c                |  9 ++-
mm/page_alloc.c                                    |  2 +-
net/ax25/af_ax25.c                                 | 38 +++++++++---
net/ax25/ax25_dev.c                                | 28 +++++++--
net/ax25/ax25_route.c                              | 13 ++++-
net/ax25/ax25_subr.c                               | 20 +++++--
net/dccp/ipv4.c                                    |  2 +-
net/dccp/ipv6.c                                    |  2 +-
net/ipv4/inet_connection_sock.c                    |  2 +-
net/ipv4/inet_hashtables.c                         | 68 +++++++++++++++++++---
net/ipv4/tcp_ipv4.c                                | 13 ++++-
net/ipv6/tcp_ipv6.c                                | 13 ++++-
net/netlink/af_netlink.c                           |  7 +++
net/openvswitch/flow_netlink.c                     |  2 +-
net/packet/af_packet.c                             | 13 +++--
net/rxrpc/net_ns.c                                 |  2 +
net/sched/cls_u32.c                                |  8 +--
sound/soc/atmel/sam9g20_wm8731.c                   | 61 -------------------
sound/soc/codecs/msm8916-wcd-digital.c             |  9 ++-
sound/soc/soc-dapm.c                               |  6 +-
sound/usb/midi.c                                   |  1 +
sound/usb/usbaudio.h                               |  2 +-
55 files changed, 359 insertions(+), 195 deletions(-)
[PATCH 4.19 00/53] 4.19.240-rc1 review
Posted by Greg Kroah-Hartman 4 years ago
This is the start of the stable review cycle for the 4.19.240 release.
There are 53 patches in this series, all will be posted as a response
to this one.  If anyone has any issues with these being applied, please
let me know.

Responses should be made by Thu, 28 Apr 2022 08:17:22 +0000.
Anything received after that time might be too late.

The whole patch series can be found in one patch at:
	https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.240-rc1.gz
or in the git tree and branch at:
	git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
and the diffstat can be found below.

thanks,

greg k-h

-------------
Pseudo-Shortlog of commits:

Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Linux 4.19.240-rc1

Marek Vasut <marex@denx.de>
    Revert "net: micrel: fix KS8851_MLL Kconfig"

Duoming Zhou <duoming@zju.edu.cn>
    ax25: Fix UAF bugs in ax25 timers

Duoming Zhou <duoming@zju.edu.cn>
    ax25: Fix NULL pointer dereferences in ax25 timers

Duoming Zhou <duoming@zju.edu.cn>
    ax25: fix NPD bug in ax25_disconnect

Duoming Zhou <duoming@zju.edu.cn>
    ax25: fix UAF bug in ax25_send_control()

Duoming Zhou <duoming@zju.edu.cn>
    ax25: Fix refcount leaks caused by ax25_cb_del()

Duoming Zhou <duoming@zju.edu.cn>
    ax25: fix UAF bugs of net_device caused by rebinding operation

Duoming Zhou <duoming@zju.edu.cn>
    ax25: fix reference count leaks of ax25_dev

Duoming Zhou <duoming@zju.edu.cn>
    ax25: add refcount in ax25_dev to avoid UAF bugs

Khazhismel Kumykov <khazhy@google.com>
    block/compat_ioctl: fix range check in BLKGETSIZE

Lee Jones <lee.jones@linaro.org>
    staging: ion: Prevent incorrect reference counting behavour

Theodore Ts'o <tytso@mit.edu>
    ext4: force overhead calculation if the s_overhead_cluster makes no sense

Theodore Ts'o <tytso@mit.edu>
    ext4: fix overhead calculation to account for the reserved gdt blocks

Tadeusz Struk <tadeusz.struk@linaro.org>
    ext4: limit length to bitmap_maxbytes - blocksize in punch_hole

Ye Bin <yebin10@huawei.com>
    ext4: fix symlink file size not match to file content

Rob Herring <robh@kernel.org>
    arm_pmu: Validate single/group leader events

Sergey Matyukevich <sergey.matyukevich@synopsys.com>
    ARC: entry: fix syscall_trace_exit argument

Sasha Neftin <sasha.neftin@intel.com>
    e1000e: Fix possible overflow in LTR decoding

Xiaomeng Tong <xiam0nd.tong@gmail.com>
    ASoC: soc-dapm: fix two incorrect uses of list iterator

Paolo Valerio <pvalerio@redhat.com>
    openvswitch: fix OOB access in reserve_sfa_size()

Athira Rajeev <atrajeev@linux.vnet.ibm.com>
    powerpc/perf: Fix power9 event alternatives

Dave Stevenson <dave.stevenson@raspberrypi.com>
    drm/panel/raspberrypi-touchscreen: Initialise the bridge in prepare

Dave Stevenson <dave.stevenson@raspberrypi.com>
    drm/panel/raspberrypi-touchscreen: Avoid NULL deref if not initialised

Xiaomeng Tong <xiam0nd.tong@gmail.com>
    dma: at_xdmac: fix a missing check on list iterator

Zheyu Ma <zheyuma97@gmail.com>
    ata: pata_marvell: Check the 'bmdma_addr' beforing reading

Mikulas Patocka <mpatocka@redhat.com>
    stat: fix inconsistency between struct stat and struct compat_stat

Tomas Melin <tomas.melin@vaisala.com>
    net: macb: Restart tx only if queue pointer is lagging

Xiaoke Wang <xkernel.wang@foxmail.com>
    drm/msm/mdp5: check the return of kzalloc()

Lv Ruyi <lv.ruyi@zte.com.cn>
    dpaa_eth: Fix missing of_node_put in dpaa_get_ts_info()

Borislav Petkov <bp@alien8.de>
    brcmfmac: sdio: Fix undefined behavior due to shift overflowing the constant

Borislav Petkov <bp@suse.de>
    mt76: Fix undefined behavior due to shift overflowing the constant

David Howells <dhowells@redhat.com>
    cifs: Check the IOCB_DIRECT flag, not O_DIRECT

Hongbin Wang <wh_bin@126.com>
    vxlan: fix error return code in vxlan_fdb_append

Borislav Petkov <bp@suse.de>
    ALSA: usb-audio: Fix undefined behavior due to shift overflowing the constant

Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
    platform/x86: samsung-laptop: Fix an unsigned comparison which can never be negative

Sameer Pujar <spujar@nvidia.com>
    reset: tegra-bpmp: Restore Handle errors in BPMP response

Kees Cook <keescook@chromium.org>
    ARM: vexpress/spc: Avoid negative array index when !SMP

Eric Dumazet <edumazet@google.com>
    netlink: reset network and mac headers in netlink_dump()

Eric Dumazet <edumazet@google.com>
    net/sched: cls_u32: fix possible leak in u32_init_knode()

Hangbin Liu <liuhangbin@gmail.com>
    net/packet: fix packet_sock xmit return value checking

David Howells <dhowells@redhat.com>
    rxrpc: Restore removed timer deletion

Miaoqian Lin <linmq006@gmail.com>
    dmaengine: imx-sdma: Fix error checking in sdma_event_remap

Miaoqian Lin <linmq006@gmail.com>
    ASoC: msm8916-wcd-digital: Check failure for devm_snd_soc_register_component

Mark Brown <broonie@kernel.org>
    ASoC: atmel: Remove system clock tree configuration for at91sam9g20ek

Kuniyuki Iwashima <kuniyu@amazon.co.jp>
    tcp: Fix potential use-after-free due to double kfree()

Ricardo Dias <rdias@singlestore.com>
    tcp: fix race condition when creating child sockets from syncookies

Takashi Iwai <tiwai@suse.de>
    ALSA: usb-audio: Clear MIDI port active flag after draining

Bob Peterson <rpeterso@redhat.com>
    gfs2: assign rgrp glock before compute_bitstructs

Mikulas Patocka <mpatocka@redhat.com>
    dm integrity: fix memory corruption when tag_size is less than digest size

Hangyu Hua <hbh25y@gmail.com>
    can: usb_8dev: usb_8dev_start_xmit(): fix double dev_kfree_skb() in error path

Daniel Bristot de Oliveira <bristot@kernel.org>
    tracing: Dump stacktrace trigger to the corresponding instance

Xiongwei Song <sxwjean@gmail.com>
    mm: page_alloc: fix building error on -Werror=array-compare

Kees Cook <keescook@chromium.org>
    etherdevice: Adjust ether_addr* prototypes to silence -Wstringop-overead


-------------

Diffstat:

 Makefile                                           |  4 +-
 arch/arc/kernel/entry.S                            |  1 +
 arch/arm/mach-vexpress/spc.c                       |  2 +-
 arch/powerpc/perf/power9-pmu.c                     |  8 +--
 arch/x86/include/asm/compat.h                      |  6 +-
 block/compat_ioctl.c                               |  2 +-
 drivers/ata/pata_marvell.c                         |  2 +
 drivers/dma/at_xdmac.c                             | 12 ++--
 drivers/dma/imx-sdma.c                             |  4 +-
 drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c         |  3 +
 .../gpu/drm/panel/panel-raspberrypi-touchscreen.c  | 13 ++++-
 drivers/md/dm-integrity.c                          |  7 ++-
 drivers/net/can/usb/usb_8dev.c                     | 30 +++++-----
 drivers/net/ethernet/cadence/macb_main.c           |  8 +++
 drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c |  8 ++-
 drivers/net/ethernet/intel/e1000e/ich8lan.c        |  4 +-
 drivers/net/ethernet/micrel/Kconfig                |  1 -
 drivers/net/vxlan.c                                |  4 +-
 .../wireless/broadcom/brcm80211/brcmfmac/sdio.c    |  2 +-
 drivers/net/wireless/mediatek/mt76/mt76x2_pci.c    |  2 +-
 drivers/perf/arm_pmu.c                             | 10 ++--
 drivers/platform/x86/samsung-laptop.c              |  2 -
 drivers/reset/tegra/reset-bpmp.c                   |  9 ++-
 drivers/staging/android/ion/ion.c                  |  3 +
 fs/cifs/cifsfs.c                                   |  2 +-
 fs/ext4/inode.c                                    | 11 +++-
 fs/ext4/page-io.c                                  |  4 +-
 fs/ext4/super.c                                    | 19 ++++--
 fs/gfs2/rgrp.c                                     |  9 +--
 fs/stat.c                                          | 19 +++---
 include/linux/etherdevice.h                        |  5 +-
 include/net/ax25.h                                 | 12 ++++
 include/net/inet_hashtables.h                      |  5 +-
 kernel/trace/trace_events_trigger.c                |  9 ++-
 mm/page_alloc.c                                    |  2 +-
 net/ax25/af_ax25.c                                 | 38 +++++++++---
 net/ax25/ax25_dev.c                                | 28 +++++++--
 net/ax25/ax25_route.c                              | 13 ++++-
 net/ax25/ax25_subr.c                               | 20 +++++--
 net/dccp/ipv4.c                                    |  2 +-
 net/dccp/ipv6.c                                    |  2 +-
 net/ipv4/inet_connection_sock.c                    |  2 +-
 net/ipv4/inet_hashtables.c                         | 68 +++++++++++++++++++---
 net/ipv4/tcp_ipv4.c                                | 13 ++++-
 net/ipv6/tcp_ipv6.c                                | 13 ++++-
 net/netlink/af_netlink.c                           |  7 +++
 net/openvswitch/flow_netlink.c                     |  2 +-
 net/packet/af_packet.c                             | 13 +++--
 net/rxrpc/net_ns.c                                 |  2 +
 net/sched/cls_u32.c                                |  8 +--
 sound/soc/atmel/sam9g20_wm8731.c                   | 61 -------------------
 sound/soc/codecs/msm8916-wcd-digital.c             |  9 ++-
 sound/soc/soc-dapm.c                               |  6 +-
 sound/usb/midi.c                                   |  1 +
 sound/usb/usbaudio.h                               |  2 +-
 55 files changed, 359 insertions(+), 195 deletions(-)
Re: [PATCH 4.19 00/53] 4.19.240-rc1 review
Posted by Shuah Khan 4 years ago
On 4/26/22 2:20 AM, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 4.19.240 release.
> There are 53 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.
> 
> Responses should be made by Thu, 28 Apr 2022 08:17:22 +0000.
> Anything received after that time might be too late.
> 
> The whole patch series can be found in one patch at:
> 	https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.240-rc1.gz
> or in the git tree and branch at:
> 	git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
> and the diffstat can be found below.
> 
> thanks,
> 
> greg k-h
> 

Compiled and booted on my test system. No dmesg regressions.

Tested-by: Shuah Khan <skhan@linuxfoundation.org>

thanks,
-- Shuah
Re: [PATCH 4.19 00/53] 4.19.240-rc1 review
Posted by Naresh Kamboju 4 years ago
On Tue, 26 Apr 2022 at 13:57, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> This is the start of the stable review cycle for the 4.19.240 release.
> There are 53 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Thu, 28 Apr 2022 08:17:22 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
>         https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.240-rc1.gz
> or in the git tree and branch at:
>         git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h

Results from Linaro’s test farm.
No regressions on arm64, arm, x86_64, and i386.

Tested-by: Linux Kernel Functional Testing <lkft@linaro.org>

## Build
* kernel: 4.19.240-rc1
* git: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
* git branch: linux-4.19.y
* git commit: 5e5c9d690926bf43bc1405d163e02768a56c56dc
* git describe: v4.19.239-54-g5e5c9d690926
* test details:
https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-4.19.y/build/v4.19.239-54-g5e5c9d690926

## Test Regressions (compared to v4.19.239)
No test regressions found.

## Metric Regressions (compared to v4.19.239)
No metric regressions found.

## Test Fixes (compared to v4.19.239)
No test fixes found.

## Metric Fixes (compared to v4.19.239)
No metric fixes found.

## Test result summary
total: 81844, pass: 65248, fail: 1145, skip: 13273, xfail: 2178

## Build Summary
* arm: 281 total, 275 passed, 6 failed
* arm64: 39 total, 39 passed, 0 failed
* dragonboard-410c: 1 total, 1 passed, 0 failed
* hi6220-hikey: 1 total, 1 passed, 0 failed
* i386: 19 total, 19 passed, 0 failed
* juno-r2: 1 total, 1 passed, 0 failed
* mips: 27 total, 27 passed, 0 failed
* powerpc: 60 total, 54 passed, 6 failed
* s390: 12 total, 12 passed, 0 failed
* sparc: 12 total, 12 passed, 0 failed
* x15: 1 total, 1 passed, 0 failed
* x86: 1 total, 1 passed, 0 failed
* x86_64: 38 total, 38 passed, 0 failed

## Test suites summary
* fwts
* igt-gpu-tools
* kselftest-android
* kselftest-arm64
* kselftest-bpf
* kselftest-breakpoints
* kselftest-capabilities
* kselftest-cgroup
* kselftest-clone3
* kselftest-core
* kselftest-cpu-hotplug
* kselftest-cpufreq
* kselftest-drivers
* kselftest-efivarfs
* kselftest-filesystems
* kselftest-firmware
* kselftest-fpu
* kselftest-futex
* kselftest-gpio
* kselftest-intel_pstate
* kselftest-ipc
* kselftest-ir
* kselftest-kcmp
* kselftest-kexec
* kselftest-kvm
* kselftest-lib
* kselftest-livepatch
* kselftest-membarrier
* kselftest-memfd
* kselftest-memory-hotplug
* kselftest-mincore
* kselftest-mount
* kselftest-mqueue
* kselftest-net
* kselftest-netfilter
* kselftest-nsfs
* kselftest-openat2
* kselftest-pid_namespace
* kselftest-pidfd
* kselftest-proc
* kselftest-pstore
* kselftest-ptrace
* kselftest-rseq
* kselftest-rtc
* kselftest-seccomp
* kselftest-sigaltstack
* kselftest-size
* kselftest-splice
* kselftest-static_keys
* kselftest-sync
* kselftest-sysctl
* kselftest-tc-testing
* kselftest-timens
* kselftest-timers
* kselftest-tmpfs
* kselftest-tpm2
* kselftest-user
* kselftest-vm
* kselftest-x86
* kselftest-zram
* kvm-unit-tests
* libhugetlbfs
* linux-log-parser
* ltp-cap_bounds-tests
* ltp-commands-tests
* ltp-containers-tests
* ltp-controllers-tests
* ltp-cpuhotplug-tests
* ltp-crypto-tests
* ltp-cve-tests
* ltp-dio-tests
* ltp-fcntl-locktests-tests
* ltp-filecaps-tests
* ltp-fs-tests
* ltp-fs_bind-tests
* ltp-fs_perms_simple-tests
* ltp-fsx-tests
* ltp-hugetlb-tests
* ltp-io-tests
* ltp-ipc-tests
* ltp-math-tests
* ltp-mm-tests
* ltp-nptl-tests
* ltp-open-posix-tests
* ltp-pty-tests
* ltp-sched-tests
* ltp-securebits-tests
* ltp-syscalls-tests
* ltp-tracing-tests
* network-basic-tests
* packetdrill
* perf
* rcutorture
* ssuite
* v4l2-compliance
* vdso

--
Linaro LKFT
https://lkft.linaro.org
Re: [PATCH 4.19 00/53] 4.19.240-rc1 review
Posted by Samuel Zou 4 years ago

On 2022/4/26 16:20, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 4.19.240 release.
> There are 53 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.
> 
> Responses should be made by Thu, 28 Apr 2022 08:17:22 +0000.
> Anything received after that time might be too late.
> 
> The whole patch series can be found in one patch at:
> 	https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.240-rc1.gz
> or in the git tree and branch at:
> 	git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
> and the diffstat can be found below.
> 
> thanks,
> 
> greg k-h
> 

Tested on arm64 and x86 for 4.19.240-rc1,

Kernel repo:
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
Branch: linux-4.19.y
Version: 4.19.240-rc1
Commit: 5e5c9d690926bf43bc1405d163e02768a56c56dc
Compiler: gcc version 7.3.0 (GCC)

arm64:
--------------------------------------------------------------------
Testcase Result Summary:
total: 8960
passed: 8960
failed: 0
timeout: 0
--------------------------------------------------------------------

x86:
--------------------------------------------------------------------
Testcase Result Summary:
total: 8960
passed: 8960
failed: 0
timeout: 0
--------------------------------------------------------------------

Tested-by: Hulk Robot <hulkrobot@huawei.com>
Re: [PATCH 4.19 00/53] 4.19.240-rc1 review
Posted by Guenter Roeck 4 years ago
On Tue, Apr 26, 2022 at 10:20:40AM +0200, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 4.19.240 release.
> There are 53 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.
> 
> Responses should be made by Thu, 28 Apr 2022 08:17:22 +0000.
> Anything received after that time might be too late.
> 

Build results:
	total: 156 pass: 156 fail: 0
Qemu test results:
	total: 425 pass: 425 fail: 0

Tested-by: Guenter Roeck <linux@roeck-us.net>

Guenter
Re: [PATCH 4.19 00/53] 4.19.240-rc1 review
Posted by Pavel Machek 4 years ago
Hi!

> This is the start of the stable review cycle for the 4.19.240 release.
> There are 53 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.
> 
> Responses should be made by Thu, 28 Apr 2022 08:17:22 +0000.
> Anything received after that time might be too late.

I still see problems on socfpga:

[    1.227759]  mmcblk0: p1 p2 p3
[    1.269825] Micrel KSZ9031 Gigabit PHY stmmac-0:01: attached PHY driver [Micrel KSZ9031 Gigabit PHY] (mii_bus:phy_addr=stmmac-0:01, irq=POLL)
[    1.284600] socfpga-dwmac ff702000.ethernet eth0: No Safety Features support found
[    1.292374] socfpga-dwmac ff702000.ethernet eth0: registered PTP clock
[    1.299247] IPv6: ADDRCONF(NETDEV_UP): eth0: link is not ready
[    5.444552] Unable to handle kernel NULL pointer dereference at virtual address 00000000
[    5.452609] pgd = (ptrval)
[    5.455322] [00000000] *pgd=00000000
[    5.458890] Internal error: Oops: 805 [#1] SMP ARM
[    5.463660] Modules linked in:
[    5.466708] CPU: 0 PID: 766 Comm: kworker/0:2 Not tainted 4.19.240-rc1-g5e5c9d690926 #1
[    5.474674] Hardware name: Altera SOCFPGA
[    5.478679] Workqueue: events_power_efficient phy_state_machine
[    5.484579] PC is at socfpga_dwmac_fix_mac_speed+0x3c/0xbc
[    5.490044] LR is at arm_heavy_mb+0x2c/0x48
[    5.494208] pc : [<c05d9a2c>]    lr : [<c01182e8>]    psr: 60000013
[    5.500446] sp : ee84de58  ip : ee84de48  fp : ee84de7c
[    5.505648] r10: 00000001  r9 : ee8fb800  r8 : 00000000
[    5.510848] r7 : 00000000  r6 : 000003e8  r5 : eebe4000  r4 : eeb0a880
[    5.517343] r3 : 00000001  r2 : 00000730  r1 : 00000000  r0 : eeb0a880
[    5.523842] Flags: nZCv  IRQs on  FIQs on  Mode SVC_32  ISA ARM  Segment none
[    5.530945] Control: 10c5387d  Table: 0000404a  DAC: 00000051
[    5.536665] Process kworker/0:2 (pid: 766, stack limit = 0x(ptrval))
[    5.542989] Stack: (0xee84de58 to 0xee84e000)
[    5.547328] de40:                                                       ee8fb800 eebe4000
[    5.555470] de60: eebe5000 eebe4538 00610c8c eebe4500 ee84deb4 ee84de80 c05cd084 c05d99fc
[    5.563613] de80: c07058f0 c018fabc eebe4000 ee8fb800 eebe4000 ee8fba90 00000000 00000000
[    5.571756] dea0: c0c77830 00000000 ee84decc ee84deb8 c05baf3c c05ccef0 ee8fba64 ee8fb800
[    5.579899] dec0: ee84def4 ee84ded0 c05b921c c05baf08 ee8fba64 ef1cda80 ef7d2fc0 ef7d6500
[    5.588041] dee0: 00000000 c0c77830 ee84df34 ee84def8 c013e18c c05b8ee0 ef7d2fc0 ef7d2fc0
[    5.596183] df00: 00000008 ef7d2fd8 c0c02d00 ef1cda80 ef1cda94 ef7d2fc0 00000008 ef7d2fd8
[    5.604327] df20: c0c02d00 ef7d2fc0 ee84df74 ee84df38 c013f178 c013df74 c013f118 c09e2128
[    5.612469] df40: c0c77250 ffffe000 ee84df74 ef375140 ef3b9900 00000000 ee84c000 ef1cda80
[    5.620612] df60: c013f118 ef127e74 ee84dfac ee84df78 c0144ac8 c013f124 ef37515c ef37515c
[    5.628754] df80: ee84dfac ef3b9900 c014495c 00000000 00000000 00000000 00000000 00000000
[    5.636896] dfa0: 00000000 ee84dfb0 c01010e8 c0144968 00000000 00000000 00000000 00000000
[    5.645038] dfc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
[    5.653180] dfe0: 00000000 00000000 00000000 00000000 00000013 00000000 00000000 00000000
[    5.661317] Backtrace: 
[    5.663767] [<c05d99f0>] (socfpga_dwmac_fix_mac_speed) from [<c05cd084>] (stmmac_adjust_link+0x1a0/0x21c)
[    5.673294]  r9:eebe4500 r8:00610c8c r7:eebe4538 r6:eebe5000 r5:eebe4000 r4:ee8fb800
[    5.681009] [<c05ccee4>] (stmmac_adjust_link) from [<c05baf3c>] (phy_link_change+0x40/0x4c)
[    5.689323]  r10:00000000 r9:c0c77830 r8:00000000 r7:00000000 r6:ee8fba90 r5:eebe4000
[    5.697116]  r4:ee8fb800
[    5.699644] [<c05baefc>] (phy_link_change) from [<c05b921c>] (phy_state_machine+0x348/0x580)
[    5.708042]  r5:ee8fb800 r4:ee8fba64
[    5.711610] [<c05b8ed4>] (phy_state_machine) from [<c013e18c>] (process_one_work+0x224/0x518)
[    5.720098]  r9:c0c77830 r8:00000000 r7:ef7d6500 r6:ef7d2fc0 r5:ef1cda80 r4:ee8fba64
[    5.727811] [<c013df68>] (process_one_work) from [<c013f178>] (worker_thread+0x60/0x5ac)
[    5.735866]  r10:ef7d2fc0 r9:c0c02d00 r8:ef7d2fd8 r7:00000008 r6:ef7d2fc0 r5:ef1cda94
[    5.743658]  r4:ef1cda80
[    5.746187] [<c013f118>] (worker_thread) from [<c0144ac8>] (kthread+0x16c/0x174)
[    5.753551]  r10:ef127e74 r9:c013f118 r8:ef1cda80 r7:ee84c000 r6:00000000 r5:ef3b9900
[    5.761342]  r4:ef375140
[    5.763869] [<c014495c>] (kthread) from [<c01010e8>] (ret_from_fork+0x14/0x2c)
[    5.771057] Exception stack(0xee84dfb0 to 0xee84dff8)
[    5.776087] dfa0:                                     00000000 00000000 00000000 00000000
[    5.784229] dfc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
[    5.792370] dfe0: 00000000 00000000 00000000 00000000 00000013 00000000
[    5.798955]  r10:00000000 r9:00000000 r8:00000000 r7:00000000 r6:00000000 r5:c014495c
[    5.806747]  r4:ef3b9900
[    5.809273] Code: e59394b8 f57ff04e ebecfa24 e3a03001 (e1c830b0) 
[    5.815374] ---[ end trace 922ea6407635ba6b ]---

https://lava.ciplatform.org/scheduler/job/669257
https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/jobs/2377419824

Best regards,
									Pavel
										
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Re: [PATCH 4.19 00/53] 4.19.240-rc1 review
Posted by Greg Kroah-Hartman 4 years ago
On Tue, Apr 26, 2022 at 10:00:00PM +0200, Pavel Machek wrote:
> Hi!
> 
> > This is the start of the stable review cycle for the 4.19.240 release.
> > There are 53 patches in this series, all will be posted as a response
> > to this one.  If anyone has any issues with these being applied, please
> > let me know.
> > 
> > Responses should be made by Thu, 28 Apr 2022 08:17:22 +0000.
> > Anything received after that time might be too late.
> 
> I still see problems on socfpga:
> 
> [    1.227759]  mmcblk0: p1 p2 p3
> [    1.269825] Micrel KSZ9031 Gigabit PHY stmmac-0:01: attached PHY driver [Micrel KSZ9031 Gigabit PHY] (mii_bus:phy_addr=stmmac-0:01, irq=POLL)
> [    1.284600] socfpga-dwmac ff702000.ethernet eth0: No Safety Features support found
> [    1.292374] socfpga-dwmac ff702000.ethernet eth0: registered PTP clock
> [    1.299247] IPv6: ADDRCONF(NETDEV_UP): eth0: link is not ready
> [    5.444552] Unable to handle kernel NULL pointer dereference at virtual address 00000000
> [    5.452609] pgd = (ptrval)
> [    5.455322] [00000000] *pgd=00000000
> [    5.458890] Internal error: Oops: 805 [#1] SMP ARM
> [    5.463660] Modules linked in:
> [    5.466708] CPU: 0 PID: 766 Comm: kworker/0:2 Not tainted 4.19.240-rc1-g5e5c9d690926 #1
> [    5.474674] Hardware name: Altera SOCFPGA
> [    5.478679] Workqueue: events_power_efficient phy_state_machine
> [    5.484579] PC is at socfpga_dwmac_fix_mac_speed+0x3c/0xbc
> [    5.490044] LR is at arm_heavy_mb+0x2c/0x48
> [    5.494208] pc : [<c05d9a2c>]    lr : [<c01182e8>]    psr: 60000013
> [    5.500446] sp : ee84de58  ip : ee84de48  fp : ee84de7c
> [    5.505648] r10: 00000001  r9 : ee8fb800  r8 : 00000000
> [    5.510848] r7 : 00000000  r6 : 000003e8  r5 : eebe4000  r4 : eeb0a880
> [    5.517343] r3 : 00000001  r2 : 00000730  r1 : 00000000  r0 : eeb0a880
> [    5.523842] Flags: nZCv  IRQs on  FIQs on  Mode SVC_32  ISA ARM  Segment none
> [    5.530945] Control: 10c5387d  Table: 0000404a  DAC: 00000051
> [    5.536665] Process kworker/0:2 (pid: 766, stack limit = 0x(ptrval))
> [    5.542989] Stack: (0xee84de58 to 0xee84e000)
> [    5.547328] de40:                                                       ee8fb800 eebe4000
> [    5.555470] de60: eebe5000 eebe4538 00610c8c eebe4500 ee84deb4 ee84de80 c05cd084 c05d99fc
> [    5.563613] de80: c07058f0 c018fabc eebe4000 ee8fb800 eebe4000 ee8fba90 00000000 00000000
> [    5.571756] dea0: c0c77830 00000000 ee84decc ee84deb8 c05baf3c c05ccef0 ee8fba64 ee8fb800
> [    5.579899] dec0: ee84def4 ee84ded0 c05b921c c05baf08 ee8fba64 ef1cda80 ef7d2fc0 ef7d6500
> [    5.588041] dee0: 00000000 c0c77830 ee84df34 ee84def8 c013e18c c05b8ee0 ef7d2fc0 ef7d2fc0
> [    5.596183] df00: 00000008 ef7d2fd8 c0c02d00 ef1cda80 ef1cda94 ef7d2fc0 00000008 ef7d2fd8
> [    5.604327] df20: c0c02d00 ef7d2fc0 ee84df74 ee84df38 c013f178 c013df74 c013f118 c09e2128
> [    5.612469] df40: c0c77250 ffffe000 ee84df74 ef375140 ef3b9900 00000000 ee84c000 ef1cda80
> [    5.620612] df60: c013f118 ef127e74 ee84dfac ee84df78 c0144ac8 c013f124 ef37515c ef37515c
> [    5.628754] df80: ee84dfac ef3b9900 c014495c 00000000 00000000 00000000 00000000 00000000
> [    5.636896] dfa0: 00000000 ee84dfb0 c01010e8 c0144968 00000000 00000000 00000000 00000000
> [    5.645038] dfc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
> [    5.653180] dfe0: 00000000 00000000 00000000 00000000 00000013 00000000 00000000 00000000
> [    5.661317] Backtrace: 
> [    5.663767] [<c05d99f0>] (socfpga_dwmac_fix_mac_speed) from [<c05cd084>] (stmmac_adjust_link+0x1a0/0x21c)
> [    5.673294]  r9:eebe4500 r8:00610c8c r7:eebe4538 r6:eebe5000 r5:eebe4000 r4:ee8fb800
> [    5.681009] [<c05ccee4>] (stmmac_adjust_link) from [<c05baf3c>] (phy_link_change+0x40/0x4c)
> [    5.689323]  r10:00000000 r9:c0c77830 r8:00000000 r7:00000000 r6:ee8fba90 r5:eebe4000
> [    5.697116]  r4:ee8fb800
> [    5.699644] [<c05baefc>] (phy_link_change) from [<c05b921c>] (phy_state_machine+0x348/0x580)
> [    5.708042]  r5:ee8fb800 r4:ee8fba64
> [    5.711610] [<c05b8ed4>] (phy_state_machine) from [<c013e18c>] (process_one_work+0x224/0x518)
> [    5.720098]  r9:c0c77830 r8:00000000 r7:ef7d6500 r6:ef7d2fc0 r5:ef1cda80 r4:ee8fba64
> [    5.727811] [<c013df68>] (process_one_work) from [<c013f178>] (worker_thread+0x60/0x5ac)
> [    5.735866]  r10:ef7d2fc0 r9:c0c02d00 r8:ef7d2fd8 r7:00000008 r6:ef7d2fc0 r5:ef1cda94
> [    5.743658]  r4:ef1cda80
> [    5.746187] [<c013f118>] (worker_thread) from [<c0144ac8>] (kthread+0x16c/0x174)
> [    5.753551]  r10:ef127e74 r9:c013f118 r8:ef1cda80 r7:ee84c000 r6:00000000 r5:ef3b9900
> [    5.761342]  r4:ef375140
> [    5.763869] [<c014495c>] (kthread) from [<c01010e8>] (ret_from_fork+0x14/0x2c)
> [    5.771057] Exception stack(0xee84dfb0 to 0xee84dff8)
> [    5.776087] dfa0:                                     00000000 00000000 00000000 00000000
> [    5.784229] dfc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
> [    5.792370] dfe0: 00000000 00000000 00000000 00000000 00000013 00000000
> [    5.798955]  r10:00000000 r9:00000000 r8:00000000 r7:00000000 r6:00000000 r5:c014495c
> [    5.806747]  r4:ef3b9900
> [    5.809273] Code: e59394b8 f57ff04e ebecfa24 e3a03001 (e1c830b0) 
> [    5.815374] ---[ end trace 922ea6407635ba6b ]---
> 
> https://lava.ciplatform.org/scheduler/job/669257
> https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/jobs/2377419824

Can you run git bisect?
Re: [PATCH 4.19 00/53] 4.19.240-rc1 review [net: ethernet: stmmac: fix altr_tse_pcs function when using a]
Posted by Pavel Machek 4 years ago
Hi!

> > > This is the start of the stable review cycle for the 4.19.240 release.
> > > There are 53 patches in this series, all will be posted as a response
> > > to this one.  If anyone has any issues with these being applied, please
> > > let me know.
...
> > I still see problems on socfpga:
> > 
> > [    1.227759]  mmcblk0: p1 p2 p3
> > [    1.269825] Micrel KSZ9031 Gigabit PHY stmmac-0:01: attached PHY driver [Micrel KSZ9031 Gigabit PHY] (mii_bus:phy_addr=stmmac-0:01, irq=POLL)
> > [    1.284600] socfpga-dwmac ff702000.ethernet eth0: No Safety Features support found
> > [    1.292374] socfpga-dwmac ff702000.ethernet eth0: registered PTP clock
> > [    1.299247] IPv6: ADDRCONF(NETDEV_UP): eth0: link is not ready
> > [    5.444552] Unable to handle kernel NULL pointer dereference at virtual address 00000000
...
> > [    5.478679] Workqueue: events_power_efficient phy_state_machine
> > [    5.484579] PC is at socfpga_dwmac_fix_mac_speed+0x3c/0xbc
> > [    5.490044] LR is at arm_heavy_mb+0x2c/0x48

> > https://lava.ciplatform.org/scheduler/job/669257
> > https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/jobs/2377419824
> 
> Can you run git bisect?

Not a bisect, but we guessed e2423aa174e6 was responsible, and tested
it boots with that patch reverted.

Best regards,
								Pavel

commit e2423aa174e6c3e9805e96db778245ba73cdd88c

    net: ethernet: stmmac: fix altr_tse_pcs function when using a
    fixed-link

    [ Upstream commit a6aaa00324240967272b451bfa772547bd576ee6 ]
    
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Re: [PATCH 4.19 00/53] 4.19.240-rc1 review [net: ethernet: stmmac: fix altr_tse_pcs function when using a]
Posted by Greg Kroah-Hartman 4 years ago
On Fri, Apr 29, 2022 at 09:43:41AM +0200, Pavel Machek wrote:
> Hi!
> 
> > > > This is the start of the stable review cycle for the 4.19.240 release.
> > > > There are 53 patches in this series, all will be posted as a response
> > > > to this one.  If anyone has any issues with these being applied, please
> > > > let me know.
> ...
> > > I still see problems on socfpga:
> > > 
> > > [    1.227759]  mmcblk0: p1 p2 p3
> > > [    1.269825] Micrel KSZ9031 Gigabit PHY stmmac-0:01: attached PHY driver [Micrel KSZ9031 Gigabit PHY] (mii_bus:phy_addr=stmmac-0:01, irq=POLL)
> > > [    1.284600] socfpga-dwmac ff702000.ethernet eth0: No Safety Features support found
> > > [    1.292374] socfpga-dwmac ff702000.ethernet eth0: registered PTP clock
> > > [    1.299247] IPv6: ADDRCONF(NETDEV_UP): eth0: link is not ready
> > > [    5.444552] Unable to handle kernel NULL pointer dereference at virtual address 00000000
> ...
> > > [    5.478679] Workqueue: events_power_efficient phy_state_machine
> > > [    5.484579] PC is at socfpga_dwmac_fix_mac_speed+0x3c/0xbc
> > > [    5.490044] LR is at arm_heavy_mb+0x2c/0x48
> 
> > > https://lava.ciplatform.org/scheduler/job/669257
> > > https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/jobs/2377419824
> > 
> > Can you run git bisect?
> 
> Not a bisect, but we guessed e2423aa174e6 was responsible, and tested
> it boots with that patch reverted.
> 
> Best regards,
> 								Pavel
> 
> commit e2423aa174e6c3e9805e96db778245ba73cdd88c
> 
>     net: ethernet: stmmac: fix altr_tse_pcs function when using a
>     fixed-link
> 
>     [ Upstream commit a6aaa00324240967272b451bfa772547bd576ee6 ]
>     

Thanks, now reverted from 4.19.y, 4.14.y, and 4.9.y

greg k-h
Re: [PATCH 4.19 00/53] 4.19.240-rc1 review [net: ethernet: stmmac: fix altr_tse_pcs function when using a]
Posted by Pavel Machek 4 years ago
Hi!

> > > Can you run git bisect?
> > 
> > Not a bisect, but we guessed e2423aa174e6 was responsible, and tested
> > it boots with that patch reverted.
> > 
> > commit e2423aa174e6c3e9805e96db778245ba73cdd88c
> > 
> >     net: ethernet: stmmac: fix altr_tse_pcs function when using a
> >     fixed-link
> > 
> >     [ Upstream commit a6aaa00324240967272b451bfa772547bd576ee6 ]
> >     
> 
> Thanks, now reverted from 4.19.y, 4.14.y, and 4.9.y

Thank you!

Best regards,
								Pavel
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Re: [PATCH 4.19 00/53] 4.19.240-rc1 review [net: ethernet: stmmac: fix altr_tse_pcs function when using a]
Posted by Dinh Nguyen 4 years ago

On 4/29/22 04:22, Greg Kroah-Hartman wrote:
> On Fri, Apr 29, 2022 at 09:43:41AM +0200, Pavel Machek wrote:
>> Hi!
>>
>>>>> This is the start of the stable review cycle for the 4.19.240 release.
>>>>> There are 53 patches in this series, all will be posted as a response
>>>>> to this one.  If anyone has any issues with these being applied, please
>>>>> let me know.
>> ...
>>>> I still see problems on socfpga:
>>>>
>>>> [    1.227759]  mmcblk0: p1 p2 p3
>>>> [    1.269825] Micrel KSZ9031 Gigabit PHY stmmac-0:01: attached PHY driver [Micrel KSZ9031 Gigabit PHY] (mii_bus:phy_addr=stmmac-0:01, irq=POLL)
>>>> [    1.284600] socfpga-dwmac ff702000.ethernet eth0: No Safety Features support found
>>>> [    1.292374] socfpga-dwmac ff702000.ethernet eth0: registered PTP clock
>>>> [    1.299247] IPv6: ADDRCONF(NETDEV_UP): eth0: link is not ready
>>>> [    5.444552] Unable to handle kernel NULL pointer dereference at virtual address 00000000
>> ...
>>>> [    5.478679] Workqueue: events_power_efficient phy_state_machine
>>>> [    5.484579] PC is at socfpga_dwmac_fix_mac_speed+0x3c/0xbc
>>>> [    5.490044] LR is at arm_heavy_mb+0x2c/0x48
>>
>>>> https://lava.ciplatform.org/scheduler/job/669257
>>>> https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/jobs/2377419824
>>>
>>> Can you run git bisect?
>>
>> Not a bisect, but we guessed e2423aa174e6 was responsible, and tested
>> it boots with that patch reverted.
>>
>> Best regards,
>> 								Pavel
>>
>> commit e2423aa174e6c3e9805e96db778245ba73cdd88c
>>
>>      net: ethernet: stmmac: fix altr_tse_pcs function when using a
>>      fixed-link
>>
>>      [ Upstream commit a6aaa00324240967272b451bfa772547bd576ee6 ]
>>      
> 
> Thanks, now reverted from 4.19.y, 4.14.y, and 4.9.y
> 

I have fixed this with this patch that is in linux-next:

5fd1fe4807f9 ("net: ethernet: stmmac: fix write to sgmii_adapter_base")

Dinh
Re: [PATCH 4.19 00/53] 4.19.240-rc1 review
Posted by Sudip Mukherjee 4 years ago
Hi Greg,

On Tue, Apr 26, 2022 at 10:20:40AM +0200, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 4.19.240 release.
> There are 53 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.
> 
> Responses should be made by Thu, 28 Apr 2022 08:17:22 +0000.
> Anything received after that time might be too late.

Build test:
mips (gcc version 11.2.1 20220408): 63 configs -> no  failure
arm (gcc version 11.2.1 20220408): 116 configs -> no new failure
arm64 (gcc version 11.2.1 20220408): 2 configs -> no failure
x86_64 (gcc version 11.2.1 20220408): 4 configs -> no failure

Boot test:
x86_64: Booted on my test laptop. No regression.
x86_64: Booted on qemu. No regression. [1]

[1]. https://openqa.qa.codethink.co.uk/tests/1065


Tested-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>

--
Regards
Sudip