pgprot.pgprot is a non-portable code, it should be replaced by
portable macro pgprot_val.

Signed-off-by: liusongtang <liusongtang@huawei.com>

---
v2: add 'memory_hotplug' in the subject line
v1: https://lore.kernel.org/all/a5b58a66-bdc3-94df-6af5-c647da888c17@huawei.com/
---
 mm/memory_hotplug.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
index 416b38c..bf7d181 100644
--- a/mm/memory_hotplug.c
+++ b/mm/memory_hotplug.c
@@ -303,7 +303,7 @@ int __ref __add_pages(int nid, unsigned long pfn, unsigned long nr_pages,
 	int err;
 	struct vmem_altmap *altmap = params->altmap;
 
-	if (WARN_ON_ONCE(!params->pgprot.pgprot))
+	if (WARN_ON_ONCE(!pgprot_val(params->pgprot)))
 		return -EINVAL;
 
 	VM_BUG_ON(!mhp_range_allowed(PFN_PHYS(pfn), nr_pages * PAGE_SIZE, false));
-- 
2.12.3

On 4/26/22 12:43, liusongtang wrote:
> pgprot.pgprot is a non-portable code, it should be replaced by
> portable macro pgprot_val.
> 
> Signed-off-by: liusongtang <liusongtang@huawei.com>

Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>

> 
> ---
> v2: add 'memory_hotplug' in the subject line
> v1: https://lore.kernel.org/all/a5b58a66-bdc3-94df-6af5-c647da888c17@huawei.com/
> ---
>  mm/memory_hotplug.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
> index 416b38c..bf7d181 100644
> --- a/mm/memory_hotplug.c
> +++ b/mm/memory_hotplug.c
> @@ -303,7 +303,7 @@ int __ref __add_pages(int nid, unsigned long pfn, unsigned long nr_pages,
>  	int err;
>  	struct vmem_altmap *altmap = params->altmap;
>  
> -	if (WARN_ON_ONCE(!params->pgprot.pgprot))
> +	if (WARN_ON_ONCE(!pgprot_val(params->pgprot)))
>  		return -EINVAL;
>  
>  	VM_BUG_ON(!mhp_range_allowed(PFN_PHYS(pfn), nr_pages * PAGE_SIZE, false));