1. Patchew
  2. linux
  3. View series

[PATCH] mfd: sprd: Add SC2730 PMIC to SPI device ID table

Cixi Geng posted 1 patch 4 years ago 
drivers/mfd/sprd-sc27xx-spi.c | 1 +
1 file changed, 1 insertion(+)
[PATCH] mfd: sprd: Add SC2730 PMIC to SPI device ID table
Posted by Cixi Geng 4 years ago 
From: Cixi Geng <cixi.geng1@unisoc.com>

Add the SC2730 PMIC support for module autoloading
through SPI modalises.

Signed-off-by: Cixi Geng <cixi.geng1@unisoc.com>
---
 drivers/mfd/sprd-sc27xx-spi.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mfd/sprd-sc27xx-spi.c b/drivers/mfd/sprd-sc27xx-spi.c
index 55d2c31bdfb2..cf4f89114ae4 100644
--- a/drivers/mfd/sprd-sc27xx-spi.c
+++ b/drivers/mfd/sprd-sc27xx-spi.c
@@ -248,6 +248,7 @@ MODULE_DEVICE_TABLE(of, sprd_pmic_match);
 
 static const struct spi_device_id sprd_pmic_spi_ids[] = {
 	{ .name = "sc2731", .driver_data = (unsigned long)&sc2731_data },
+	{ .name = "sc2730", .driver_data = (unsigned long)&sc2730_data },
 	{},
 };
 MODULE_DEVICE_TABLE(spi, sprd_pmic_spi_ids);
-- 
2.25.1
Re: [PATCH] mfd: sprd: Add SC2730 PMIC to SPI device ID table
Posted by Lee Jones 4 years ago 
On Mon, 25 Apr 2022, Cixi Geng wrote:

> From: Cixi Geng <cixi.geng1@unisoc.com>
> 
> Add the SC2730 PMIC support for module autoloading
> through SPI modalises.
> 
> Signed-off-by: Cixi Geng <cixi.geng1@unisoc.com>
> ---
>  drivers/mfd/sprd-sc27xx-spi.c | 1 +
>  1 file changed, 1 insertion(+)

Applied, thanks.

-- 
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
Re: [PATCH] mfd: sprd: Add SC2730 PMIC to SPI device ID table
Posted by Lee Jones 4 years ago 
On Mon, 25 Apr 2022, Cixi Geng wrote:

> From: Cixi Geng <cixi.geng1@unisoc.com>
> 
> Add the SC2730 PMIC support for module autoloading
> through SPI modalises.
> 
> Signed-off-by: Cixi Geng <cixi.geng1@unisoc.com>
> ---
>  drivers/mfd/sprd-sc27xx-spi.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mfd/sprd-sc27xx-spi.c b/drivers/mfd/sprd-sc27xx-spi.c
> index 55d2c31bdfb2..cf4f89114ae4 100644
> --- a/drivers/mfd/sprd-sc27xx-spi.c
> +++ b/drivers/mfd/sprd-sc27xx-spi.c
> @@ -248,6 +248,7 @@ MODULE_DEVICE_TABLE(of, sprd_pmic_match);
>  
>  static const struct spi_device_id sprd_pmic_spi_ids[] = {
>  	{ .name = "sc2731", .driver_data = (unsigned long)&sc2731_data },
> +	{ .name = "sc2730", .driver_data = (unsigned long)&sc2730_data },

Nicer if these were ordered with the smallest number at the top.

>  	{},
>  };
>  MODULE_DEVICE_TABLE(spi, sprd_pmic_spi_ids);

-- 
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
Re: [PATCH] mfd: sprd: Add SC2730 PMIC to SPI device ID table
Posted by Cixi Geng 4 years ago 
Lee Jones <lee.jones@linaro.org> 于2022年4月26日周二 22:44写道：
>
> On Mon, 25 Apr 2022, Cixi Geng wrote:
>
> > From: Cixi Geng <cixi.geng1@unisoc.com>
> >
> > Add the SC2730 PMIC support for module autoloading
> > through SPI modalises.
> >
> > Signed-off-by: Cixi Geng <cixi.geng1@unisoc.com>
> > ---
> >  drivers/mfd/sprd-sc27xx-spi.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/mfd/sprd-sc27xx-spi.c b/drivers/mfd/sprd-sc27xx-spi.c
> > index 55d2c31bdfb2..cf4f89114ae4 100644
> > --- a/drivers/mfd/sprd-sc27xx-spi.c
> > +++ b/drivers/mfd/sprd-sc27xx-spi.c
> > @@ -248,6 +248,7 @@ MODULE_DEVICE_TABLE(of, sprd_pmic_match);
> >
> >  static const struct spi_device_id sprd_pmic_spi_ids[] = {
> >       { .name = "sc2731", .driver_data = (unsigned long)&sc2731_data },
> > +     { .name = "sc2730", .driver_data = (unsigned long)&sc2730_data },
>
> Nicer if these were ordered with the smallest number at the top.
I followed the order of struct of_device_id sprd_pmic_match[1],Do I need
adjust it as well?
[1].https://elixir.bootlin.com/linux/v5.18-rc4/source/drivers/mfd/sprd-sc27xx-spi.c#L242
>
> >       {},
> >  };
> >  MODULE_DEVICE_TABLE(spi, sprd_pmic_spi_ids);
>
> --
> Lee Jones [李琼斯]
> Principal Technical Lead - Developer Services
> Linaro.org │ Open source software for Arm SoCs
> Follow Linaro: Facebook | Twitter | Blog
Re: [PATCH] mfd: sprd: Add SC2730 PMIC to SPI device ID table
Posted by Lee Jones 4 years ago 
On Wed, 27 Apr 2022, Cixi Geng wrote:

> Lee Jones <lee.jones@linaro.org> 于2022年4月26日周二 22:44写道：
> >
> > On Mon, 25 Apr 2022, Cixi Geng wrote:
> >
> > > From: Cixi Geng <cixi.geng1@unisoc.com>
> > >
> > > Add the SC2730 PMIC support for module autoloading
> > > through SPI modalises.
> > >
> > > Signed-off-by: Cixi Geng <cixi.geng1@unisoc.com>
> > > ---
> > >  drivers/mfd/sprd-sc27xx-spi.c | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/drivers/mfd/sprd-sc27xx-spi.c b/drivers/mfd/sprd-sc27xx-spi.c
> > > index 55d2c31bdfb2..cf4f89114ae4 100644
> > > --- a/drivers/mfd/sprd-sc27xx-spi.c
> > > +++ b/drivers/mfd/sprd-sc27xx-spi.c
> > > @@ -248,6 +248,7 @@ MODULE_DEVICE_TABLE(of, sprd_pmic_match);
> > >
> > >  static const struct spi_device_id sprd_pmic_spi_ids[] = {
> > >       { .name = "sc2731", .driver_data = (unsigned long)&sc2731_data },
> > > +     { .name = "sc2730", .driver_data = (unsigned long)&sc2730_data },
> >
> > Nicer if these were ordered with the smallest number at the top.
> I followed the order of struct of_device_id sprd_pmic_match[1],Do I need
> adjust it as well?
> [1].https://elixir.bootlin.com/linux/v5.18-rc4/source/drivers/mfd/sprd-sc27xx-spi.c#L242

I've applied this patch for now.

Could you please submit a follow-up changing both?

-- 
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
Re: [PATCH] mfd: sprd: Add SC2730 PMIC to SPI device ID table
Posted by Cixi Geng 4 years ago 
Lee Jones <lee.jones@linaro.org> 于2022年4月27日周三 15:37写道：
>
> On Wed, 27 Apr 2022, Cixi Geng wrote:
>
> > Lee Jones <lee.jones@linaro.org> 于2022年4月26日周二 22:44写道：
> > >
> > > On Mon, 25 Apr 2022, Cixi Geng wrote:
> > >
> > > > From: Cixi Geng <cixi.geng1@unisoc.com>
> > > >
> > > > Add the SC2730 PMIC support for module autoloading
> > > > through SPI modalises.
> > > >
> > > > Signed-off-by: Cixi Geng <cixi.geng1@unisoc.com>
> > > > ---
> > > >  drivers/mfd/sprd-sc27xx-spi.c | 1 +
> > > >  1 file changed, 1 insertion(+)
> > > >
> > > > diff --git a/drivers/mfd/sprd-sc27xx-spi.c b/drivers/mfd/sprd-sc27xx-spi.c
> > > > index 55d2c31bdfb2..cf4f89114ae4 100644
> > > > --- a/drivers/mfd/sprd-sc27xx-spi.c
> > > > +++ b/drivers/mfd/sprd-sc27xx-spi.c
> > > > @@ -248,6 +248,7 @@ MODULE_DEVICE_TABLE(of, sprd_pmic_match);
> > > >
> > > >  static const struct spi_device_id sprd_pmic_spi_ids[] = {
> > > >       { .name = "sc2731", .driver_data = (unsigned long)&sc2731_data },
> > > > +     { .name = "sc2730", .driver_data = (unsigned long)&sc2730_data },
> > >
> > > Nicer if these were ordered with the smallest number at the top.
> > I followed the order of struct of_device_id sprd_pmic_match[1],Do I need
> > adjust it as well?
> > [1].https://elixir.bootlin.com/linux/v5.18-rc4/source/drivers/mfd/sprd-sc27xx-spi.c#L242
>
> I've applied this patch for now.
>
> Could you please submit a follow-up changing both?
Thanks, a new patch to change the order send.
>
> --
> Lee Jones [李琼斯]
> Principal Technical Lead - Developer Services
> Linaro.org │ Open source software for Arm SoCs
> Follow Linaro: Facebook | Twitter | Blog

Patchew 2.1-devel-ea86937

© 2016 - 2026 Red Hat, Inc.