[PATCH] irqchip/sun6i-r: Use NULL for chip_data

Samuel Holland posted 1 patch 4 years ago
There is a newer version of this series
drivers/irqchip/irq-sun6i-r.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
[PATCH] irqchip/sun6i-r: Use NULL for chip_data
Posted by Samuel Holland 4 years ago
sparse complains about using an integer as a NULL pointer.

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Samuel Holland <samuel@sholland.org>
---

 drivers/irqchip/irq-sun6i-r.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/irqchip/irq-sun6i-r.c b/drivers/irqchip/irq-sun6i-r.c
index 4cd3e533740b..a01e44049415 100644
--- a/drivers/irqchip/irq-sun6i-r.c
+++ b/drivers/irqchip/irq-sun6i-r.c
@@ -249,11 +249,13 @@ static int sun6i_r_intc_domain_alloc(struct irq_domain *domain,
 	for (i = 0; i < nr_irqs; ++i, ++hwirq, ++virq) {
 		if (hwirq == nmi_hwirq) {
 			irq_domain_set_hwirq_and_chip(domain, virq, hwirq,
-						      &sun6i_r_intc_nmi_chip, 0);
+						      &sun6i_r_intc_nmi_chip,
+						      NULL);
 			irq_set_handler(virq, handle_fasteoi_ack_irq);
 		} else {
 			irq_domain_set_hwirq_and_chip(domain, virq, hwirq,
-						      &sun6i_r_intc_wakeup_chip, 0);
+						      &sun6i_r_intc_wakeup_chip,
+						      NULL);
 		}
 	}
 
-- 
2.35.1
Re: [PATCH] irqchip/sun6i-r: Use NULL for chip_data
Posted by Jernej Škrabec 4 years ago
Dne nedelja, 24. april 2022 ob 19:39:51 CEST je Samuel Holland napisal(a):
> sparse complains about using an integer as a NULL pointer.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Samuel Holland <samuel@sholland.org>

Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com>

Best regards,
Jernej

> ---
> 
>  drivers/irqchip/irq-sun6i-r.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/irqchip/irq-sun6i-r.c b/drivers/irqchip/irq-sun6i-r.c
> index 4cd3e533740b..a01e44049415 100644
> --- a/drivers/irqchip/irq-sun6i-r.c
> +++ b/drivers/irqchip/irq-sun6i-r.c
> @@ -249,11 +249,13 @@ static int sun6i_r_intc_domain_alloc(struct irq_domain 
*domain,
>  	for (i = 0; i < nr_irqs; ++i, ++hwirq, ++virq) {
>  		if (hwirq == nmi_hwirq) {
>  			irq_domain_set_hwirq_and_chip(domain, virq, 
hwirq,
> -						      
&sun6i_r_intc_nmi_chip, 0);
> +						      
&sun6i_r_intc_nmi_chip,
> +						      NULL);
>  			irq_set_handler(virq, 
handle_fasteoi_ack_irq);
>  		} else {
>  			irq_domain_set_hwirq_and_chip(domain, virq, 
hwirq,
> -						      
&sun6i_r_intc_wakeup_chip, 0);
> +						      
&sun6i_r_intc_wakeup_chip,
> +						      NULL);
>  		}
>  	}
>  
> -- 
> 2.35.1
> 
>
[irqchip: irq/irqchip-next] irqchip/sun6i-r: Use NULL for chip_data
Posted by irqchip-bot for Samuel Holland 4 years ago
The following commit has been merged into the irq/irqchip-next branch of irqchip:

Commit-ID:     1b2eb89ccf4ffff2ea83c41451b3fed709cd3fc8
Gitweb:        https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/1b2eb89ccf4ffff2ea83c41451b3fed709cd3fc8
Author:        Samuel Holland <samuel@sholland.org>
AuthorDate:    Sun, 24 Apr 2022 12:39:51 -05:00
Committer:     Marc Zyngier <maz@kernel.org>
CommitterDate: Wed, 04 May 2022 16:36:59 +01:00

irqchip/sun6i-r: Use NULL for chip_data

sparse complains about using an integer as a NULL pointer.

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Samuel Holland <samuel@sholland.org>
Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20220424173952.36591-1-samuel@sholland.org
---
 drivers/irqchip/irq-sun6i-r.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/irqchip/irq-sun6i-r.c b/drivers/irqchip/irq-sun6i-r.c
index 4cd3e53..a01e440 100644
--- a/drivers/irqchip/irq-sun6i-r.c
+++ b/drivers/irqchip/irq-sun6i-r.c
@@ -249,11 +249,13 @@ static int sun6i_r_intc_domain_alloc(struct irq_domain *domain,
 	for (i = 0; i < nr_irqs; ++i, ++hwirq, ++virq) {
 		if (hwirq == nmi_hwirq) {
 			irq_domain_set_hwirq_and_chip(domain, virq, hwirq,
-						      &sun6i_r_intc_nmi_chip, 0);
+						      &sun6i_r_intc_nmi_chip,
+						      NULL);
 			irq_set_handler(virq, handle_fasteoi_ack_irq);
 		} else {
 			irq_domain_set_hwirq_and_chip(domain, virq, hwirq,
-						      &sun6i_r_intc_wakeup_chip, 0);
+						      &sun6i_r_intc_wakeup_chip,
+						      NULL);
 		}
 	}