Sparse reports thise issue
ptdma-dmaengine.c:262:1: warning: symbol 'pt_tx_status' was not declared. Should it be static?

pt_tx_status, like other pt_* functions in ptdam-dmaengine.c, is assigned
to a function pointer and is not used directly outside of this file.
So change its storage-class specifier to static.

Signed-off-by: Tom Rix <trix@redhat.com>
---
 drivers/dma/ptdma/ptdma-dmaengine.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma/ptdma/ptdma-dmaengine.c b/drivers/dma/ptdma/ptdma-dmaengine.c
index ea07cc42f4d0..cc22d162ce25 100644
--- a/drivers/dma/ptdma/ptdma-dmaengine.c
+++ b/drivers/dma/ptdma/ptdma-dmaengine.c
@@ -258,7 +258,7 @@ static void pt_issue_pending(struct dma_chan *dma_chan)
 		pt_cmd_callback(desc, 0);
 }
 
-enum dma_status
+static enum dma_status
 pt_tx_status(struct dma_chan *c, dma_cookie_t cookie,
 		struct dma_tx_state *txstate)
 {
-- 
2.27.0

On 23-04-22, 09:10, Tom Rix wrote:
> Sparse reports thise issue
> ptdma-dmaengine.c:262:1: warning: symbol 'pt_tx_status' was not declared. Should it be static?
> 
> pt_tx_status, like other pt_* functions in ptdam-dmaengine.c, is assigned
> to a function pointer and is not used directly outside of this file.
> So change its storage-class specifier to static.

Patch for this is already in next

-- 
~Vinod